From: Stefan Beller <stefanbeller@gmail.com>
To: Junio C Hamano <gitster@pobox.com>, Stefan Beller <sbeller@google.com>
Cc: git@vger.kernel.org, sunshine@sunshineco.com, tr@thomasrast.ch
Subject: Re: [PATCHv3 3/6] line-log.c: fix a memleak
Date: Mon, 30 Mar 2015 22:35:59 -0700 [thread overview]
Message-ID: <551A323F.9030305@gmail.com> (raw)
In-Reply-To: <xmqqsiclsqlz.fsf@gitster.dls.corp.google.com>
On 30.03.2015 22:06, Junio C Hamano wrote:
> If add-line-range does not take ownership of
> parent_range from us, shouldn't we be freeing it whether we called
> it or not???
In my understanding it does take ownership of it. (According to my code
review on friday)
next prev parent reply other threads:[~2015-03-31 5:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-31 1:22 [PATCHv3 0/6] Memory leaks once again Stefan Beller
2015-03-31 1:22 ` [PATCHv3 1/6] shallow: fix a memleak Stefan Beller
2015-03-31 2:52 ` Eric Sunshine
2015-03-31 1:22 ` [PATCHv3 2/6] line-log.c: " Stefan Beller
2015-03-31 1:22 ` [PATCHv3 3/6] " Stefan Beller
2015-03-31 4:42 ` Torsten Bögershausen
2015-03-31 5:06 ` Junio C Hamano
2015-03-31 5:35 ` Stefan Beller [this message]
2015-03-31 19:03 ` Junio C Hamano
2015-03-31 1:22 ` [PATCHv3 4/6] wt-status.c: " Stefan Beller
2015-03-31 1:22 ` [PATCHv3 5/6] pack-bitmap.c: " Stefan Beller
2015-03-31 3:32 ` Jeff King
2015-03-31 1:22 ` [PATCHv3 6/6] entry.c: " Stefan Beller
2015-03-31 5:41 ` Junio C Hamano
2015-03-31 8:36 ` John Keeping
2015-03-31 19:12 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=551A323F.9030305@gmail.com \
--to=stefanbeller@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sbeller@google.com \
--cc=sunshine@sunshineco.com \
--cc=tr@thomasrast.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).