From: Stefan Beller <sbeller@google.com>
To: gitster@pobox.com, git@vger.kernel.org
Cc: Stefan Beller <sbeller@google.com>,
sunshine@sunshineco.com, knittl89+git@googlemail.com,
worldhello.net@gmail.com
Subject: [PATCHv3 4/6] wt-status.c: fix a memleak
Date: Mon, 30 Mar 2015 18:22:09 -0700 [thread overview]
Message-ID: <1427764931-27745-5-git-send-email-sbeller@google.com> (raw)
In-Reply-To: <1427764931-27745-1-git-send-email-sbeller@google.com>
In any code path of shorten_unambiguous_ref the return value is a
xstrdup(some string), so it is safe to free the variable `base`
in any codepath.
Signed-off-by: Stefan Beller <sbeller@google.com>
---
wt-status.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/wt-status.c b/wt-status.c
index 853419f..38cb165 100644
--- a/wt-status.c
+++ b/wt-status.c
@@ -1550,6 +1550,7 @@ static void wt_shortstatus_print_tracking(struct wt_status *s)
base = shorten_unambiguous_ref(base, 0);
color_fprintf(s->fp, header_color, "...");
color_fprintf(s->fp, branch_color_remote, "%s", base);
+ free((char *)base);
if (!upstream_is_gone && !num_ours && !num_theirs) {
fputc(s->null_termination ? '\0' : '\n', s->fp);
--
2.3.0.81.gc37f363
next prev parent reply other threads:[~2015-03-31 1:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-31 1:22 [PATCHv3 0/6] Memory leaks once again Stefan Beller
2015-03-31 1:22 ` [PATCHv3 1/6] shallow: fix a memleak Stefan Beller
2015-03-31 2:52 ` Eric Sunshine
2015-03-31 1:22 ` [PATCHv3 2/6] line-log.c: " Stefan Beller
2015-03-31 1:22 ` [PATCHv3 3/6] " Stefan Beller
2015-03-31 4:42 ` Torsten Bögershausen
2015-03-31 5:06 ` Junio C Hamano
2015-03-31 5:35 ` Stefan Beller
2015-03-31 19:03 ` Junio C Hamano
2015-03-31 1:22 ` Stefan Beller [this message]
2015-03-31 1:22 ` [PATCHv3 5/6] pack-bitmap.c: " Stefan Beller
2015-03-31 3:32 ` Jeff King
2015-03-31 1:22 ` [PATCHv3 6/6] entry.c: " Stefan Beller
2015-03-31 5:41 ` Junio C Hamano
2015-03-31 8:36 ` John Keeping
2015-03-31 19:12 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427764931-27745-5-git-send-email-sbeller@google.com \
--to=sbeller@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=knittl89+git@googlemail.com \
--cc=sunshine@sunshineco.com \
--cc=worldhello.net@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).