git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Michael J Gruber <git@drmicha.warpmail.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Julien Cretel <j.cretel@umail.ucc.ie>
Subject: Re: [PATCHv2 0/2] log decorations for HEAD
Date: Wed, 11 Mar 2015 09:02:38 +0100	[thread overview]
Message-ID: <54FFF69E.3090104@drmicha.warpmail.net> (raw)
In-Reply-To: <xmqqr3sw234j.fsf@gitster.dls.corp.google.com>

Junio C Hamano venit, vidit, dixit 10.03.2015 18:06:
> Michael J Gruber <git@drmicha.warpmail.net> writes:
> 
>> So it didn't take too long to convince me after all :)
>>
>> Here comes Junio's version, preceded by a cleanup of the color
>> setting and resetting for decorations.
>>
>> Junio C Hamano (1):
>>   log: decorate HEAD with branch name
>>
>> Michael J Gruber (1):
>>   log-tree: properly reset colors
>>
>>  log-tree.c                        | 76 ++++++++++++++++++++++++++++++++++-----
>>  t/t4013/diff.log_--decorate_--all |  2 +-
>>  t/t4207-log-decoration-colors.sh  | 16 ++++-----
>>  3 files changed, 77 insertions(+), 17 deletions(-)
> 
> Hmph, is the "do not leak commit color" one the same as 5ee87585
> (log --decorate: do not leak "commit" color into the next item,
> 2015-03-04) aka $gmane/264788 [*1*] or is there something I missed?
> 

Uh, I missed that one. The commit msg confuses me somewhat (color.diff
vs color.decorate), but the patch to log-tree.c is the same, and so I
assume the patch to t4207 is the same, too. 2/2 from here should go on
top of 7/7 from there, accordingly.

> [References]
> 
> *1* http://thread.gmane.org/gmane.comp.version-control.git/264063/focus=264788
> 
> 
> 
> 

  reply	other threads:[~2015-03-11  8:02 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-16 22:42 Should "git log --decorate" indicate whether the HEAD is detached? Julien Cretel
2015-02-16 23:15 ` Junio C Hamano
2015-02-16 23:40   ` Julien Cretel
2015-02-18 10:15     ` Michael J Gruber
2015-02-18 13:19       ` [RFC/PATCH] log: decorate detached HEAD differently Michael J Gruber
2015-02-18 17:07       ` Should "git log --decorate" indicate whether the HEAD is detached? Junio C Hamano
2015-02-18 19:45         ` Michael J Gruber
2015-02-18 19:49           ` Junio C Hamano
2015-02-19  9:52             ` Michael J Gruber
2015-02-19 11:13         ` Julien Cretel
2015-02-20  8:13           ` Junio C Hamano
2015-03-06 16:15             ` [PATCH] log: decorate detached HEAD differently Michael J Gruber
2015-03-06 16:20               ` Michael J Gruber
2015-03-06 19:03               ` Junio C Hamano
2015-03-09  9:16                 ` Michael J Gruber
2015-03-10  2:03                   ` Junio C Hamano
2015-03-10 10:34                     ` Michael J Gruber
2015-03-10 13:53                       ` [PATCHv2 0/2] log decorations for HEAD Michael J Gruber
2015-03-10 13:53                         ` [PATCHv2 1/2] log-tree: properly reset colors Michael J Gruber
2015-03-10 13:53                         ` [PATCHv2 2/2] log: decorate HEAD with branch name Michael J Gruber
2015-03-10 17:06                         ` [PATCHv2 0/2] log decorations for HEAD Junio C Hamano
2015-03-11  8:02                           ` Michael J Gruber [this message]
2015-03-23 10:36                         ` Julien Cretel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54FFF69E.3090104@drmicha.warpmail.net \
    --to=git@drmicha.warpmail.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=j.cretel@umail.ucc.ie \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).