From: Michael J Gruber <git@drmicha.warpmail.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Julien Cretel <j.cretel@umail.ucc.ie>
Subject: Re: [PATCH] log: decorate detached HEAD differently
Date: Tue, 10 Mar 2015 11:34:56 +0100 [thread overview]
Message-ID: <54FEC8D0.2060304@drmicha.warpmail.net> (raw)
In-Reply-To: <xmqqh9tt623d.fsf@gitster.dls.corp.google.com>
Junio C Hamano venit, vidit, dixit 10.03.2015 03:03:
> Michael J Gruber <git@drmicha.warpmail.net> writes:
>
>> Junio C Hamano venit, vidit, dixit 06.03.2015 20:03:
>>> Michael J Gruber <git@drmicha.warpmail.net> writes:
>>>>
>>>> Note that now a checked branch is listed twice, once as target of the
>>>> HEAD, once as branch: They are two different refs and colored differently.
>>>
>>> The pointee of HEAD would always be branch and will always appear on
>>> the output when you show HEAD->$name_of_that_branch; is it feasible
>>> to drop the duplicate, I wonder?
>>
>> It's doable but not nice, because we cannot take the order in which refs
>> are processed for granted.
>
> That is true, but when we format them into a single line in the
> header in response to --decorate (or %d), don't we have all of them
> already at hand---does the order still matter?
>
> Here is an illustration of what I had in mind, made on a random
> commit I happened to have checked out that does not have your
> patches on this topic. Half of the change is a new helper function,
> and the other half is mostly reindenting.
Yes, the patch illustrates pretty well what I meant by "doable but not
nice" :)
But I also said:
> Also, HEAD and foo are two different refs, so even if HEAD has the value
> "foo", I think we should really show them both anyways.
>
> Alternatively, we could decorate by (HEAD, *foo, master, tag: release)
> if foo is checked out, just like branch does.
I guess I will have to apply your patch and feel what it's like in
practical use in order to change my mind...
Michael
next prev parent reply other threads:[~2015-03-10 10:35 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-16 22:42 Should "git log --decorate" indicate whether the HEAD is detached? Julien Cretel
2015-02-16 23:15 ` Junio C Hamano
2015-02-16 23:40 ` Julien Cretel
2015-02-18 10:15 ` Michael J Gruber
2015-02-18 13:19 ` [RFC/PATCH] log: decorate detached HEAD differently Michael J Gruber
2015-02-18 17:07 ` Should "git log --decorate" indicate whether the HEAD is detached? Junio C Hamano
2015-02-18 19:45 ` Michael J Gruber
2015-02-18 19:49 ` Junio C Hamano
2015-02-19 9:52 ` Michael J Gruber
2015-02-19 11:13 ` Julien Cretel
2015-02-20 8:13 ` Junio C Hamano
2015-03-06 16:15 ` [PATCH] log: decorate detached HEAD differently Michael J Gruber
2015-03-06 16:20 ` Michael J Gruber
2015-03-06 19:03 ` Junio C Hamano
2015-03-09 9:16 ` Michael J Gruber
2015-03-10 2:03 ` Junio C Hamano
2015-03-10 10:34 ` Michael J Gruber [this message]
2015-03-10 13:53 ` [PATCHv2 0/2] log decorations for HEAD Michael J Gruber
2015-03-10 13:53 ` [PATCHv2 1/2] log-tree: properly reset colors Michael J Gruber
2015-03-10 13:53 ` [PATCHv2 2/2] log: decorate HEAD with branch name Michael J Gruber
2015-03-10 17:06 ` [PATCHv2 0/2] log decorations for HEAD Junio C Hamano
2015-03-11 8:02 ` Michael J Gruber
2015-03-23 10:36 ` Julien Cretel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54FEC8D0.2060304@drmicha.warpmail.net \
--to=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.cretel@umail.ucc.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).