git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "René Scharfe" <l.s.r@web.de>
To: David Aguilar <davvid@gmail.com>, git@vger.kernel.org
Subject: Re: [RFC PATCH 2/2] headers: include dependent headers
Date: Sat, 06 Sep 2014 23:20:35 +0200	[thread overview]
Message-ID: <540B7AA3.1090201@web.de> (raw)
In-Reply-To: <1410031211-14599-2-git-send-email-davvid@gmail.com>

Am 06.09.2014 um 21:20 schrieb David Aguilar:
> Add dependent headers so that including a header does not
> require including additional headers.
>
> This makes it so that "gcc -c $header" succeeds for each header.
>
> Signed-off-by: David Aguilar <davvid@gmail.com>
> ---

> diff --git a/branch.h b/branch.h
> index 64173ab..a61fd1a 100644
> --- a/branch.h
> +++ b/branch.h
> @@ -3,6 +3,9 @@
>
>   /* Functions for acting on the information about branches. */
>
> +#include "cache.h"
> +#include "strbuf.h"

cache.h includes strbuf.h, so the line above isn't necessary.

  reply	other threads:[~2014-09-06 21:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-06 19:20 [RFC PATCH 1/2] Makefile: add check-headers target David Aguilar
2014-09-06 19:20 ` [RFC PATCH 2/2] headers: include dependent headers David Aguilar
2014-09-06 21:20   ` René Scharfe [this message]
2014-09-08 17:50     ` Junio C Hamano
2014-09-09 19:44       ` René Scharfe
2014-09-08 18:05     ` Junio C Hamano
2014-09-06 21:20 ` [RFC PATCH 1/2] Makefile: add check-headers target René Scharfe
2014-09-06 22:57   ` David Aguilar
2014-09-06 23:58     ` Jeff King
2014-09-07  0:24       ` David Aguilar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=540B7AA3.1090201@web.de \
    --to=l.s.r@web.de \
    --cc=davvid@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).