From: Jeff King <peff@peff.net>
To: David Aguilar <davvid@gmail.com>
Cc: "René Scharfe" <l.s.r@web.de>, git@vger.kernel.org
Subject: Re: [RFC PATCH 1/2] Makefile: add check-headers target
Date: Sat, 6 Sep 2014 19:58:09 -0400 [thread overview]
Message-ID: <20140906235808.GA20625@peff.net> (raw)
In-Reply-To: <20140906225738.GA15039@gmail.com>
On Sat, Sep 06, 2014 at 03:57:39PM -0700, David Aguilar wrote:
> > This checks all .h files in the top directory. Would it be better
> > to check all files in LIB_H instead? Or even all .h files in the
> > tree (using "git ls-files '*.h'")? The latter might be difficult
> > because some of the files in compat/ #include system-specific
> > headers.
>
> Ah, I hadn't thought of using LIB_H; that might be the most
> practical solution.
Maybe not; see d85b0dff7297fb43a57a0c1e697417bb7723247c, which is in
'next'.
-Peff
next prev parent reply other threads:[~2014-09-06 23:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-06 19:20 [RFC PATCH 1/2] Makefile: add check-headers target David Aguilar
2014-09-06 19:20 ` [RFC PATCH 2/2] headers: include dependent headers David Aguilar
2014-09-06 21:20 ` René Scharfe
2014-09-08 17:50 ` Junio C Hamano
2014-09-09 19:44 ` René Scharfe
2014-09-08 18:05 ` Junio C Hamano
2014-09-06 21:20 ` [RFC PATCH 1/2] Makefile: add check-headers target René Scharfe
2014-09-06 22:57 ` David Aguilar
2014-09-06 23:58 ` Jeff King [this message]
2014-09-07 0:24 ` David Aguilar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140906235808.GA20625@peff.net \
--to=peff@peff.net \
--cc=davvid@gmail.com \
--cc=git@vger.kernel.org \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).