From: Ben Peart <peartben@gmail.com>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: Ben.Peart@microsoft.com, git@vger.kernel.org, gitster@pobox.com,
peff@peff.net, Elijah Newren <newren@gmail.com>
Subject: Re: [PATCH v4 1/5] trace.h: support nested performance tracing
Date: Mon, 13 Aug 2018 14:39:16 -0400 [thread overview]
Message-ID: <5361e977-c476-0efe-5a2a-7d377dd51bbe@gmail.com> (raw)
In-Reply-To: <20180812081551.27927-2-pclouds@gmail.com>
On 8/12/2018 4:15 AM, Nguyễn Thái Ngọc Duy wrote:
> Performance measurements are listed right now as a flat list, which is
> fine when we measure big blocks. But when we start adding more and
> more measurements, some of them could be just part of a bigger
> measurement and a flat list gives a wrong impression that they are
> executed at the same level instead of nested.
>
> Add trace_performance_enter() and trace_performance_leave() to allow
> indent these nested measurements. For now it does not help much
> because the only nested thing is (lazy) name hash initialization
> (e.g. called in diff-index from "git status"). This will help more
> because I'm going to add some more tracing that's actually nested.
>
I reviewed this and it looks reasonable to me.
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> ---
> diff-lib.c | 4 +--
> dir.c | 4 +--
> name-hash.c | 4 +--
> preload-index.c | 4 +--
> read-cache.c | 11 ++++----
> trace.c | 69 ++++++++++++++++++++++++++++++++++++++++++++-----
> trace.h | 15 +++++++++++
> 7 files changed, 92 insertions(+), 19 deletions(-)
>
> diff --git a/diff-lib.c b/diff-lib.c
> index a9f38eb5a3..1ffa22c882 100644
> --- a/diff-lib.c
> +++ b/diff-lib.c
> @@ -518,8 +518,8 @@ static int diff_cache(struct rev_info *revs,
> int run_diff_index(struct rev_info *revs, int cached)
> {
> struct object_array_entry *ent;
> - uint64_t start = getnanotime();
>
> + trace_performance_enter();
> ent = revs->pending.objects;
> if (diff_cache(revs, &ent->item->oid, ent->name, cached))
> exit(128);
> @@ -528,7 +528,7 @@ int run_diff_index(struct rev_info *revs, int cached)
> diffcore_fix_diff_index(&revs->diffopt);
> diffcore_std(&revs->diffopt);
> diff_flush(&revs->diffopt);
> - trace_performance_since(start, "diff-index");
> + trace_performance_leave("diff-index");
> return 0;
> }
>
> diff --git a/dir.c b/dir.c
> index 21e6f2520a..c5e9fc8cea 100644
> --- a/dir.c
> +++ b/dir.c
> @@ -2263,11 +2263,11 @@ int read_directory(struct dir_struct *dir, struct index_state *istate,
> const char *path, int len, const struct pathspec *pathspec)
> {
> struct untracked_cache_dir *untracked;
> - uint64_t start = getnanotime();
>
I think removing the cost of has_symlink_leading_path() from this perf
trace is probably OK to simplify the enter/leave logic.
> if (has_symlink_leading_path(path, len))
> return dir->nr;
>
> + trace_performance_enter();
> untracked = validate_untracked_cache(dir, len, pathspec);
> if (!untracked)
> /*
> @@ -2302,7 +2302,7 @@ int read_directory(struct dir_struct *dir, struct index_state *istate,
> dir->nr = i;
> }
>
> - trace_performance_since(start, "read directory %.*s", len, path);
> + trace_performance_leave("read directory %.*s", len, path);
> if (dir->untracked) {
> static int force_untracked_cache = -1;
> static struct trace_key trace_untracked_stats = TRACE_KEY_INIT(UNTRACKED_STATS);
> diff --git a/name-hash.c b/name-hash.c
> index 163849831c..1fcda73cb3 100644
> --- a/name-hash.c
> +++ b/name-hash.c
> @@ -578,10 +578,10 @@ static void threaded_lazy_init_name_hash(
>
> static void lazy_init_name_hash(struct index_state *istate)
> {
> - uint64_t start = getnanotime();
>
> if (istate->name_hash_initialized)
> return;
> + trace_performance_enter();
> hashmap_init(&istate->name_hash, cache_entry_cmp, NULL, istate->cache_nr);
> hashmap_init(&istate->dir_hash, dir_entry_cmp, NULL, istate->cache_nr);
>
> @@ -602,7 +602,7 @@ static void lazy_init_name_hash(struct index_state *istate)
> }
>
> istate->name_hash_initialized = 1;
> - trace_performance_since(start, "initialize name hash");
> + trace_performance_leave("initialize name hash");
> }
>
> /*
> diff --git a/preload-index.c b/preload-index.c
> index 4d08d44874..d7f7919ba2 100644
> --- a/preload-index.c
> +++ b/preload-index.c
> @@ -78,7 +78,6 @@ static void preload_index(struct index_state *index,
> {
> int threads, i, work, offset;
> struct thread_data data[MAX_PARALLEL];
> - uint64_t start = getnanotime();
>
> if (!core_preload_index)
> return;
> @@ -88,6 +87,7 @@ static void preload_index(struct index_state *index,
> threads = 2;
> if (threads < 2)
> return;
> + trace_performance_enter();
> if (threads > MAX_PARALLEL)
> threads = MAX_PARALLEL;
> offset = 0;
> @@ -109,7 +109,7 @@ static void preload_index(struct index_state *index,
> if (pthread_join(p->pthread, NULL))
> die("unable to join threaded lstat");
> }
> - trace_performance_since(start, "preload index");
> + trace_performance_leave("preload index");
> }
> #endif
>
> diff --git a/read-cache.c b/read-cache.c
> index e865254bea..4fd35f4f37 100644
> --- a/read-cache.c
> +++ b/read-cache.c
> @@ -1399,8 +1399,8 @@ int refresh_index(struct index_state *istate, unsigned int flags,
> const char *typechange_fmt;
> const char *added_fmt;
> const char *unmerged_fmt;
> - uint64_t start = getnanotime();
>
> + trace_performance_enter();
> modified_fmt = (in_porcelain ? "M\t%s\n" : "%s: needs update\n");
> deleted_fmt = (in_porcelain ? "D\t%s\n" : "%s: needs update\n");
> typechange_fmt = (in_porcelain ? "T\t%s\n" : "%s needs update\n");
> @@ -1470,7 +1470,7 @@ int refresh_index(struct index_state *istate, unsigned int flags,
>
> replace_index_entry(istate, i, new_entry);
> }
> - trace_performance_since(start, "refresh index");
> + trace_performance_leave("refresh index");
> return has_errors;
> }
>
> @@ -1901,7 +1901,6 @@ static void freshen_shared_index(const char *shared_index, int warn)
> int read_index_from(struct index_state *istate, const char *path,
> const char *gitdir)
> {
> - uint64_t start = getnanotime();
> struct split_index *split_index;
> int ret;
> char *base_oid_hex;
> @@ -1911,8 +1910,9 @@ int read_index_from(struct index_state *istate, const char *path,
> if (istate->initialized)
> return istate->cache_nr;
>
> + trace_performance_enter();
> ret = do_read_index(istate, path, 0);
> - trace_performance_since(start, "read cache %s", path);
> + trace_performance_leave("read cache %s", path);
>
> split_index = istate->split_index;
> if (!split_index || is_null_oid(&split_index->base_oid)) {
> @@ -1920,6 +1920,7 @@ int read_index_from(struct index_state *istate, const char *path,
> return ret;
> }
>
This one is kind of odd how it's splitting up the index read from the
split index but it's no more odd than it was before.
> + trace_performance_enter();
> if (split_index->base)
> discard_index(split_index->base);
> else
> @@ -1936,8 +1937,8 @@ int read_index_from(struct index_state *istate, const char *path,
> freshen_shared_index(base_path, 0);
> merge_base_index(istate);
> post_read_index_from(istate);
> - trace_performance_since(start, "read cache %s", base_path);
> free(base_path);
> + trace_performance_leave("read cache %s", base_path);
> return ret;
> }
>
> diff --git a/trace.c b/trace.c
> index fc623e91fd..fa4a2e7120 100644
> --- a/trace.c
> +++ b/trace.c
> @@ -176,10 +176,30 @@ void trace_strbuf_fl(const char *file, int line, struct trace_key *key,
> strbuf_release(&buf);
> }
>
> +static uint64_t perf_start_times[10];
> +static int perf_indent;
> +
> +uint64_t trace_performance_enter(void)
> +{
> + uint64_t now;
> +
> + if (!trace_want(&trace_perf_key))
> + return 0;
> +
> + now = getnanotime();
> + perf_start_times[perf_indent] = now;
> + if (perf_indent + 1 < ARRAY_SIZE(perf_start_times))
> + perf_indent++;
> + else
> + BUG("Too deep indentation");
> + return now;
> +}
> +
> static void trace_performance_vprintf_fl(const char *file, int line,
> uint64_t nanos, const char *format,
> va_list ap)
> {
> + static const char space[] = " ";
> struct strbuf buf = STRBUF_INIT;
>
> if (!prepare_trace_line(file, line, &trace_perf_key, &buf))
> @@ -188,7 +208,10 @@ static void trace_performance_vprintf_fl(const char *file, int line,
> strbuf_addf(&buf, "performance: %.9f s", (double) nanos / 1000000000);
>
> if (format && *format) {
> - strbuf_addstr(&buf, ": ");
> + if (perf_indent >= strlen(space))
> + BUG("Too deep indentation");
> +
> + strbuf_addf(&buf, ":%.*s ", perf_indent, space);
> strbuf_vaddf(&buf, format, ap);
> }
>
> @@ -244,6 +267,24 @@ void trace_performance_since(uint64_t start, const char *format, ...)
> va_end(ap);
> }
>
> +void trace_performance_leave(const char *format, ...)
> +{
> + va_list ap;
> + uint64_t since;
> +
> + if (perf_indent)
> + perf_indent--;
> +
> + if (!format) /* Allow callers to leave without tracing anything */
> + return;
> +
> + since = perf_start_times[perf_indent];
> + va_start(ap, format);
> + trace_performance_vprintf_fl(NULL, 0, getnanotime() - since,
> + format, ap);
> + va_end(ap);
> +}
> +
> #else
>
> void trace_printf_key_fl(const char *file, int line, struct trace_key *key,
> @@ -273,6 +314,24 @@ void trace_performance_fl(const char *file, int line, uint64_t nanos,
> va_end(ap);
> }
>
> +void trace_performance_leave_fl(const char *file, int line,
> + uint64_t nanos, const char *format, ...)
> +{
> + va_list ap;
> + uint64_t since;
> +
> + if (perf_indent)
> + perf_indent--;
> +
> + if (!format) /* Allow callers to leave without tracing anything */
> + return;
> +
> + since = perf_start_times[perf_indent];
> + va_start(ap, format);
> + trace_performance_vprintf_fl(file, line, nanos - since, format, ap);
> + va_end(ap);
> +}
> +
> #endif /* HAVE_VARIADIC_MACROS */
>
>
> @@ -411,13 +470,11 @@ uint64_t getnanotime(void)
> }
> }
>
> -static uint64_t command_start_time;
> static struct strbuf command_line = STRBUF_INIT;
>
> static void print_command_performance_atexit(void)
> {
> - trace_performance_since(command_start_time, "git command:%s",
> - command_line.buf);
> + trace_performance_leave("git command:%s", command_line.buf);
> }
>
> void trace_command_performance(const char **argv)
> @@ -425,10 +482,10 @@ void trace_command_performance(const char **argv)
> if (!trace_want(&trace_perf_key))
> return;
>
> - if (!command_start_time)
> + if (!command_line.len)
> atexit(print_command_performance_atexit);
>
> strbuf_reset(&command_line);
> sq_quote_argv_pretty(&command_line, argv);
> - command_start_time = getnanotime();
> + trace_performance_enter();
> }
> diff --git a/trace.h b/trace.h
> index 2b6a1bc17c..171b256d26 100644
> --- a/trace.h
> +++ b/trace.h
> @@ -23,6 +23,7 @@ extern void trace_disable(struct trace_key *key);
> extern uint64_t getnanotime(void);
> extern void trace_command_performance(const char **argv);
> extern void trace_verbatim(struct trace_key *key, const void *buf, unsigned len);
> +uint64_t trace_performance_enter(void);
>
> #ifndef HAVE_VARIADIC_MACROS
>
> @@ -45,6 +46,9 @@ extern void trace_performance(uint64_t nanos, const char *format, ...);
> __attribute__((format (printf, 2, 3)))
> extern void trace_performance_since(uint64_t start, const char *format, ...);
>
> +__attribute__((format (printf, 1, 2)))
> +void trace_performance_leave(const char *format, ...);
> +
> #else
>
> /*
> @@ -118,6 +122,14 @@ extern void trace_performance_since(uint64_t start, const char *format, ...);
> __VA_ARGS__); \
> } while (0)
>
> +#define trace_performance_leave(...) \
> + do { \
> + if (trace_pass_fl(&trace_perf_key)) \
> + trace_performance_leave_fl(TRACE_CONTEXT, __LINE__, \
> + getnanotime(), \
> + __VA_ARGS__); \
> + } while (0)
> +
> /* backend functions, use non-*fl macros instead */
> __attribute__((format (printf, 4, 5)))
> extern void trace_printf_key_fl(const char *file, int line, struct trace_key *key,
> @@ -130,6 +142,9 @@ extern void trace_strbuf_fl(const char *file, int line, struct trace_key *key,
> __attribute__((format (printf, 4, 5)))
> extern void trace_performance_fl(const char *file, int line,
> uint64_t nanos, const char *fmt, ...);
> +__attribute__((format (printf, 4, 5)))
> +extern void trace_performance_leave_fl(const char *file, int line,
> + uint64_t nanos, const char *fmt, ...);
> static inline int trace_pass_fl(struct trace_key *key)
> {
> return key->fd || !key->initialized;
>
next prev parent reply other threads:[~2018-08-13 18:39 UTC|newest]
Thread overview: 121+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-18 20:45 [PATCH v1 0/3] [RFC] Speeding up checkout (and merge, rebase, etc) Ben Peart
2018-07-18 20:45 ` [PATCH v1 1/3] add unbounded Multi-Producer-Multi-Consumer queue Ben Peart
2018-07-18 20:57 ` Stefan Beller
2018-07-19 19:11 ` Junio C Hamano
2018-07-18 20:45 ` [PATCH v1 2/3] add performance tracing around traverse_trees() in unpack_trees() Ben Peart
2018-07-18 20:45 ` [PATCH v1 3/3] Add initial parallel version of unpack_trees() Ben Peart
2018-07-18 22:56 ` Junio C Hamano
2018-07-18 21:02 ` [PATCH v1 0/3] [RFC] Speeding up checkout (and merge, rebase, etc) Stefan Beller
2018-07-18 21:34 ` Jeff King
2018-07-23 15:48 ` Ben Peart
2018-07-23 17:03 ` Duy Nguyen
2018-07-23 20:51 ` Ben Peart
2018-07-24 4:20 ` Jeff King
2018-07-24 15:33 ` Duy Nguyen
2018-07-25 20:56 ` Ben Peart
2018-07-26 5:30 ` Duy Nguyen
2018-07-26 16:30 ` Duy Nguyen
2018-07-26 19:40 ` Junio C Hamano
2018-07-27 15:42 ` Duy Nguyen
2018-07-27 16:22 ` Ben Peart
2018-07-27 18:00 ` Duy Nguyen
2018-07-27 17:14 ` Junio C Hamano
2018-07-27 17:52 ` Duy Nguyen
2018-07-29 6:24 ` Duy Nguyen
2018-07-29 10:33 ` [PATCH v2 0/4] Speed up unpack_trees() Nguyễn Thái Ngọc Duy
2018-07-29 10:33 ` [PATCH v2 1/4] unpack-trees.c: add performance tracing Nguyễn Thái Ngọc Duy
2018-07-30 20:16 ` Ben Peart
2018-07-29 10:33 ` [PATCH v2 2/4] unpack-trees: optimize walking same trees with cache-tree Nguyễn Thái Ngọc Duy
2018-07-30 20:52 ` Ben Peart
2018-07-29 10:33 ` [PATCH v2 3/4] unpack-trees: reduce malloc in cache-tree walk Nguyễn Thái Ngọc Duy
2018-07-30 20:58 ` Ben Peart
2018-07-29 10:33 ` [PATCH v2 4/4] unpack-trees: cheaper index update when walking by cache-tree Nguyễn Thái Ngọc Duy
2018-08-08 18:46 ` Elijah Newren
2018-08-10 16:39 ` Duy Nguyen
2018-08-10 18:39 ` Elijah Newren
2018-08-10 19:30 ` Duy Nguyen
2018-08-10 19:40 ` Elijah Newren
2018-08-10 19:48 ` Duy Nguyen
2018-07-30 18:10 ` [PATCH v2 0/4] Speed up unpack_trees() Ben Peart
2018-07-31 15:31 ` Duy Nguyen
2018-07-31 16:50 ` Ben Peart
2018-07-31 17:31 ` Ben Peart
2018-08-01 16:38 ` Duy Nguyen
2018-08-08 20:53 ` Ben Peart
2018-08-09 8:16 ` Ben Peart
2018-08-10 16:08 ` Duy Nguyen
2018-08-10 15:51 ` Duy Nguyen
2018-07-30 21:04 ` Ben Peart
2018-08-04 5:37 ` [PATCH v3 " Nguyễn Thái Ngọc Duy
2018-08-04 5:37 ` [PATCH v3 1/4] unpack-trees: add performance tracing Nguyễn Thái Ngọc Duy
2018-08-04 5:37 ` [PATCH v3 2/4] unpack-trees: optimize walking same trees with cache-tree Nguyễn Thái Ngọc Duy
2018-08-08 18:23 ` Elijah Newren
2018-08-10 16:29 ` Duy Nguyen
2018-08-10 18:48 ` Elijah Newren
2018-08-04 5:37 ` [PATCH v3 3/4] unpack-trees: reduce malloc in cache-tree walk Nguyễn Thái Ngọc Duy
2018-08-08 18:30 ` Elijah Newren
2018-08-04 5:37 ` [PATCH v3 4/4] unpack-trees: cheaper index update when walking by cache-tree Nguyễn Thái Ngọc Duy
2018-08-06 15:48 ` [PATCH v3 0/4] Speed up unpack_trees() Junio C Hamano
2018-08-06 15:59 ` Duy Nguyen
2018-08-06 18:59 ` Junio C Hamano
2018-08-08 17:00 ` Ben Peart
2018-08-08 17:46 ` Junio C Hamano
2018-08-08 18:12 ` Junio C Hamano
2018-08-08 18:39 ` Junio C Hamano
2018-08-10 16:53 ` Duy Nguyen
2018-08-12 8:15 ` [PATCH v4 0/5] " Nguyễn Thái Ngọc Duy
2018-08-12 8:15 ` [PATCH v4 1/5] trace.h: support nested performance tracing Nguyễn Thái Ngọc Duy
2018-08-13 18:39 ` Ben Peart [this message]
2018-08-12 8:15 ` [PATCH v4 2/5] unpack-trees: add " Nguyễn Thái Ngọc Duy
2018-08-12 10:05 ` Thomas Adam
2018-08-13 18:50 ` Junio C Hamano
2018-08-13 18:44 ` Ben Peart
2018-08-13 19:25 ` Jeff King
2018-08-13 19:36 ` Stefan Beller
2018-08-13 20:11 ` Ben Peart
2018-08-13 19:52 ` Duy Nguyen
2018-08-13 21:47 ` Jeff King
2018-08-13 22:41 ` Junio C Hamano
2018-08-14 18:19 ` Jeff Hostetler
2018-08-14 18:32 ` Duy Nguyen
2018-08-14 18:44 ` Stefan Beller
2018-08-14 18:51 ` Duy Nguyen
2018-08-14 19:54 ` Jeff King
2018-08-14 20:52 ` Junio C Hamano
2018-08-15 16:32 ` Duy Nguyen
2018-08-15 18:28 ` Junio C Hamano
2018-08-14 20:14 ` Jeff Hostetler
2018-08-12 8:15 ` [PATCH v4 3/5] unpack-trees: optimize walking same trees with cache-tree Nguyễn Thái Ngọc Duy
2018-08-13 18:58 ` Ben Peart
2018-08-15 16:38 ` Duy Nguyen
2018-08-12 8:15 ` [PATCH v4 4/5] unpack-trees: reduce malloc in cache-tree walk Nguyễn Thái Ngọc Duy
2018-08-12 8:15 ` [PATCH v4 5/5] unpack-trees: reuse (still valid) cache-tree from src_index Nguyễn Thái Ngọc Duy
2018-08-13 15:48 ` Elijah Newren
2018-08-13 15:57 ` Duy Nguyen
2018-08-13 16:05 ` Ben Peart
2018-08-13 16:25 ` Duy Nguyen
2018-08-13 17:15 ` Ben Peart
2018-08-13 19:01 ` [PATCH v4 0/5] Speed up unpack_trees() Junio C Hamano
2018-08-14 19:19 ` Ben Peart
2018-08-18 14:41 ` [PATCH v5 0/7] " Nguyễn Thái Ngọc Duy
2018-08-18 14:41 ` [PATCH v5 1/7] trace.h: support nested performance tracing Nguyễn Thái Ngọc Duy
2018-08-18 14:41 ` [PATCH v5 2/7] unpack-trees: add " Nguyễn Thái Ngọc Duy
2018-08-18 14:41 ` [PATCH v5 3/7] unpack-trees: optimize walking same trees with cache-tree Nguyễn Thái Ngọc Duy
2018-08-20 12:43 ` Ben Peart
2018-08-18 14:41 ` [PATCH v5 4/7] unpack-trees: reduce malloc in cache-tree walk Nguyễn Thái Ngọc Duy
2018-08-18 14:41 ` [PATCH v5 5/7] unpack-trees: reuse (still valid) cache-tree from src_index Nguyễn Thái Ngọc Duy
2018-08-18 14:41 ` [PATCH v5 6/7] unpack-trees: add missing cache invalidation Nguyễn Thái Ngọc Duy
2018-08-18 14:41 ` [PATCH v5 7/7] cache-tree: verify valid cache-tree in the test suite Nguyễn Thái Ngọc Duy
2018-08-18 21:45 ` Elijah Newren
2018-08-18 22:01 ` [PATCH v5 0/7] Speed up unpack_trees() Elijah Newren
2018-08-19 5:09 ` Duy Nguyen
2018-08-25 12:18 ` [PATCH] Document update for nd/unpack-trees-with-cache-tree Nguyễn Thái Ngọc Duy
2018-08-25 12:31 ` Martin Ågren
2018-08-25 13:02 ` [PATCH v2] " Nguyễn Thái Ngọc Duy
2018-07-27 15:50 ` [PATCH v1 0/3] [RFC] Speeding up checkout (and merge, rebase, etc) Ben Peart
2018-07-26 16:35 ` Duy Nguyen
2018-07-24 5:54 ` Junio C Hamano
2018-07-24 15:13 ` Duy Nguyen
2018-07-24 21:21 ` Jeff King
2018-07-25 16:09 ` Ben Peart
2018-07-24 4:27 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5361e977-c476-0efe-5a2a-7d377dd51bbe@gmail.com \
--to=peartben@gmail.com \
--cc=Ben.Peart@microsoft.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=newren@gmail.com \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).