From: Ben Peart <peartben@gmail.com>
To: Tatsuyuki Ishi <ishitatsuyuki@gmail.com>, git@vger.kernel.org
Subject: Re: core.fsmonitor always perform rescans
Date: Tue, 10 Apr 2018 10:34:05 -0400 [thread overview]
Message-ID: <53251802-5c5e-6fd2-25d0-40d534e6bd6f@gmail.com> (raw)
In-Reply-To: <CANqewP332-+esYWDPBtPif==wnb4PiNd89R1qTZsuWZAFSV0ew@mail.gmail.com>
On 3/26/2018 12:41 AM, Tatsuyuki Ishi wrote:
> Hello,
>
> I'm facing issue with core.fsmonitor.
>
> I'm currently using the provided watchman hook, but it doesn't seem to
> record the fact that it has queried the fsmonitor backend, and as a
> result the timestamp passed to the hook doesn't seem to change.
>
> As it always pass a timestamp before watchman has crawled the
> directories, watchman will always return all files inside the
> directory. This happens everytime I run a git command, resulting in
> slowness.
>
> Is the timestamp not being updated an intended behavior, or is this a bug?
>
As a performance optimization, the fsmonitor code doesn't flag the index
as dirty and force it to be written out with every command. Can you try
performing a git operation (add, rm, commit, etc) that will write out an
updated index and see if that fixes the issue you're seeing?
I'm considering adding a special case to force the index to be written
out the first time fsmonitor is invoked and am interested to know if
this would have avoided the issue you are seeing.
Thanks!
> Tatsuyuki Ishi
>
next prev parent reply other threads:[~2018-04-10 14:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-26 4:41 core.fsmonitor always perform rescans Tatsuyuki Ishi
2018-03-30 10:28 ` Johannes Schindelin
2018-04-10 14:34 ` Ben Peart [this message]
2018-04-11 8:18 ` Tatsuyuki Ishi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53251802-5c5e-6fd2-25d0-40d534e6bd6f@gmail.com \
--to=peartben@gmail.com \
--cc=git@vger.kernel.org \
--cc=ishitatsuyuki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).