git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Tatsuyuki Ishi <ishitatsuyuki@gmail.com>
To: Ben Peart <peartben@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: core.fsmonitor always perform rescans
Date: Wed, 11 Apr 2018 17:18:15 +0900	[thread overview]
Message-ID: <CANqewP1W2dPotMFhWRLRkjteUpmH9z0fRWCQG_h5bF95EAy60w@mail.gmail.com> (raw)
In-Reply-To: <53251802-5c5e-6fd2-25d0-40d534e6bd6f@gmail.com>

2018-04-10 23:34 GMT+09:00 Ben Peart <peartben@gmail.com>:
> As a performance optimization, the fsmonitor code doesn't flag the index as
> dirty and force it to be written out with every command.  Can you try
> performing a git operation (add, rm, commit, etc) that will write out an
> updated index and see if that fixes the issue you're seeing?

Yeah, that resolves the issue. Though the repo I'm working on uses
submodules, so doing this in each of them isn't a easy work.

> I'm considering adding a special case to force the index to be written out
> the first time fsmonitor is invoked and am interested to know if this would
> have avoided the issue you are seeing.

Yes please. And maybe we should also flush the index when the script
returns '/',
which means all files?

      reply	other threads:[~2018-04-11  8:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-26  4:41 core.fsmonitor always perform rescans Tatsuyuki Ishi
2018-03-30 10:28 ` Johannes Schindelin
2018-04-10 14:34 ` Ben Peart
2018-04-11  8:18   ` Tatsuyuki Ishi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANqewP1W2dPotMFhWRLRkjteUpmH9z0fRWCQG_h5bF95EAy60w@mail.gmail.com \
    --to=ishitatsuyuki@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=peartben@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).