From: Stefan Beller <stefanbeller@googlemail.com>
To: Junio C Hamano <gitster@pobox.com>,
GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH 1/3] treewalk.c: Rename variable ret to cb_bits and remove some dead lines.
Date: Fri, 19 Jul 2013 22:25:52 +0200 [thread overview]
Message-ID: <51E9A0D0.3090701@googlemail.com> (raw)
In-Reply-To: <7vli52wh8n.fsf@alter.siamese.dyndns.org>
On 07/19/2013 08:13 PM, Junio C Hamano wrote:
> The "ret" was meant to mean "the return value we got from the
> callback function", not "the return value we would give our caller".
Thanks for clarifying.
I assumed the "ret" was meant as the return value of that function
as it was the case before e6c111b4c. In other projects I am using
ret as "the return value we would give our caller" as it's such a
convenient name for that if you cannot come up with a better name.
>
> This rename is a bit misleading in that "cb_bits == -1" does not
> mean "full bits set", and it does not tell us much what these "bits"
> signify.
>
> They are used to answer this question: which one of the trees in
> t[0..n] did the callback function consumed (hence needs their
> pointers updated).
>
> So perhaps call it "trees_used" or something?
Sounds indeed way better. I'll rename it.
>
> By the way, our log message usually do not Capitalize the subject
> after the "<area>:", i.e. do something like this instead:
>
> Subject: [PATCH 1/3] traverse_trees(): clarify return value of the callback
>
> Thanks.
>
Thanks for pointing out.
As a general question: I was mostly doing micro-optimisations or
the mailmap file, which are rather small fixups, which I think are
ok for beginners. Is there a tasklist for beginners, other than that?
Such as porting shell commands to C or other larger tasks?
I used git://github.com/gitster/git.git as remote/origin. There the todo
branch has the last commit as of 2012/04, so I also found
git://git.kernel.org/pub/scm/git/git.git, where the todo branch seems
more up-to-date, but the TODO file there also seems a little dated to
me.
So is there any up-to-date task list for beginning contributors?
Stefan
next prev parent reply other threads:[~2013-07-19 20:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-18 21:35 [PATCH 1/3] treewalk.c: Rename variable ret to cb_bits and remove some dead lines Stefan Beller
2013-07-18 21:35 ` [PATCH 2/3] http-push.c, add_send_request: Do not initialize transfer_request Stefan Beller
2013-07-19 18:30 ` Junio C Hamano
2013-07-18 21:35 ` [PATCH 3/3] apply, find_name_traditional: Do not initialize len to the lines length Stefan Beller
2013-07-19 18:13 ` [PATCH 1/3] treewalk.c: Rename variable ret to cb_bits and remove some dead lines Junio C Hamano
2013-07-19 20:25 ` Stefan Beller [this message]
2013-07-19 20:26 ` [PATCH] traverse_trees(): clarify return value of the callback Stefan Beller
2013-07-19 22:28 ` [PATCH 1/3] treewalk.c: Rename variable ret to cb_bits and remove some dead lines Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E9A0D0.3090701@googlemail.com \
--to=stefanbeller@googlemail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).