From: Stefan Beller <stefanbeller@googlemail.com>
To: gitster@pobox.com, git@vger.kernel.org
Cc: Stefan Beller <stefanbeller@googlemail.com>
Subject: [PATCH 2/3] http-push.c, add_send_request: Do not initialize transfer_request.
Date: Thu, 18 Jul 2013 23:35:26 +0200 [thread overview]
Message-ID: <1374183327-14939-2-git-send-email-stefanbeller@googlemail.com> (raw)
In-Reply-To: <1374183327-14939-1-git-send-email-stefanbeller@googlemail.com>
That pointer will be assigned to new memory via
request = xmalloc(sizeof(*request));
20 lines later unconditionally anyway, so it's safe to not assign it to an
arbitrary variable.
As this patch is a micro-optimization (for readability?) it would be nice
to have as little work with this patch, so maybe I need a feature to send
a patch without a symmetric number of lines around change-diff. For this
patch I'd be only interested in showing the next 20 lines, but nothing
really before the function declaration.
Signed-off-by: Stefan Beller <stefanbeller@googlemail.com>
---
http-push.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/http-push.c b/http-push.c
index 395a8cf..6dad188 100644
--- a/http-push.c
+++ b/http-push.c
@@ -663,7 +663,7 @@ static void add_fetch_request(struct object *obj)
static int add_send_request(struct object *obj, struct remote_lock *lock)
{
- struct transfer_request *request = request_queue_head;
+ struct transfer_request *request;
struct packed_git *target;
/* Keep locks active */
--
1.8.3.3.754.g9c3c367.dirty
next prev parent reply other threads:[~2013-07-18 21:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-18 21:35 [PATCH 1/3] treewalk.c: Rename variable ret to cb_bits and remove some dead lines Stefan Beller
2013-07-18 21:35 ` Stefan Beller [this message]
2013-07-19 18:30 ` [PATCH 2/3] http-push.c, add_send_request: Do not initialize transfer_request Junio C Hamano
2013-07-18 21:35 ` [PATCH 3/3] apply, find_name_traditional: Do not initialize len to the lines length Stefan Beller
2013-07-19 18:13 ` [PATCH 1/3] treewalk.c: Rename variable ret to cb_bits and remove some dead lines Junio C Hamano
2013-07-19 20:25 ` Stefan Beller
2013-07-19 20:26 ` [PATCH] traverse_trees(): clarify return value of the callback Stefan Beller
2013-07-19 22:28 ` [PATCH 1/3] treewalk.c: Rename variable ret to cb_bits and remove some dead lines Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1374183327-14939-2-git-send-email-stefanbeller@googlemail.com \
--to=stefanbeller@googlemail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).