From: "Torsten Bögershausen" <tboegi@web.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Torsten Bögershausen" <tboegi@web.de>,
"Jeff King" <peff@peff.net>,
git@vger.kernel.org
Subject: Re: t1450-fsck (sometimes/often) failes on Mac OS X
Date: Tue, 02 Oct 2012 18:06:35 +0200 [thread overview]
Message-ID: <506B110B.2050802@web.de> (raw)
In-Reply-To: <7va9wlhnl3.fsf@alter.siamese.dyndns.org>
On 09/19/2012 08:30 PM, Junio C Hamano wrote:
> Torsten Bögershausen <tboegi@web.de> writes:
>
> "is a blob, not a commit" is likely to come from validating of the
> tag 66f6581d that presumably point at 63499e4; it reads the tag,
> learns the name of the object that is tagged and the type of it,
> remembers that the object pointed at (which it hasn't and is going
> to validate next) _must_ be a commit (because tag says so) and then
> realizes when it reads 63499e4 it is a blob and barfs.
>
> And that is what _should_ happen in that test. It crafts a
> malformed tag that points at a blob and claims that it is a commit.
> The test makes sure fsck catches that, and it does.
>
> On the other hand, "is a commit, not a blob", unless you have a tag
> that directly points at a blob, is more likely to come from
> validating some tree object. It reads the tree, learns the name of
> the object contained in the tree and infers the type of that object
> from the mode bits in the tree (100644 or 100755 would mean the
> object must be a blob), goes on to validate that object and realizes
> it is a commit and barfs.
>
The good news:
With help of Junio's comments I probably found the reason why the test
behaves differently:
The objects are checked in a certain order, based on the inode number.
Which seems to be the same on most machines: when files are created
in a certain order, then the inode numbers are in the same order.
When the inode numbering changes for reasons known to the file system,
the order changes and fsck takes a different code path.
To provoke the error, the following helped at my Linux box:
diff --git a/builtin/fsck.c b/builtin/fsck.c
index a710227..bba8082 100644
--- a/builtin/fsck.c
+++ b/builtin/fsck.c
@@ -373,7 +373,7 @@ static struct {
static int ino_compare(const void *_a, const void *_b)
{
- const struct sha1_entry *a = _a, *b = _b;
+ const struct sha1_entry *a = _b, *b = _a;
unsigned long ino1 = a->ino, ino2 = b->ino;
return ino1 < ino2 ? -1 : ino1 > ino2 ? 1 : 0;
}
The bad news: I haven't found the time to prepare a fix.
/Torsten
next prev parent reply other threads:[~2012-10-02 16:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-14 12:21 t1450-fsck (sometimes/often) failes on Mac OS X Torsten Bögershausen
2012-07-15 9:08 ` Jeff King
2012-07-15 13:03 ` Torsten Bögershausen
2012-09-19 16:04 ` Torsten Bögershausen
2012-09-19 18:30 ` Junio C Hamano
2012-09-19 20:23 ` Torsten Bögershausen
2012-10-02 16:06 ` Torsten Bögershausen [this message]
2012-10-02 21:01 ` Junio C Hamano
2012-10-02 22:21 ` Junio C Hamano
2012-10-03 19:37 ` Torsten Bögershausen
2012-07-16 7:57 ` Thomas Rast
2012-07-16 16:06 ` Torsten Bögershausen
2012-07-28 15:43 ` Heiko Voigt
2012-07-28 16:00 ` Thomas Rast
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=506B110B.2050802@web.de \
--to=tboegi@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).