From: Michael J Gruber <git@drmicha.warpmail.net>
To: "Junio C Hamano" <gitster@pobox.com>,
"Torsten Bögershausen" <tboegi@web.de>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCHv2 5/5] t3910: use the UTF8_NFD_TO_NFC test prereq
Date: Mon, 06 Aug 2012 14:44:26 +0200 [thread overview]
Message-ID: <501FBC2A.1070403@drmicha.warpmail.net> (raw)
In-Reply-To: <7vboiq9uv7.fsf@alter.siamese.dyndns.org>
Junio C Hamano venit, vidit, dixit 05.08.2012 00:04:
> Torsten Bögershausen <tboegi@web.de> writes:
>
>> Am 2012-07-30 11:57, schrieb Michael J Gruber:
>> (Sorry being late)
>>
>> That line:
>>> skip_all="filesystem does not convert utf-8 nfd to nfc"
>>
>> shouldn't it be the other way around?
>> skip_all="filesystem does not convert utf-8 nfc to nfd"
>>
>> (and may be the following may be more easy to read:)
>> skip_all="filesystem does not decompose unicode"
>>
>>
>> Side note: t0050 uses another term:
>> "will test on a unicode corrupting filesystem"
>
> I am OK with either of the last two. Thanks for noticing.
I had taken the test description from t3910. But that referred to Git's
undoing of the conversion done by the filesystem...
It's best to have it analogous to t0050 as in Junio's fixup.
Thanks!
Michael
[resent with cc: list...]
prev parent reply other threads:[~2012-08-06 12:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-14 17:52 [PATCH] t3910: give reason for skipping the test Michael J Gruber
2012-07-14 18:19 ` Torsten Bögershausen
2012-07-26 13:39 ` [PATCH 0/5] test-lib: filesystem prerequisites Michael J Gruber
2012-07-26 13:39 ` [PATCH 1/5] test-lib: provide case insensitivity as a prerequisite Michael J Gruber
2012-07-26 13:39 ` [PATCH 2/5] t0050: use the CASE_INSENSITIVE_FS test prereq Michael J Gruber
2012-07-26 13:39 ` [PATCH 3/5] t0050: use the SYMLINKS " Michael J Gruber
2012-07-26 13:39 ` [PATCH 4/5] test-lib: provide UTF8 behaviour as a prerequisite Michael J Gruber
2012-07-26 13:39 ` [PATCH 5/5] t3910: use the SYMLINKS test prereq Michael J Gruber
2012-07-26 18:16 ` [PATCH 0/5] test-lib: filesystem prerequisites Junio C Hamano
2012-07-26 18:43 ` Jeff King
2012-07-26 20:10 ` Junio C Hamano
2012-07-27 9:31 ` Michael J Gruber
2012-07-27 17:29 ` Junio C Hamano
2012-07-30 9:56 ` Michael J Gruber
2012-07-30 9:57 ` [PATCHv2 5/5] t3910: use the UTF8_NFD_TO_NFC test prereq Michael J Gruber
2012-07-30 15:29 ` Junio C Hamano
2012-08-04 5:37 ` Torsten Bögershausen
2012-08-04 22:04 ` Junio C Hamano
2012-08-06 12:44 ` Michael J Gruber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=501FBC2A.1070403@drmicha.warpmail.net \
--to=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).