From: "Torsten Bögershausen" <tboegi@web.de>
To: Michael J Gruber <git@drmicha.warpmail.net>
Cc: git@vger.kernel.org, "Torsten Bögershausen" <tboegi@web.de>
Subject: Re: [PATCH] t3910: give reason for skipping the test
Date: Sat, 14 Jul 2012 20:19:23 +0200 [thread overview]
Message-ID: <5001B82B.1060201@web.de> (raw)
In-Reply-To: <71c43b6e469c916f6c41026ad6ed25c1094018be.1342287902.git.git@drmicha.warpmail.net>
On 14.07.12 19:52, Michael J Gruber wrote:
> t3910 is skipped for most users because it requires a filesystem which
> does automatic conversion between different utf-8 types. Currently, this
> results in a skipped test with "no reason given".
>
> Use the skip_all mechanism from our test suite so that a reason for
> skipping the test is given to the user.
>
> Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net>
> ---
> Alternatively, we could set a prerequisite and mark all tests with that. Since
> it's either or for the whole test skip_all seems more appropriate. In that
> case, we can also flatten the else branch, of course. The current patch is
> minimally invasive, though.
Good point, thanks.
If we spin that idea further,
we could move the whole t3910 into t0050.
That would be nice for all non Mac OS X users in a way that we save CPU time.
We already detect unicode corruption in t0050.
next prev parent reply other threads:[~2012-07-14 18:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-14 17:52 [PATCH] t3910: give reason for skipping the test Michael J Gruber
2012-07-14 18:19 ` Torsten Bögershausen [this message]
2012-07-26 13:39 ` [PATCH 0/5] test-lib: filesystem prerequisites Michael J Gruber
2012-07-26 13:39 ` [PATCH 1/5] test-lib: provide case insensitivity as a prerequisite Michael J Gruber
2012-07-26 13:39 ` [PATCH 2/5] t0050: use the CASE_INSENSITIVE_FS test prereq Michael J Gruber
2012-07-26 13:39 ` [PATCH 3/5] t0050: use the SYMLINKS " Michael J Gruber
2012-07-26 13:39 ` [PATCH 4/5] test-lib: provide UTF8 behaviour as a prerequisite Michael J Gruber
2012-07-26 13:39 ` [PATCH 5/5] t3910: use the SYMLINKS test prereq Michael J Gruber
2012-07-26 18:16 ` [PATCH 0/5] test-lib: filesystem prerequisites Junio C Hamano
2012-07-26 18:43 ` Jeff King
2012-07-26 20:10 ` Junio C Hamano
2012-07-27 9:31 ` Michael J Gruber
2012-07-27 17:29 ` Junio C Hamano
2012-07-30 9:56 ` Michael J Gruber
2012-07-30 9:57 ` [PATCHv2 5/5] t3910: use the UTF8_NFD_TO_NFC test prereq Michael J Gruber
2012-07-30 15:29 ` Junio C Hamano
2012-08-04 5:37 ` Torsten Bögershausen
2012-08-04 22:04 ` Junio C Hamano
2012-08-06 12:44 ` Michael J Gruber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5001B82B.1060201@web.de \
--to=tboegi@web.de \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).