From: Olliver Schinagl <oliver@schinagl.nl>
To: Junio C Hamano <gitster@pobox.com>,
Stefan Haller <lists@haller-berlin.de>
Cc: git@vger.kernel.org
Subject: Re: Allow git bisect to auto-skip
Date: Sat, 23 Mar 2024 21:51:28 +0100 [thread overview]
Message-ID: <4cf100aa-4239-4377-b20a-7c90443fb405@schinagl.nl> (raw)
In-Reply-To: <xmqqle68x008.fsf@gitster.g>
On 23-03-2024 19:43, Junio C Hamano wrote:
> Stefan Haller <lists@haller-berlin.de> writes:
>
>> On 22.03.24 23:31, Junio C Hamano wrote:
>>> It often is discovered that a commit
>>> breaks bisection after the fact and it is not feasible to rebase
>>> all the history after the commit.
>>
>> This reminds me of a similar problem with git blame, for which we have
>> the blame.ignoreRevsFile config to work around it. Couldn't there be a
>> similar mechanism for bisect, e.g. bisect.skipRevsFile?
>
> A Very good point. If a breakage of a commit is "this does not even
> build" kind of breakage, such a mechanism would be an excellent fit.
>
> But if a breakage is "only this particular test fails and we know
> the reason why it fails has nothing to do with the bug we are
> chasing", then compiling such a fixed list of commits, or pointing
> at such a list with a configuration variable, would not work very
> well, I am afraid.
This changes my view of the issue a little bit. Building vs testing,
though in reality its the same of course.
I can totally see that a user would need a special bisect script to
handle these cases 'this commit breaks test 54, 43 and 12; but the rest
work'. This is too specific to handle generically. Probably in using a
similar trick, store in the notes what works and does not work.
I think it still stands that having a 'generic' way of telling bisect to
skip the entire commit is still reasonable. Kind of like how you can do
`git push -o ci.skip=true` with GitLab.
Olliver
>
> Thanks.
next prev parent reply other threads:[~2024-03-23 20:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 22:18 Allow git bisect to auto-skip Olliver Schinagl
2024-03-22 22:31 ` Junio C Hamano
2024-03-23 1:59 ` Olliver Schinagl
2024-03-23 13:51 ` Stefan Haller
2024-03-23 18:43 ` Junio C Hamano
2024-03-23 20:51 ` Olliver Schinagl [this message]
2024-03-24 7:47 ` Olliver Schinagl
2024-03-24 10:16 ` Stefan Haller
2024-03-24 14:29 ` Christian Couder
2024-03-24 16:04 ` rsbecker
2024-03-24 18:34 ` Junio C Hamano
2024-03-27 18:33 ` Olliver Schinagl
2024-03-27 19:24 ` Junio C Hamano
2024-03-28 8:01 ` Olliver Schinagl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4cf100aa-4239-4377-b20a-7c90443fb405@schinagl.nl \
--to=oliver@schinagl.nl \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=lists@haller-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).