git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Julien ÉLIE" <julien@trigofacile.com>
To: Michael Platings <michael@platin.gs>
Cc: Barret Rhoden <brho@google.com>, git@vger.kernel.org
Subject: Re: Ignored commits appearing in git blame
Date: Tue, 10 Jan 2023 22:09:32 +0100	[thread overview]
Message-ID: <4c2d2581-5f69-6e42-73e8-9c64d9bad4bc@trigofacile.com> (raw)
In-Reply-To: <CAJDYR9RnWuO66i9aLdACox+GRSpidyWyZkS_2hHWH=1v2cfbtA@mail.gmail.com>

Hi Michael,

Thanks for having taken time to respond!

> You're right, ideally 36944f2b16 should have disappeared from the
> output at line 5. The way the ignoring algorithm works is that it
> tries to find a line in the previous commit with similar content.
> Since there's so little content to compare I guess the algorithm plays
> it safe and gives up.

OK, I understand.


> On the one hand this is annoying because an
> empty line or single curly brace should be trivial for the algorithm
> to deal with. On the other hand "which change caused this empty line
> to be here?" is not a very interesting question so hopefully won't be
> too much of a problem for you in practice.

I agree.


> There are a couple of
> annoyances with the feature I'd like to fix (the main being that
> there's no way to enable it globally) and I'll add this to the list.
> However I'm unlikely to get to it soon. I won't complain if you beat
> me to fixing it :)

Thanks for having considered the bug report.
In case it helps, I've noticed that if I add the "-w" flag (to ignore 
whitespace in comparisons), the git blame output no longer shows that 
revision which was asked to be ignored.

   git blame -w --ignore-revs-file .git-blame-ignore-revs radius.c

I don't know whether it is a coincidence (especially when 
.git-blame-ignore-revs contains in fact commits of code reformatting and 
whitespace cleaning) or it would also help for other kind of commits to 
ignore.

-- 
Julien ÉLIE

« Le bonheur, c'est de continuer à désirer ce que l'on possède. »
   (Saint-Augustin)

      reply	other threads:[~2023-01-10 21:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-08  9:27 Ignored commits appearing in git blame Julien ÉLIE
2023-01-09  4:35 ` Junio C Hamano
2023-01-09 13:26   ` Michael Platings
2023-01-10 21:09     ` Julien ÉLIE [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4c2d2581-5f69-6e42-73e8-9c64d9bad4bc@trigofacile.com \
    --to=julien@trigofacile.com \
    --cc=brho@google.com \
    --cc=git@vger.kernel.org \
    --cc=michael@platin.gs \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).