From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id EDDD21F47C for ; Tue, 10 Jan 2023 21:10:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233741AbjAJVJn (ORCPT ); Tue, 10 Jan 2023 16:09:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233452AbjAJVJl (ORCPT ); Tue, 10 Jan 2023 16:09:41 -0500 Received: from denver.dinauz.org (denver.dinauz.org [37.59.56.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 90D245F4BB for ; Tue, 10 Jan 2023 13:09:36 -0800 (PST) Received: from localhost (localhost.localdomain [127.0.0.1]) by denver.dinauz.org (Postfix) with ESMTP id 3CF5A60581; Tue, 10 Jan 2023 22:09:33 +0100 (CET) Received: from denver.dinauz.org ([127.0.0.1]) by localhost (denver.dinauz.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id f9DsjTkocjah; Tue, 10 Jan 2023 22:09:33 +0100 (CET) Received: from [192.168.1.6] (176-143-2-105.abo.bbox.fr [176.143.2.105]) by denver.dinauz.org (Postfix) with ESMTPSA id 0E8FC6047E; Tue, 10 Jan 2023 22:09:33 +0100 (CET) Message-ID: <4c2d2581-5f69-6e42-73e8-9c64d9bad4bc@trigofacile.com> Date: Tue, 10 Jan 2023 22:09:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: Ignored commits appearing in git blame To: Michael Platings Cc: Barret Rhoden , git@vger.kernel.org References: From: =?UTF-8?Q?Julien_=c3=89LIE?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Hi Michael, Thanks for having taken time to respond! > You're right, ideally 36944f2b16 should have disappeared from the > output at line 5. The way the ignoring algorithm works is that it > tries to find a line in the previous commit with similar content. > Since there's so little content to compare I guess the algorithm plays > it safe and gives up. OK, I understand. > On the one hand this is annoying because an > empty line or single curly brace should be trivial for the algorithm > to deal with. On the other hand "which change caused this empty line > to be here?" is not a very interesting question so hopefully won't be > too much of a problem for you in practice. I agree. > There are a couple of > annoyances with the feature I'd like to fix (the main being that > there's no way to enable it globally) and I'll add this to the list. > However I'm unlikely to get to it soon. I won't complain if you beat > me to fixing it :) Thanks for having considered the bug report. In case it helps, I've noticed that if I add the "-w" flag (to ignore whitespace in comparisons), the git blame output no longer shows that revision which was asked to be ignored. git blame -w --ignore-revs-file .git-blame-ignore-revs radius.c I don't know whether it is a coincidence (especially when .git-blame-ignore-revs contains in fact commits of code reformatting and whitespace cleaning) or it would also help for other kind of commits to ignore. -- Julien ÉLIE « Le bonheur, c'est de continuer à désirer ce que l'on possède. » (Saint-Augustin)