From: Johannes Sixt <j.sixt@viscovery.net>
To: Libor Pechacek <lpechacek@suse.cz>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2] Disallow empty section and variable names
Date: Mon, 31 Jan 2011 10:29:45 +0100 [thread overview]
Message-ID: <4D468109.8020409@viscovery.net> (raw)
In-Reply-To: <20110131091728.GB24297@fm.suse.cz>
Am 1/31/2011 10:17, schrieb Libor Pechacek:
> On Mon 31-01-11 08:48:31, Johannes Sixt wrote:
>> Am 1/30/2011 21:34, schrieb Libor Pechacek:
>>> + test_must_fail git config . &&
>>> + test_must_fail git config .foo &&
>>> + test_must_fail git config foo. &&
>>> + test_must_fail git config .foo. &&
>>
>> Not a nit: These tests only show that 'git config' cannot be asked for
>> junk, but they do not show that you cannot insert junk into the config
>> file anymore using 'git config'.
>
> This change builds on top of "Sanity-check config variable names" which makes
> setting and getting values use the same key checking routine. For the moment,
> it does not matter if we test the "set" ot "get" path.
The purpose of tests is not to check the implementation, but the
observable behavior. Therefore, you want to write a test case to make sure
that neither usage is broken by future changes.
-- Hannes
next prev parent reply other threads:[~2011-01-31 9:29 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-08 14:46 git-config does not check validity of variable names Libor Pechacek
2011-01-11 5:59 ` Jeff King
2011-01-19 10:01 ` Libor Pechacek
2011-01-19 14:11 ` [PATCH] Sanity-ckeck config " Libor Pechacek
2011-01-20 23:22 ` Jeff King
2011-01-21 0:06 ` Jeff King
2011-01-19 14:14 ` [PATCH] Documentation fixes in git-config Libor Pechacek
2011-01-21 0:27 ` Jeff King
2011-01-21 10:20 ` Libor Pechacek
2011-01-21 10:25 ` [PATCH v2] " Libor Pechacek
2011-01-21 16:25 ` Jeff King
2011-01-23 19:46 ` Libor Pechacek
2012-03-01 8:19 ` [PATCH v3] " Libor Pechacek
2012-03-01 9:08 ` Jeff King
2012-03-01 10:54 ` Libor Pechacek
2012-03-01 16:24 ` Junio C Hamano
2012-03-01 10:59 ` [PATCH v4] " Libor Pechacek
2011-01-21 10:02 ` [PATCH] Sanity-ckeck config variable names Libor Pechacek
2011-01-21 10:23 ` [PATCH v2] " Libor Pechacek
2011-01-21 16:23 ` Jeff King
2011-01-27 14:28 ` [PATCH v3] Sanity-check " Libor Pechacek
2011-01-27 22:45 ` Junio C Hamano
2011-01-28 14:53 ` Libor Pechacek
2011-01-30 19:40 ` [PATCH v4] " Libor Pechacek
2011-02-10 22:49 ` Junio C Hamano
2011-02-11 18:52 ` Libor Pechacek
2011-01-27 14:52 ` [PATCH] Disallow empty section and " Libor Pechacek
2011-01-30 20:34 ` [PATCH v2] " Libor Pechacek
2011-01-31 7:48 ` Johannes Sixt
2011-01-31 9:17 ` Libor Pechacek
2011-01-31 9:29 ` Johannes Sixt [this message]
2011-01-31 13:08 ` [PATCH v3] " Libor Pechacek
2011-01-31 16:48 ` Jens Lehmann
2011-02-01 7:13 ` [PATCH v4] " Libor Pechacek
2011-02-10 22:49 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D468109.8020409@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=git@vger.kernel.org \
--cc=lpechacek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).