From: Libor Pechacek <lpechacek@suse.cz>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Sanity-ckeck config variable names
Date: Fri, 21 Jan 2011 11:02:12 +0100 [thread overview]
Message-ID: <20110121100212.GE19715@fm.suse.cz> (raw)
In-Reply-To: <20110121000629.GA7773@sigill.intra.peff.net> <20110120232232.GA9442@sigill.intra.peff.net>
On Thu 20-01-11 18:22:32, Jeff King wrote:
> > + * Returns 0 on success, 1 when there is an invalid character in the key and 2
> > + * if there is no section name in the key.
>
> Please switch these to -1 and -2, as we generally use negative integers
> to indicate errors in library-ish function.
Done.
> Other than that, the code looks OK to me. However, it does cause
> t1300.85 to fail.
Thanks for catching it, added your changes to the patch and tested. I didn't
notice the test suite. :)
On Thu 20-01-11 19:06:29, Jeff King wrote:
> Doesn't this hunk:
>
> > @@ -168,10 +167,6 @@ static int get_value(const char *key_, const char *regex_)
> > }
> >
> > key = xstrdup(key_);
> > - for (tl=key+strlen(key)-1; tl >= key && *tl != '.'; --tl)
> > - *tl = tolower(*tl);
> > - for (tl=key; *tl && *tl != '.'; ++tl)
> > - *tl = tolower(*tl);
>
> Mean that regexp keys no longer get downcased properly? I.e.,
>
> git config Foo.value true
> git config --get-regexp 'foo.*'
> git config --get-regexp 'Foo.*'
>
> used to work for both lookups, but now fails for the second one?
After thinking about it I added the code back. More on it in the
"documentation fix" thread.
Thanks for your kind guidance.
Libor
--
Libor Pechacek
SUSE L3 Team, Prague
next prev parent reply other threads:[~2011-01-21 10:02 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-08 14:46 git-config does not check validity of variable names Libor Pechacek
2011-01-11 5:59 ` Jeff King
2011-01-19 10:01 ` Libor Pechacek
2011-01-19 14:11 ` [PATCH] Sanity-ckeck config " Libor Pechacek
2011-01-20 23:22 ` Jeff King
2011-01-21 0:06 ` Jeff King
2011-01-19 14:14 ` [PATCH] Documentation fixes in git-config Libor Pechacek
2011-01-21 0:27 ` Jeff King
2011-01-21 10:20 ` Libor Pechacek
2011-01-21 10:25 ` [PATCH v2] " Libor Pechacek
2011-01-21 16:25 ` Jeff King
2011-01-23 19:46 ` Libor Pechacek
2012-03-01 8:19 ` [PATCH v3] " Libor Pechacek
2012-03-01 9:08 ` Jeff King
2012-03-01 10:54 ` Libor Pechacek
2012-03-01 16:24 ` Junio C Hamano
2012-03-01 10:59 ` [PATCH v4] " Libor Pechacek
2011-01-21 10:02 ` Libor Pechacek [this message]
2011-01-21 10:23 ` [PATCH v2] Sanity-ckeck config variable names Libor Pechacek
2011-01-21 16:23 ` Jeff King
2011-01-27 14:28 ` [PATCH v3] Sanity-check " Libor Pechacek
2011-01-27 22:45 ` Junio C Hamano
2011-01-28 14:53 ` Libor Pechacek
2011-01-30 19:40 ` [PATCH v4] " Libor Pechacek
2011-02-10 22:49 ` Junio C Hamano
2011-02-11 18:52 ` Libor Pechacek
2011-01-27 14:52 ` [PATCH] Disallow empty section and " Libor Pechacek
2011-01-30 20:34 ` [PATCH v2] " Libor Pechacek
2011-01-31 7:48 ` Johannes Sixt
2011-01-31 9:17 ` Libor Pechacek
2011-01-31 9:29 ` Johannes Sixt
2011-01-31 13:08 ` [PATCH v3] " Libor Pechacek
2011-01-31 16:48 ` Jens Lehmann
2011-02-01 7:13 ` [PATCH v4] " Libor Pechacek
2011-02-10 22:49 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110121100212.GE19715@fm.suse.cz \
--to=lpechacek@suse.cz \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).