From: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>
To: unlisted-recipients:; (no To-header on input)
Cc: Junio C Hamano <gitster@pobox.com>,
Francis Moreau <francis.moro@gmail.com>,
git@vger.kernel.org, Johannes Sixt <j6t@kdbg.org>
Subject: Re: Can't find the revelant commit with git-log
Date: Sat, 29 Jan 2011 21:26:16 +0100 [thread overview]
Message-ID: <4D4477E8.8030703@lsrfire.ath.cx> (raw)
In-Reply-To: <4D437CA0.1070006@lsrfire.ath.cx>
Am 29.01.2011 03:34, schrieb René Scharfe:
> Am 29.01.2011 01:02, schrieb Junio C Hamano:
>> Let's look at the original code before your patch again.
>>
>> 1. If all the parents of a commit are the same, we will see (tree_same &&
>> !tree_changed), so we get TREESAME.
>>
>> 2. If some but not all of the parents are the same, we will see (tree_same
>> && tree_changed), and we end up getting TREESAME.
>>
>> 3. If none of the parents is the same, (!tree_same && tree_changed) holds
>> true, and we do not get TREESAME.
>
> For completeness, a fourth case (!tree_same && !tree_changed), which
> would be triggered by commits whose parents are all classified as
> REV_TREE_NEW. That's another corner case for sure, but the old code
> would mark it TREESAME and your patch changes that.
Ugh, forget this part, I failed to notice the /* fallthrough */ at the
end of the REV_TREE_NEW case..
René
next prev parent reply other threads:[~2011-01-29 20:26 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-25 9:01 Can't find the revelant commit with git-log Francis Moreau
2011-01-25 16:12 ` René Scharfe
2011-01-25 17:44 ` Francis Moreau
2011-01-26 8:36 ` Francis Moreau
2011-01-26 10:44 ` Johannes Sixt
2011-01-26 20:56 ` Francis Moreau
2011-01-26 21:03 ` Sverre Rabbelier
2011-01-26 21:08 ` Francis Moreau
2011-01-26 21:14 ` Sverre Rabbelier
2011-01-26 21:31 ` Francis Moreau
2011-01-26 21:24 ` Junio C Hamano
2011-01-26 21:32 ` Francis Moreau
2011-01-26 18:11 ` René Scharfe
2011-01-28 20:29 ` René Scharfe
2011-01-29 0:02 ` Junio C Hamano
2011-01-29 2:34 ` René Scharfe
2011-01-29 5:47 ` Junio C Hamano
2011-01-29 20:26 ` René Scharfe
2011-02-01 21:28 ` Junio C Hamano
2011-02-07 22:51 ` Junio C Hamano
2011-02-10 18:50 ` René Scharfe
2011-01-29 20:26 ` René Scharfe [this message]
2011-01-28 22:01 ` René Scharfe
2011-01-29 12:52 ` Francis Moreau
2011-01-29 13:02 ` René Scharfe
2011-01-29 13:57 ` Francis Moreau
2011-01-29 15:17 ` René Scharfe
2011-01-26 9:01 ` Francis Moreau
2011-01-26 18:39 ` René Scharfe
2011-01-26 19:50 ` Francis Moreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D4477E8.8030703@lsrfire.ath.cx \
--to=rene.scharfe@lsrfire.ath.cx \
--cc=francis.moro@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).