git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Mathias Lafeldt <misfire@debugon.org>
To: Will Palmer <wmpalmer@gmail.com>
Cc: git <git@vger.kernel.org>, Eric Wong <normalperson@yhbt.net>
Subject: Re: [BUG] git-svn parses --pretty=medium log output, fails when log.decorate is true
Date: Tue, 05 Oct 2010 13:48:35 +0200	[thread overview]
Message-ID: <4CAB1093.7000204@debugon.org> (raw)
In-Reply-To: <1286273926.2364.6.camel@wpalmer.simply-domain>

Will Palmer wrote:
> I started receiving this error during "git svn dcommit" today:
> 
> Use of uninitialized value $hash in string eq
> at /home/wpalmer/libexec/git-core/git-svn line 1534.
> 
> Examining that section reveals that git-svn is running 
> "git log --no-color --first-parent --pretty=medium"
> 
> and parsing the output in order to find commit hashes and git-svn-id:
> lines. This breaks when log.decorate is true.
> 
> This could be patched-up by adding "--no-decorate" to the options
> git-svn passes, but that seems to me like it would just be adding to the
> pile, as "--pretty=medium" is a moving target. I assume the correct
> solution is to specify the format exactly as it is expected.

I recently submitted a patch adding --no-decorate:
http://article.gmane.org/gmane.comp.version-control.git/156919

And it's already in Eric's git-svn branch:
git://git.bogomips.org/git-svn

-Mathias

  reply	other threads:[~2010-10-05 11:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-05 10:18 [BUG] git-svn parses --pretty=medium log output, fails when log.decorate is true Will Palmer
2010-10-05 11:48 ` Mathias Lafeldt [this message]
2010-10-05 16:58 ` Jeff King
2010-10-05 17:53   ` Mathias Lafeldt
2010-10-05 18:02     ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CAB1093.7000204@debugon.org \
    --to=misfire@debugon.org \
    --cc=git@vger.kernel.org \
    --cc=normalperson@yhbt.net \
    --cc=wmpalmer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).