From: Jeff King <peff@peff.net>
To: Mathias Lafeldt <misfire@debugon.org>
Cc: Will Palmer <wmpalmer@gmail.com>,
Eric Wong <normalperson@yhbt.net>, git <git@vger.kernel.org>
Subject: Re: [BUG] git-svn parses --pretty=medium log output, fails when log.decorate is true
Date: Tue, 5 Oct 2010 14:02:14 -0400 [thread overview]
Message-ID: <20101005180214.GA12861@sigill.intra.peff.net> (raw)
In-Reply-To: <4CAB6620.4000909@debugon.org>
On Tue, Oct 05, 2010 at 07:53:36PM +0200, Mathias Lafeldt wrote:
> > --- a/git-svn.perl
> > +++ b/git-svn.perl
> > @@ -1514,7 +1514,7 @@ sub cmt_sha2rev_batch {
> >
> > sub working_head_info {
> > my ($head, $refs) = @_;
> > - my @args = ('log', '--no-color', '--first-parent', '--pretty=medium');
> > + my @args = ('rev-list', '--first-parent', '--pretty=medium');
> > my ($fh, $ctx) = command_output_pipe(@args, $head);
> > my $hash;
> > my %max;
>
> You're right. Using rev-list looks like a much cleaner solution.
>
> In addition, I think we can replace the call to git-log in git_svn_log_cmd() too.
I don't think so. It uses diff options like "--raw --name-status" which
rev-list does not support. I think it is not buggy, though, as it uses
--format=raw.
-Peff
prev parent reply other threads:[~2010-10-05 18:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-05 10:18 [BUG] git-svn parses --pretty=medium log output, fails when log.decorate is true Will Palmer
2010-10-05 11:48 ` Mathias Lafeldt
2010-10-05 16:58 ` Jeff King
2010-10-05 17:53 ` Mathias Lafeldt
2010-10-05 18:02 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101005180214.GA12861@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=misfire@debugon.org \
--cc=normalperson@yhbt.net \
--cc=wmpalmer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).