* [PATCH] git-gui: fix use of undeclared variable diff_empty_count
@ 2009-04-06 19:59 Joerg Bornemann
2009-04-07 8:07 ` Joerg Bornemann
0 siblings, 1 reply; 2+ messages in thread
From: Joerg Bornemann @ 2009-04-06 19:59 UTC (permalink / raw)
To: git
Commit 584fa9cc introduced the global variable diff_empty_count, which
is used in diff.tcl. This variable wasn't declared anywhere which
resulted in an ugly error message box instead of the intended
informative message.
Signed-off-by: Joerg Bornemann <joerg.bornemann@web.de>
---
git-gui.sh | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/git-gui.sh b/git-gui.sh
index e4a9230..46b056f 100755
--- a/git-gui.sh
+++ b/git-gui.sh
@@ -1131,6 +1131,7 @@ set current_diff_path {}
set is_3way_diff 0
set is_conflict_diff 0
set selected_commit_type new
+set diff_empty_count 0
set nullid "0000000000000000000000000000000000000000"
set nullid2 "0000000000000000000000000000000000000001"
--
1.6.0.2.1172.ga5ed0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] git-gui: fix use of undeclared variable diff_empty_count
2009-04-06 19:59 [PATCH] git-gui: fix use of undeclared variable diff_empty_count Joerg Bornemann
@ 2009-04-07 8:07 ` Joerg Bornemann
0 siblings, 0 replies; 2+ messages in thread
From: Joerg Bornemann @ 2009-04-07 8:07 UTC (permalink / raw)
To: git
This bug occurs with msysgit under mysterious circumstances. We have at
least two Windows machines where "git diff" works correctly but "git
gui" is unable to get the actual diffs. Before commit 584fa9cc, git gui
favoured the user with an infinite message box loop. This is what
584fa9cc should've fixed: display a nice message to the user. Instead I
see the Tcl error message box, complaining about the missing variable
diff_empty_count.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-04-07 8:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-04-06 19:59 [PATCH] git-gui: fix use of undeclared variable diff_empty_count Joerg Bornemann
2009-04-07 8:07 ` Joerg Bornemann
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).