From: Andreas Ericsson <exon@op5.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Heiko Voigt <hvoigt@hvoigt.net>, Jeff King <peff@peff.net>,
git@vger.kernel.org
Subject: Re: [PATCH v2] Add configuration variable for sign-off to format-patch
Date: Mon, 06 Apr 2009 12:58:08 +0200 [thread overview]
Message-ID: <49D9E040.40007@op5.se> (raw)
In-Reply-To: <7veiw69p26.fsf@gitster.siamese.dyndns.org>
Junio C Hamano wrote:
> Heiko Voigt <hvoigt@hvoigt.net> writes:
>
>> diff --git a/Documentation/config.txt b/Documentation/config.txt
>> index ad22cb8..27cb7f1 100644
>> --- a/Documentation/config.txt
>> +++ b/Documentation/config.txt
>> @@ -715,6 +715,13 @@ format.thread::
>> A true boolean value is the same as `shallow`, and a false
>> value disables threading.
>>
>> +format.signoff::
>> + A boolean value which lets you enable the `-s/--signoff` option of
>> + format-patch by default. *Note:* Adding the Signed-off-by: line to a
>> + patch should be a conscious act and means that you certify you have
>> + the rights to submit this work under the same open source license.
>> + Please see the 'SubmittingPatches' document for further discussion.
>
> I have a mixed feeling about this description. The existing description
> on the --signoff option merely talks about what it does, leaving what it
> means, and it is quite deliberate. If your project uses S-o-b, it may be
> useful. If yours doesn't, you simply just don't use it. It does not
> matter to _us_ as the document writer what that line means to your
> project.
>
> We do want to make the reader think twice iff S-o-b is used in the
> reader's project with the same meaning as it means in git and the Linux
> kernel project, which is what the description you added is about. But
> should we just assume if anybody uses S-o-b convention in their project
> they must give it the same meaning as we give it?
>
> The patch looks straightforward enough, and the wording we can update if
> somebody can come up with a better one, so I'll apply the patch to
> 'master' and we will go from there.
>
How about:
"Some projects (notably the Linux kernel and git itself) put special
meaning in a 'Signed-off-by' line while other's dont. Please refer
to your project's documentation for appropriate behaviour."
Optionally with the following amendment:
"In general, you should refrain from signing off on a patch containing
material that you're not sure can be legally spread under the project's
license."
I'll whip up a patch if someone cares enough about it to say "+1" to
either proposal, or make a better one.
--
Andreas Ericsson andreas.ericsson@op5.se
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231
Considering the successes of the wars on alcohol, poverty, drugs and
terror, I think we should give some serious thought to declaring war
on peace.
next prev parent reply other threads:[~2009-04-06 10:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-31 18:50 [PATCH] Add configuration variable for sign-off to format-patch Heiko Voigt
2009-03-31 19:47 ` Andreas Ericsson
2009-04-01 17:53 ` Heiko Voigt
2009-03-31 20:04 ` Jeff King
2009-03-31 20:43 ` Heiko Voigt
2009-04-01 10:26 ` Jeff King
2009-04-01 17:51 ` [PATCH v2] " Heiko Voigt
2009-04-01 17:55 ` Sverre Rabbelier
2009-04-06 8:14 ` Junio C Hamano
2009-04-06 10:58 ` Andreas Ericsson [this message]
2009-04-06 11:36 ` Matthieu Moy
2009-04-06 18:09 ` Heiko Voigt
2009-04-07 7:23 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49D9E040.40007@op5.se \
--to=exon@op5.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hvoigt@hvoigt.net \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).