git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <peff@peff.net>
To: Heiko Voigt <hvoigt@hvoigt.net>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] Add configuration variable for sign-off to format-patch
Date: Wed, 1 Apr 2009 06:26:10 -0400	[thread overview]
Message-ID: <20090401102610.GC26181@coredump.intra.peff.net> (raw)
In-Reply-To: <20090331204338.GA88381@macbook.lan>

On Tue, Mar 31, 2009 at 10:43:48PM +0200, Heiko Voigt wrote:

> I see, it is of course true that you should not just sign off
> everything without thinking about it.
> 
> However I always read through my messages before sending them and it is
> way easier to delete that line than typing/copying it.

I agree. Personally, the concept of writing something that I _couldn't_
sign off on is so foreign to me that I would be very conscious of the
fact, and it would be simple to remove it during the final proof-read of
the patch that I do.

I think to satisfy everyone, though, you need some extra text in the
documentation indicating that signing off is supposed to be conscious,
and you should understand the implications of setting the variable.

-Peff

  reply	other threads:[~2009-04-01 10:27 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-31 18:50 [PATCH] Add configuration variable for sign-off to format-patch Heiko Voigt
2009-03-31 19:47 ` Andreas Ericsson
2009-04-01 17:53   ` Heiko Voigt
2009-03-31 20:04 ` Jeff King
2009-03-31 20:43   ` Heiko Voigt
2009-04-01 10:26     ` Jeff King [this message]
2009-04-01 17:51       ` [PATCH v2] " Heiko Voigt
2009-04-01 17:55         ` Sverre Rabbelier
2009-04-06  8:14         ` Junio C Hamano
2009-04-06 10:58           ` Andreas Ericsson
2009-04-06 11:36             ` Matthieu Moy
2009-04-06 18:09               ` Heiko Voigt
2009-04-07  7:23             ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090401102610.GC26181@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=hvoigt@hvoigt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).