From: A Large Angry SCM <gitzilla@gmail.com>
To: Johannes Schindelin <johannes.schindelin@gmx.de>
Cc: git@vger.kernel.org, gitster@pobox.com,
Marius Storm-Olsen <marius@trolltech.com>
Subject: Re: [PATCH] mailmap: resurrect lower-casing of email addresses
Date: Thu, 02 Apr 2009 18:22:55 -0400 [thread overview]
Message-ID: <49D53ABF.80706@gmail.com> (raw)
In-Reply-To: <f182fb1700e8dea15459fd02ced2a6e5797bec99.1238458535u.git.johannes.schindelin@gmx.de>
{I may be late to this change since I'm trying to catch up on the ML.]
Johannes Schindelin wrote:
> Commit 0925ce4(Add map_user() and clear_mailmap() to mailmap) broke the
> lower-casing of email addresses. This mostly did not matter if your
> .mailmap has only lower-case email addresses; However, we did not
> require .mailmap to contain lowercase-only email addresses.
What part of the email address is this going to lowercase? Only the
domain name is case agnostic.
>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> ---
> lezzee how that goes
> mailmap.c | 9 +++++++++
> 1 files changed, 9 insertions(+), 0 deletions(-)
>
> diff --git a/mailmap.c b/mailmap.c
> index f12bb45..6be91b6 100644
> --- a/mailmap.c
> +++ b/mailmap.c
> @@ -50,6 +50,15 @@ static void add_mapping(struct string_list *map,
> {
> struct mailmap_entry *me;
> int index;
> + char *p;
> +
> + if (old_email)
> + for (p = old_email; *p; p++)
> + *p = tolower(*p);
> + if (new_email)
> + for (p = new_email; *p; p++)
> + *p = tolower(*p);
> +
> if (old_email == NULL) {
> old_email = new_email;
> new_email = NULL;
next prev parent reply other threads:[~2009-04-02 22:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1238458535u.git.johannes.schindelin@gmx.de>
2009-03-31 0:18 ` [PATCH] mailmap: resurrect lower-casing of email addresses Johannes Schindelin
2009-04-02 22:22 ` A Large Angry SCM [this message]
2009-04-02 22:39 ` Johannes Schindelin
2009-04-02 22:42 ` Junio C Hamano
2009-04-02 22:58 ` A Large Angry SCM
2009-04-02 23:08 ` Johannes Schindelin
2009-04-02 23:17 ` A Large Angry SCM
2009-04-03 2:52 ` Johannes Schindelin
2009-04-03 12:45 ` Jeff King
2009-04-04 1:32 ` A Large Angry SCM
2009-04-06 9:16 ` Johannes Schindelin
2009-04-07 2:08 ` A Large Angry SCM
2009-04-07 11:16 ` Johannes Schindelin
2009-04-07 19:58 ` Markus Heidelberg
2009-04-08 9:36 ` Alles wird Git, was " Johannes Schindelin
2009-04-08 0:50 ` A Large Angry SCM
2009-04-08 2:21 ` Alles wird Git, was " Johannes Schindelin
2009-04-08 11:20 ` Alles wird Git A Large Angry SCM
2009-04-04 1:51 ` [PATCH] mailmap: resurrect lower-casing of email addresses A Large Angry SCM
2009-04-07 5:52 ` Marius Storm-Olsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49D53ABF.80706@gmail.com \
--to=gitzilla@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
--cc=marius@trolltech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).