(unknown)

(unknown)

[amery]

>From 25cb047690dd6101527cdfa6198dd6a6f93bf095 Mon Sep 17 00:00:00 2001
From: Alejandro Mery <amery@geeks.cl>
Date: Mon, 16 Jun 2008 20:27:14 +0200
Subject: [PATCH] git-am: head -1 is obsolete and doesn't work on some new systems

http://www.opengroup.org/onlinepubs/009695399/utilities/head.html
---
 git-am.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/git-am.sh b/git-am.sh
index b48096e..797988f 100755
--- a/git-am.sh
+++ b/git-am.sh
@@ -421,7 +421,7 @@ do
 	else
 	    action=yes
 	fi
-	FIRSTLINE=$(head -1 "$dotest/final-commit")
+	FIRSTLINE=$(head -n1 "$dotest/final-commit")
 
 	if test $action = skip
 	then
-- 
1.5.4.3

Re: [PATCH] git-am: head -1 is obsolete and doesn't work on some new systems

[Jakub Narebski]

<amery@geeks.cl> writes:

> From 25cb047690dd6101527cdfa6198dd6a6f93bf095 Mon Sep 17 00:00:00 2001

This line is not needed (unless you use git-send-mail, or import patch
as mbox to your MUA), and it should be removed.

> From: Alejandro Mery <amery@geeks.cl>
> Date: Mon, 16 Jun 2008 20:27:14 +0200
> Subject: [PATCH] git-am: head -1 is obsolete and doesn't work on some new systems

These headers should go as mailing list headers, which mean that your
MUA should generate proper from (if it cannot, the From: would have to
stay), and subject should go as email subject.

> http://www.opengroup.org/onlinepubs/009695399/utilities/head.html

We are not interested in theoretical POSIX compliance, see
CodingGuidelines.

Patch lacks signoff line, per SubmittingPatches

: Signed-off-by: Alejandro Mery <amery@geeks.cl>

> ---
>  git-am.sh |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/git-am.sh b/git-am.sh
> index b48096e..797988f 100755
> --- a/git-am.sh
> +++ b/git-am.sh
> @@ -421,7 +421,7 @@ do
>  	else
>  	    action=yes
>  	fi
> -	FIRSTLINE=$(head -1 "$dotest/final-commit")
> +	FIRSTLINE=$(head -n1 "$dotest/final-commit")

For better portability it would be better use 'sed 1q' here instead.

: -	FIRSTLINE=$(head -1 "$dotest/final-commit")
: +	FIRSTLINE=$(sed -e 1q "$dotest/final-commit")


>  	if test $action = skip
>  	then
> -- 
> 1.5.4.3
> 

-- 
Jakub Narebski
Poland
ShadeHawk on #git

Re: [PATCH] git-am: head -1 is obsolete and doesn't work on some new systems

[Alejandro Mery]

[-- Attachment #1: Type: text/plain, Size: 877 bytes --]

Jakub Narebski wrote:
> <amery@geeks.cl> writes:
> 
>> From 25cb047690dd6101527cdfa6198dd6a6f93bf095 Mon Sep 17 00:00:00 2001
> 
> This line is not needed (unless you use git-send-mail, or import patch
> as mbox to your MUA), and it should be removed.
> 
>> From: Alejandro Mery <amery@geeks.cl>
>> Date: Mon, 16 Jun 2008 20:27:14 +0200
>> Subject: [PATCH] git-am: head -1 is obsolete and doesn't work on some new systems
> 
> These headers should go as mailing list headers, which mean that your
> MUA should generate proper from (if it cannot, the From: would have to
> stay), and subject should go as email subject.

I'm really sorry about this, I was trying to send what git-format-patch 
generated using ubuntu's nullmailer, but it didn't work as expected (no 
git-send-email on this thing)

I'll have to fight more before sending another patch from here.

Alejandro Mery

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/x-pkcs7-signature, Size: 5215 bytes --]

[PATCH] git-am: head -1 is obsolete and doesn't work on some new systems

[Alejandro Mery]

head -<n> was deprecated by POSIX, and as modern versions of coreutils
package don't support it at least one exports _POSIX2_VERSION=199209
it's fails on some systems.

head -n<n> is portable, but sed <n>q is even more.

Signed-off-by: Alejandro Mery <amery@geeks.cl>
---
 git-am.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/git-am.sh b/git-am.sh
index b48096e..2c517ed 100755
--- a/git-am.sh
+++ b/git-am.sh
@@ -421,7 +421,7 @@ do
 	else
 	    action=yes
 	fi
-	FIRSTLINE=$(head -1 "$dotest/final-commit")
+	FIRSTLINE=$(sed 1q "$dotest/final-commit")
 
 	if test $action = skip
 	then
--
1.5.4.3