From: Erik Faye-Lund <kusmabite@googlemail.com>
To: "Gary V. Vaughan" <git@mlists.thewrittenword.com>
Cc: git@vger.kernel.org
Subject: Re: Portability patches vs 1.7.0.2 [5/6]
Date: Tue, 9 Mar 2010 18:08:15 +0100 [thread overview]
Message-ID: <40aa078e1003090908o74593fafw59bd992eda2b2b12@mail.gmail.com> (raw)
In-Reply-To: <20100309161906.GF99172@thor.il.thewrittenword.com>
In the future, please read Documentation/SubmittingPatches before
sending patches. Patches should be inlined, for one.
On Tue, Mar 9, 2010 at 5:19 PM, Gary V. Vaughan
<git@mlists.thewrittenword.com> wrote:
> Actually, I'd like some advice on whether this was a good idea? Was
> the change to the code in git-1.7.0 introduced in response to a bug
> (latent or reported) that is fixed by the code I reverted in this
> patch?
I'm the author of commit 15515b73, who introduced that change (due to
a bug). This is something that git-blame could have told you, and you
could have CC'ed me. It's pure luck that I had a look at this patch.
Simply doing memcmp will not work, since sockaddr_storage contains
both the IP-address and the port, but the port should not be compared.
> If so, what is the right way to fix it (assuming you don't
> want to introduce a dependency on gnulib and Automake into git)?
>
If ss_family doesn't exist, does that mean that the platform only supports IPv4?
--
Erik "kusma" Faye-Lund
next prev parent reply other threads:[~2010-03-09 17:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-09 16:19 Portability patches vs 1.7.0.2 [5/6] Gary V. Vaughan
2010-03-09 17:08 ` Erik Faye-Lund [this message]
2010-03-09 23:26 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40aa078e1003090908o74593fafw59bd992eda2b2b12@mail.gmail.com \
--to=kusmabite@googlemail.com \
--cc=git@mlists.thewrittenword.com \
--cc=git@vger.kernel.org \
--cc=kusmabite@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).