From: Jeff King <peff@peff.net>
To: "Gary V. Vaughan" <git@mlists.thewrittenword.com>
Cc: git@vger.kernel.org
Subject: Re: Portability patches vs 1.7.0.2 [5/6]
Date: Tue, 9 Mar 2010 18:26:24 -0500 [thread overview]
Message-ID: <20100309232624.GE25265@sigill.intra.peff.net> (raw)
In-Reply-To: <20100309161906.GF99172@thor.il.thewrittenword.com>
On Tue, Mar 09, 2010 at 04:19:06PM +0000, Gary V. Vaughan wrote:
> ## sockaddr_t->ss_family is not portable
I assume you mean sockaddr_storage here?
> Many of our supported platforms do not have this declaration, for
> example solaris2.6 thru 2.8 (I can find a complete list of which of
> our supported platforms have this problem).
Did you mean that list to be inclusive? My Solaris 2.8 definitely has
sockaddr_storage, as it is necessary for IPv6 handling. I don't remember
when IPv6 support was added, though...if it was in a minor release, then
presumably earlier versions of 2.8 did not.
At any rate, we should only need it for IPv6 support, so I think the
right solution would be to include all uses inside an "#ifndef NO_IPV6",
and for the NO_IPV6 case assume it's a sockaddr_in.
-Peff
prev parent reply other threads:[~2010-03-09 23:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-09 16:19 Portability patches vs 1.7.0.2 [5/6] Gary V. Vaughan
2010-03-09 17:08 ` Erik Faye-Lund
2010-03-09 23:26 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100309232624.GE25265@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@mlists.thewrittenword.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).