From: Johannes Sixt <j6t@kdbg.org>
To: "Jean-Noël Avila via GitGitGadget" <gitgitgadget@gmail.com>
Cc: "Jeff King" <peff@peff.net>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Jean-Noël Avila" <jn.avila@free.fr>,
git@vger.kernel.org
Subject: Re: [PATCH v2 11/11] i18n: turn even more messages into "cannot be used together" ones
Date: Tue, 28 Dec 2021 08:33:15 +0100 [thread overview]
Message-ID: <3fdc2585-06e6-231c-621a-b719ec5d8f46@kdbg.org> (raw)
In-Reply-To: <89066f01f32eb4ef8d6ea97aadda21cb36cbb6f2.1640647438.git.gitgitgadget@gmail.com>
Am 28.12.21 um 00:23 schrieb Jean-Noël Avila via GitGitGadget:
> From: =?UTF-8?q?Jean-No=C3=ABl=20Avila?= <jn.avila@free.fr>
>
> Even if some of these messages are not subject to gettext i18n, this
> helps bring a single style of message for a given error type.
>
> Signed-off-by: Jean-Noël Avila <jn.avila@free.fr>
> ---
> builtin/add.c | 2 +-
> builtin/am.c | 4 ++--
> builtin/cat-file.c | 2 +-
> builtin/checkout.c | 4 ++--
> builtin/clone.c | 2 +-
> builtin/commit.c | 10 ++++++----
> builtin/describe.c | 4 ++--
> builtin/init-db.c | 2 +-
> builtin/rebase.c | 4 ++--
> builtin/reset.c | 2 +-
> builtin/rev-list.c | 2 +-
> builtin/rm.c | 2 +-
> builtin/stash.c | 2 +-
> diff.c | 6 +++---
> t/t0001-init.sh | 4 ++--
> t/t2026-checkout-pathspec-file.sh | 2 +-
> t/t2072-restore-pathspec-file.sh | 2 +-
> t/t3431-rebase-fork-point.sh | 2 +-
> t/t3601-rm-pathspec-file.sh | 2 +-
> t/t3704-add-pathspec-file.sh | 2 +-
> t/t3909-stash-pathspec-file.sh | 2 +-
> t/t4209-log-pickaxe.sh | 4 ++--
> t/t5606-clone-options.sh | 2 +-
> t/t7107-reset-pathspec-file.sh | 2 +-
> t/t7500-commit-template-squash-signoff.sh | 11 ++++++-----
> t/t7526-commit-pathspec-file.sh | 4 ++--
> 26 files changed, 45 insertions(+), 42 deletions(-)
>
> diff --git a/builtin/add.c b/builtin/add.c
> index b505eca3d4d..ded15ca6eac 100644
> --- a/builtin/add.c
> +++ b/builtin/add.c
> @@ -566,7 +566,7 @@ int cmd_add(int argc, const char **argv, const char *prefix)
>
> if (pathspec_from_file) {
> if (pathspec.nr)
> - die(_("--pathspec-from-file is incompatible with pathspec arguments"));
> + die(_("'--pathspec-from-file' and pathspec arguments cannot be used together"));
You have not given a justification why this text does not begin with the
word "option". IMO, it is not needed; as written, the text is
sufficiently clear for both users and translators.
>
> parse_pathspec_file(&pathspec, PATHSPEC_ATTR,
> PATHSPEC_PREFER_FULL |
> diff --git a/builtin/am.c b/builtin/am.c
> index 8677ea2348a..be0e32f69cf 100644
> --- a/builtin/am.c
> +++ b/builtin/am.c
> @@ -2230,8 +2230,8 @@ static int parse_opt_show_current_patch(const struct option *opt, const char *ar
> }
>
> if (resume->mode == RESUME_SHOW_PATCH && new_value != resume->sub_mode)
> - return error(_("--show-current-patch=%s is incompatible with "
> - "--show-current-patch=%s"),
> + return error(_("options '--show-current-patch=%s' and '--show-current-patch=%s' "
> + "cannot used together"),
Missing "be".
> arg, valid_modes[resume->sub_mode]);
>
> resume->mode = RESUME_SHOW_PATCH;
> diff --git a/builtin/cat-file.c b/builtin/cat-file.c
> index 86fc03242b8..400ceaba5e8 100644
> --- a/builtin/cat-file.c
> +++ b/builtin/cat-file.c
> @@ -729,7 +729,7 @@ int cmd_cat_file(int argc, const char **argv, const char *prefix)
> }
>
> if (force_path && batch.enabled) {
> - error("--path=<path> incompatible with --batch");
> + error("'--path=<path>' and '--batch' cannot be used together");
Missing "options" perhaps.
> usage_with_options(cat_file_usage, options);
> }
>
> diff --git a/builtin/checkout.c b/builtin/checkout.c
> index d005aaad9f2..e83684a58b9 100644
> --- a/builtin/checkout.c
> +++ b/builtin/checkout.c
> @@ -1635,7 +1635,7 @@ static int checkout_main(int argc, const char **argv, const char *prefix,
> }
>
> if ((!!opts->new_branch + !!opts->new_branch_force + !!opts->new_orphan_branch) > 1)
> - die(_("-%c, -%c and --orphan are mutually exclusive"),
> + die(_("options '-%c', '-%c' and '--orphan' cannot be used together"),
> cb_option, toupper(cb_option));
>
> if (opts->overlay_mode == 1 && opts->patch_mode)
> @@ -1746,7 +1746,7 @@ static int checkout_main(int argc, const char **argv, const char *prefix,
>
> if (opts->pathspec_from_file) {
> if (opts->pathspec.nr)
> - die(_("--pathspec-from-file is incompatible with pathspec arguments"));
> + die(_("'--pathspec-from-file' and pathspec arguments cannot be used together"));
>
> if (opts->force_detach)
> die(_("options '%s' and '%s' cannot be used together"), "--pathspec-from-file", "--detach");
> diff --git a/builtin/clone.c b/builtin/clone.c
> index 13bdbe14b2f..cc92393e4a5 100644
> --- a/builtin/clone.c
> +++ b/builtin/clone.c
> @@ -900,7 +900,7 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
>
> if (option_bare) {
> if (option_origin)
> - die(_("--bare and --origin %s options are incompatible."),
> + die(_("options '--bare' and '--origin %s' cannot be used together"),
> option_origin);
> if (real_git_dir)
> die(_("options '%s' and '%s' cannot be used together"), "--bare", "--separate-git-dir");
> diff --git a/builtin/commit.c b/builtin/commit.c
> index eb803a96ae3..fa454ea9421 100644
> --- a/builtin/commit.c
> +++ b/builtin/commit.c
> @@ -361,7 +361,7 @@ static const char *prepare_index(const char **argv, const char *prefix,
> die(_("options '%s' and '%s' cannot be used together"),"--pathspec-from-file", "-a");
>
> if (pathspec.nr)
> - die(_("--pathspec-from-file is incompatible with pathspec arguments"));
> + die(_("'--pathspec-from-file' and pathspec arguments cannot be used together"));
>
> parse_pathspec_file(&pathspec, 0,
> PATHSPEC_PREFER_FULL,
> @@ -799,7 +799,7 @@ static int prepare_to_commit(const char *index_file, const char *prefix,
>
> if (!strcmp(fixup_prefix, "amend")) {
> if (have_option_m)
> - die(_("cannot combine -m with --fixup:%s"), fixup_message);
> + die(_("options '-m' and '--fixup:%s' cannot be used together"), fixup_message);
> prepare_amend_commit(commit, &sb, &ctx);
> }
> } else if (!stat(git_path_merge_msg(the_repository), &statbuf)) {
> @@ -1229,9 +1229,11 @@ static void check_fixup_reword_options(int argc, const char *argv[]) {
> die(_("You are in the middle of a cherry-pick -- cannot reword."));
> }
> if (argc)
> - die(_("cannot combine reword option of --fixup with path '%s'"), *argv);
> + die(_("reword option of --fixup and path '%s' cannot be used together"), *argv);
> if (patch_interactive || interactive || all || also || only)
> - die(_("reword option of --fixup is mutually exclusive with --patch/--interactive/--all/--include/--only"));
> + die(_("reword option of --fixup and "
> + "--patch/--interactive/--all/--include/--only "
> + "cannot be used together"));
> }
>
> static int parse_and_validate_options(int argc, const char *argv[],
> diff --git a/builtin/describe.c b/builtin/describe.c
> index fd5ba1fc604..130b87b3a34 100644
> --- a/builtin/describe.c
> +++ b/builtin/describe.c
> @@ -670,9 +670,9 @@ int cmd_describe(int argc, const char **argv, const char *prefix)
> }
> describe("HEAD", 1);
> } else if (dirty) {
> - die(_("--dirty is incompatible with commit-ishes"));
> + die(_("'%s' and commit-ishes cannot be used together"), "--dirty");
> } else if (broken) {
> - die(_("--broken is incompatible with commit-ishes"));
> + die(_("'%s' and commit-ishes cannot be used together"), "--broken");
I noticed immediately that the two texts are not the same because they
are not aligned, but it took me a few seconds to notice the extra blank
in the second one.
> } else {
> while (argc-- > 0)
> describe(*argv++, argc == 0);
> diff --git a/builtin/init-db.c b/builtin/init-db.c
> index 546f9c595e7..b85dffbdf5c 100644
> --- a/builtin/init-db.c
> +++ b/builtin/init-db.c
> @@ -681,7 +681,7 @@ int cmd_init_db(int argc, const char **argv, const char *prefix)
> }
> else {
> if (real_git_dir)
> - die(_("--separate-git-dir incompatible with bare repository"));
> + die(_("'--separate-git-dir' and bare repository cannot be used together"));
IMO, in this case, the original text is awkward, and the transformation
is worse because it really sounds like a mechanical replacement. I
suggest not to do this transformation.
> if (work_tree)
> set_git_work_tree(work_tree);
> }
> diff --git a/builtin/rebase.c b/builtin/rebase.c
> index ed326b8aecc..d3ce0999786 100644
> --- a/builtin/rebase.c
> +++ b/builtin/rebase.c
> @@ -1460,8 +1460,8 @@ int cmd_rebase(int argc, const char **argv, const char *prefix)
>
> if (i >= 0) {
> if (is_merge(&options))
> - die(_("cannot combine apply options with "
> - "merge options"));
> + die(_("apply options and merge options "
> + "cannot be used together"));
> else
> options.type = REBASE_APPLY;
> }
> diff --git a/builtin/reset.c b/builtin/reset.c
> index 25f52ea99f6..9fba34addf4 100644
> --- a/builtin/reset.c
> +++ b/builtin/reset.c
> @@ -426,7 +426,7 @@ int cmd_reset(int argc, const char **argv, const char *prefix)
> die(_("options '%s' and '%s' cannot be used together"), "--pathspec-from-file", "--patch");
>
> if (pathspec.nr)
> - die(_("--pathspec-from-file is incompatible with pathspec arguments"));
> + die(_("'--pathspec-from-file' and pathspec arguments cannot be used together"));
>
> parse_pathspec_file(&pathspec, 0,
> PATHSPEC_PREFER_FULL,
> diff --git a/builtin/rev-list.c b/builtin/rev-list.c
> index de60cbdbc9d..0e3d93afed3 100644
> --- a/builtin/rev-list.c
> +++ b/builtin/rev-list.c
> @@ -676,7 +676,7 @@ int cmd_rev_list(int argc, const char **argv, const char *prefix)
> if (revs.count &&
> (revs.tag_objects || revs.tree_objects || revs.blob_objects) &&
> (revs.left_right || revs.cherry_mark))
> - die(_("marked counting is incompatible with --objects"));
> + die(_("marked counting and '--objects' cannot be used together"));
>
> save_commit_buffer = (revs.verbose_header ||
> revs.grep_filter.pattern_list ||
> diff --git a/builtin/rm.c b/builtin/rm.c
> index 38ac3c71252..7f1cd6a33f8 100644
> --- a/builtin/rm.c
> +++ b/builtin/rm.c
> @@ -272,7 +272,7 @@ int cmd_rm(int argc, const char **argv, const char *prefix)
>
> if (pathspec_from_file) {
> if (pathspec.nr)
> - die(_("--pathspec-from-file is incompatible with pathspec arguments"));
> + die(_("'--pathspec-from-file' and pathspec arguments cannot be used together"));
>
> parse_pathspec_file(&pathspec, 0,
> PATHSPEC_PREFER_CWD,
> diff --git a/builtin/stash.c b/builtin/stash.c
> index 7ad2f9aca87..242be3eb7e8 100644
> --- a/builtin/stash.c
> +++ b/builtin/stash.c
> @@ -1706,7 +1706,7 @@ static int push_stash(int argc, const char **argv, const char *prefix,
> die(_("options '%s' and '%s' cannot be used together"), "--pathspec-from-file", "--staged");
>
> if (ps.nr)
> - die(_("--pathspec-from-file is incompatible with pathspec arguments"));
> + die(_("'--pathspec-from-file' and pathspec arguments cannot be used together"));
>
> parse_pathspec_file(&ps, 0,
> PATHSPEC_PREFER_FULL | PATHSPEC_PREFIX_ORIGIN,
> diff --git a/diff.c b/diff.c
> index 8de1c49763c..ba2a886ec2c 100644
> --- a/diff.c
> +++ b/diff.c
> @@ -4639,16 +4639,16 @@ void diff_setup_done(struct diff_options *options)
> options->set_default(options);
>
> if (HAS_MULTI_BITS(options->output_format & check_mask))
> - die(_("--name-only, --name-status, --check and -s are mutually exclusive"));
> + die(_("options '--name-only', '--name-status', '--check' and '-s' cannot be used together"));
>
> if (HAS_MULTI_BITS(options->pickaxe_opts & DIFF_PICKAXE_KINDS_MASK))
> die(_("options '%s', '%s' and '%s' cannot be used together"), "-G", "-S", "--find-object");
>
> if (HAS_MULTI_BITS(options->pickaxe_opts & DIFF_PICKAXE_KINDS_G_REGEX_MASK))
> - die(_("-G and --pickaxe-regex are mutually exclusive, use --pickaxe-regex with -S"));
> + die(_("-G and --pickaxe-regex cannot be used together, use --pickaxe-regex with -S"));
>
> if (HAS_MULTI_BITS(options->pickaxe_opts & DIFF_PICKAXE_KINDS_ALL_OBJFIND_MASK))
> - die(_("--pickaxe-all and --find-object are mutually exclusive, use --pickaxe-all with -G and -S"));
> + die(_("--pickaxe-all and --find-object cannot be used together, use --pickaxe-all with -G and -S"));
>
> /*
> * Most of the time we can say "there are changes"
> diff --git a/t/t0001-init.sh b/t/t0001-init.sh
> index 3235ab4d53c..7d8bae09c25 100755
> --- a/t/t0001-init.sh
> +++ b/t/t0001-init.sh
> @@ -339,7 +339,7 @@ test_expect_success 'implicit bare & --separate-git-dir incompatible' '
> mkdir -p bare.git &&
> test_must_fail env GIT_DIR=. \
> git -C bare.git init --separate-git-dir goop.git 2>err &&
> - test_i18ngrep "incompatible" err
> + test_i18ngrep "cannot be used together" err
> '
>
> test_expect_success 'bare & --separate-git-dir incompatible within worktree' '
> @@ -348,7 +348,7 @@ test_expect_success 'bare & --separate-git-dir incompatible within worktree' '
> git clone --bare . bare.git &&
> git -C bare.git worktree add --detach ../linkwt &&
> test_must_fail git -C linkwt init --separate-git-dir seprepo 2>err &&
> - test_i18ngrep "incompatible" err
> + test_i18ngrep "cannot be used together" err
> '
>
> test_lazy_prereq GETCWD_IGNORES_PERMS '
> diff --git a/t/t2026-checkout-pathspec-file.sh b/t/t2026-checkout-pathspec-file.sh
> index fbe26de2f90..2bd8cd74206 100755
> --- a/t/t2026-checkout-pathspec-file.sh
> +++ b/t/t2026-checkout-pathspec-file.sh
> @@ -155,7 +155,7 @@ test_expect_success 'error conditions' '
> test_i18ngrep -e "options .--pathspec-from-file. and .--patch. cannot be used together" err &&
>
> test_must_fail git checkout --pathspec-from-file=list -- fileA.t 2>err &&
> - test_i18ngrep -e "--pathspec-from-file is incompatible with pathspec arguments" err &&
> + test_i18ngrep -e ".--pathspec-from-file. and pathspec arguments cannot be used together" err &&
>
> test_must_fail git checkout --pathspec-file-nul 2>err &&
> test_i18ngrep -e "--pathspec-file-nul requires --pathspec-from-file" err
> diff --git a/t/t2072-restore-pathspec-file.sh b/t/t2072-restore-pathspec-file.sh
> index ad1fc0ed071..4f7e9d47d28 100755
> --- a/t/t2072-restore-pathspec-file.sh
> +++ b/t/t2072-restore-pathspec-file.sh
> @@ -155,7 +155,7 @@ test_expect_success 'error conditions' '
> test_i18ngrep -e "options .--pathspec-from-file. and .--patch. cannot be used together" err &&
>
> test_must_fail git restore --pathspec-from-file=list --source=HEAD^1 -- fileA.t 2>err &&
> - test_i18ngrep -e "--pathspec-from-file is incompatible with pathspec arguments" err &&
> + test_i18ngrep -e ".--pathspec-from-file. and pathspec arguments cannot be used together" err &&
>
> test_must_fail git restore --pathspec-file-nul --source=HEAD^1 2>err &&
> test_i18ngrep -e "--pathspec-file-nul requires --pathspec-from-file" err &&
> diff --git a/t/t3431-rebase-fork-point.sh b/t/t3431-rebase-fork-point.sh
> index 4c98d99e7e8..1d0b15380ed 100755
> --- a/t/t3431-rebase-fork-point.sh
> +++ b/t/t3431-rebase-fork-point.sh
> @@ -83,7 +83,7 @@ test_expect_success 'git rebase --fork-point with ambigous refname' '
>
> test_expect_success '--fork-point and --root both given' '
> test_must_fail git rebase --fork-point --root 2>err &&
> - test_i18ngrep "cannot combine" err
> + test_i18ngrep "cannot be used together" err
> '
>
> test_expect_success 'rebase.forkPoint set to false' '
> diff --git a/t/t3601-rm-pathspec-file.sh b/t/t3601-rm-pathspec-file.sh
> index b2a8db69afc..b6ebde4e572 100755
> --- a/t/t3601-rm-pathspec-file.sh
> +++ b/t/t3601-rm-pathspec-file.sh
> @@ -67,7 +67,7 @@ test_expect_success 'error conditions' '
> echo fileA.t >list &&
>
> test_must_fail git rm --pathspec-from-file=list -- fileA.t 2>err &&
> - test_i18ngrep -e "--pathspec-from-file is incompatible with pathspec arguments" err &&
> + test_i18ngrep -e ".--pathspec-from-file. and pathspec arguments cannot be used together" err &&
>
> test_must_fail git rm --pathspec-file-nul 2>err &&
> test_i18ngrep -e "--pathspec-file-nul requires --pathspec-from-file" err &&
> diff --git a/t/t3704-add-pathspec-file.sh b/t/t3704-add-pathspec-file.sh
> index 7e17ae80229..38a22efcdda 100755
> --- a/t/t3704-add-pathspec-file.sh
> +++ b/t/t3704-add-pathspec-file.sh
> @@ -147,7 +147,7 @@ test_expect_success 'error conditions' '
> test_i18ngrep -e "options .--pathspec-from-file. and .--edit. cannot be used together" err &&
>
> test_must_fail git add --pathspec-from-file=list -- fileA.t 2>err &&
> - test_i18ngrep -e "--pathspec-from-file is incompatible with pathspec arguments" err &&
> + test_i18ngrep -e ".--pathspec-from-file. and pathspec arguments cannot be used together" err &&
>
> test_must_fail git add --pathspec-file-nul 2>err &&
> test_i18ngrep -e "--pathspec-file-nul requires --pathspec-from-file" err &&
> diff --git a/t/t3909-stash-pathspec-file.sh b/t/t3909-stash-pathspec-file.sh
> index aae2b25f766..43ddf051240 100755
> --- a/t/t3909-stash-pathspec-file.sh
> +++ b/t/t3909-stash-pathspec-file.sh
> @@ -91,7 +91,7 @@ test_expect_success 'error conditions' '
> test_i18ngrep -e "options .--pathspec-from-file. and .--patch. cannot be used together" err &&
>
> test_must_fail git stash push --pathspec-from-file=list -- fileA.t 2>err &&
> - test_i18ngrep -e "--pathspec-from-file is incompatible with pathspec arguments" err &&
> + test_i18ngrep -e ".--pathspec-from-file. and pathspec arguments cannot be used together" err &&
>
> test_must_fail git stash push --pathspec-file-nul 2>err &&
> test_i18ngrep -e "--pathspec-file-nul requires --pathspec-from-file" err
> diff --git a/t/t4209-log-pickaxe.sh b/t/t4209-log-pickaxe.sh
> index 4f820f8597d..7f6bb27f141 100755
> --- a/t/t4209-log-pickaxe.sh
> +++ b/t/t4209-log-pickaxe.sh
> @@ -72,12 +72,12 @@ test_expect_success 'usage' '
> grep "cannot be used together" err &&
>
> test_expect_code 128 git log --pickaxe-all --find-object=HEAD 2>err &&
> - grep "mutually exclusive" err
> + grep "cannot be used together" err
> '
>
> test_expect_success 'usage: --pickaxe-regex' '
> test_expect_code 128 git log -Gregex --pickaxe-regex 2>err &&
> - grep "mutually exclusive" err
> + grep "cannot be used together" err
> '
>
> test_expect_success 'usage: --no-pickaxe-regex' '
> diff --git a/t/t5606-clone-options.sh b/t/t5606-clone-options.sh
> index 3af3577af0b..8f676d6b0c0 100755
> --- a/t/t5606-clone-options.sh
> +++ b/t/t5606-clone-options.sh
> @@ -46,7 +46,7 @@ test_expect_success 'disallows --bare with --origin' '
>
> test_must_fail git clone -o foo --bare parent clone-bare-o 2>err &&
> test_debug "cat err" &&
> - test_i18ngrep -e "--bare and --origin foo options are incompatible" err
> + test_i18ngrep -e "options .--bare. and .--origin foo. cannot be used together" err
>
> '
>
> diff --git a/t/t7107-reset-pathspec-file.sh b/t/t7107-reset-pathspec-file.sh
> index b211fbc0a52..880adf79742 100755
> --- a/t/t7107-reset-pathspec-file.sh
> +++ b/t/t7107-reset-pathspec-file.sh
> @@ -163,7 +163,7 @@ test_expect_success 'error conditions' '
> test_i18ngrep -e "options .--pathspec-from-file. and .--patch. cannot be used together" err &&
>
> test_must_fail git reset --pathspec-from-file=list -- fileA.t 2>err &&
> - test_i18ngrep -e "--pathspec-from-file is incompatible with pathspec arguments" err &&
> + test_i18ngrep -e ".--pathspec-from-file. and pathspec arguments cannot be used together" err &&
>
> test_must_fail git reset --pathspec-file-nul 2>err &&
> test_i18ngrep -e "--pathspec-file-nul requires --pathspec-from-file" err &&
> diff --git a/t/t7500-commit-template-squash-signoff.sh b/t/t7500-commit-template-squash-signoff.sh
> index 8dd0f988129..2da97f479fe 100755
> --- a/t/t7500-commit-template-squash-signoff.sh
> +++ b/t/t7500-commit-template-squash-signoff.sh
> @@ -359,14 +359,14 @@ test_expect_success '--fixup=reword: ignores staged changes' '
>
> test_expect_success '--fixup=reword: error out with -m option' '
> commit_for_rebase_autosquash_setup &&
> - echo "fatal: cannot combine -m with --fixup:reword" >expect &&
> + echo "fatal: options '\''-m'\'' and '\''--fixup:reword'\'' cannot be used together" >expect &&
> test_must_fail git commit --fixup=reword:HEAD~ -m "reword commit message" 2>actual &&
> test_cmp expect actual
> '
>
> test_expect_success '--fixup=amend: error out with -m option' '
> commit_for_rebase_autosquash_setup &&
> - echo "fatal: cannot combine -m with --fixup:amend" >expect &&
> + echo "fatal: options '\''-m'\'' and '\''--fixup:amend'\'' cannot be used together" >expect &&
> test_must_fail git commit --fixup=amend:HEAD~ -m "amend commit message" 2>actual &&
> test_cmp expect actual
> '
> @@ -421,8 +421,9 @@ test_expect_success 'amend! commit allows empty commit msg body with --allow-emp
>
> test_fixup_reword_opt () {
> test_expect_success "--fixup=reword: incompatible with $1" "
> - echo 'fatal: reword option of --fixup is mutually exclusive with'\
> - '--patch/--interactive/--all/--include/--only' >expect &&
> + echo 'fatal: reword option of --fixup and'\
> + '--patch/--interactive/--all/--include/--only'\
> + 'cannot be used together' >expect &&
On first sight, it looked significant that there are no blanks between
"and", the single-quote, and the backslash. On second thought, the
backslash is just a line continuation, and the blank that is needed in
the text is inserted by "echo" because it emits its three arguments, the
single-quoted strings', in blank-separated form. This means that there
must not be a blank after "and" and after "--only" and before the
single-quotes. There could be a blank before the backslash.
Good.
> test_must_fail git commit --fixup=reword:HEAD~ $1 2>actual &&
> test_cmp expect actual
> "
> @@ -435,7 +436,7 @@ done
>
> test_expect_success '--fixup=reword: give error with pathsec' '
> commit_for_rebase_autosquash_setup &&
> - echo "fatal: cannot combine reword option of --fixup with path '\''foo'\''" >expect &&
> + echo "fatal: reword option of --fixup and path '\''foo'\'' cannot be used together" >expect &&
> test_must_fail git commit --fixup=reword:HEAD~ -- foo 2>actual &&
> test_cmp expect actual
> '
> diff --git a/t/t7526-commit-pathspec-file.sh b/t/t7526-commit-pathspec-file.sh
> index fb5857b2a13..b6013a1f742 100755
> --- a/t/t7526-commit-pathspec-file.sh
> +++ b/t/t7526-commit-pathspec-file.sh
> @@ -147,10 +147,10 @@ test_expect_success 'error conditions' '
> test_i18ngrep -e "options .--pathspec-from-file. and .--interactive/--patch. cannot be used together" err &&
>
> test_must_fail git commit --pathspec-from-file=list --all -m "Commit" 2>err &&
> - test_i18ngrep -e "--pathspec-from-file with -a does not make sense" err &&
> + test_i18ngrep -e ".--pathspec-from-file. and .-a. cannot be used together" err &&
>
> test_must_fail git commit --pathspec-from-file=list -m "Commit" -- fileA.t 2>err &&
> - test_i18ngrep -e "--pathspec-from-file is incompatible with pathspec arguments" err &&
> + test_i18ngrep -e ".--pathspec-from-file. and pathspec arguments cannot be used together" err &&
>
> test_must_fail git commit --pathspec-file-nul -m "Commit" 2>err &&
> test_i18ngrep -e "--pathspec-file-nul requires --pathspec-from-file" err &&
next prev parent reply other threads:[~2021-12-28 7:33 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-03 7:01 [PATCH 00/10] Factorization of messages with similar meaning Jean-Noël Avila via GitGitGadget
2021-12-03 7:01 ` [PATCH 01/10] i18n: refactor "foo and bar are mutually exclusive" Jean-Noël Avila via GitGitGadget
2021-12-07 18:07 ` Ævar Arnfjörð Bjarmason
2021-12-08 18:13 ` Jean-Noël AVILA
2021-12-03 7:01 ` [PATCH 02/10] i18n: refactor "%s, %s and %s " Jean-Noël Avila via GitGitGadget
2021-12-03 7:01 ` [PATCH 03/10] i18n: turn "options are incompatible" into "are " Jean-Noël Avila via GitGitGadget
2021-12-03 7:01 ` [PATCH 04/10] i18n: standardize "cannot open" and "cannot read" Jean-Noël Avila via GitGitGadget
2021-12-07 18:09 ` Ævar Arnfjörð Bjarmason
2021-12-03 7:01 ` [PATCH 05/10] i18n: tag.c factorize i18n strings Jean-Noël Avila via GitGitGadget
2021-12-07 18:10 ` Ævar Arnfjörð Bjarmason
2021-12-03 7:01 ` [PATCH 06/10] i18n: factorize "--foo requires --bar" and the like Jean-Noël Avila via GitGitGadget
2021-12-03 7:01 ` [PATCH 07/10] i18n: factorize "no directory given for --foo" Jean-Noël Avila via GitGitGadget
2021-12-03 7:01 ` [PATCH 08/10] i18n: refactor "unrecognized %(foo) argument" strings Jean-Noël Avila via GitGitGadget
2021-12-07 18:15 ` Ævar Arnfjörð Bjarmason
2021-12-03 7:01 ` [PATCH 09/10] i18n: factorize "--foo outside a repository" Jean-Noël Avila via GitGitGadget
2021-12-03 7:01 ` [PATCH 10/10] i18n: ref-filter: factorize "%(foo) atom used without %(bar) atom" Jean-Noël Avila via GitGitGadget
2021-12-03 21:55 ` [PATCH 00/10] Factorization of messages with similar meaning Jeff King
2021-12-03 23:39 ` Johannes Sixt
2021-12-05 7:31 ` Junio C Hamano
2021-12-05 17:25 ` Jean-Noël AVILA
2021-12-05 19:50 ` Johannes Sixt
2021-12-06 19:18 ` Junio C Hamano
2021-12-05 19:30 ` Junio C Hamano
2021-12-27 23:23 ` [PATCH v2 00/11] " Jean-Noël Avila via GitGitGadget
2021-12-27 23:23 ` [PATCH v2 01/11] i18n: refactor "foo and bar are mutually exclusive" Jean-Noël Avila via GitGitGadget
2021-12-27 23:23 ` [PATCH v2 02/11] i18n: refactor "%s, %s and %s " Jean-Noël Avila via GitGitGadget
2021-12-27 23:23 ` [PATCH v2 03/11] i18n: turn "options are incompatible" into "cannot be used together" Jean-Noël Avila via GitGitGadget
2021-12-27 23:23 ` [PATCH v2 04/11] i18n: standardize "cannot open" and "cannot read" Jean-Noël Avila via GitGitGadget
2021-12-27 23:23 ` [PATCH v2 05/11] i18n: tag.c factorize i18n strings Jean-Noël Avila via GitGitGadget
2021-12-27 23:42 ` Junio C Hamano
2021-12-27 23:45 ` Ævar Arnfjörð Bjarmason
2021-12-28 0:16 ` Junio C Hamano
2021-12-29 14:05 ` Jean-Noël AVILA
2021-12-27 23:23 ` [PATCH v2 06/11] i18n: factorize "--foo requires --bar" and the like Jean-Noël Avila via GitGitGadget
2021-12-28 7:01 ` Johannes Sixt
2021-12-29 14:02 ` Jean-Noël AVILA
2021-12-27 23:23 ` [PATCH v2 07/11] i18n: factorize "no directory given for --foo" Jean-Noël Avila via GitGitGadget
2021-12-27 23:23 ` [PATCH v2 08/11] i18n: refactor "unrecognized %(foo) argument" strings Jean-Noël Avila via GitGitGadget
2021-12-27 23:23 ` [PATCH v2 09/11] i18n: factorize "--foo outside a repository" Jean-Noël Avila via GitGitGadget
2021-12-27 23:23 ` [PATCH v2 10/11] i18n: ref-filter: factorize "%(foo) atom used without %(bar) atom" Jean-Noël Avila via GitGitGadget
2021-12-27 23:23 ` [PATCH v2 11/11] i18n: turn even more messages into "cannot be used together" ones Jean-Noël Avila via GitGitGadget
2021-12-28 7:33 ` Johannes Sixt [this message]
2021-12-29 15:49 ` Jean-Noël AVILA
2021-12-29 18:54 ` [PATCH v3 00/11] Factorization of messages with similar meaning Jean-Noël Avila via GitGitGadget
2021-12-29 18:54 ` [PATCH v3 01/11] i18n: refactor "foo and bar are mutually exclusive" Jean-Noël Avila via GitGitGadget
2021-12-29 18:54 ` [PATCH v3 02/11] i18n: refactor "%s, %s and %s " Jean-Noël Avila via GitGitGadget
2021-12-30 22:26 ` Junio C Hamano
2021-12-31 17:05 ` Jean-Noël AVILA
2021-12-29 18:54 ` [PATCH v3 03/11] i18n: turn "options are incompatible" into "cannot be used together" Jean-Noël Avila via GitGitGadget
2021-12-29 19:36 ` Johannes Sixt
2021-12-30 16:52 ` Jean-Noël AVILA
2021-12-30 22:36 ` Junio C Hamano
2021-12-29 18:55 ` [PATCH v3 04/11] i18n: standardize "cannot open" and "cannot read" Jean-Noël Avila via GitGitGadget
2021-12-29 18:55 ` [PATCH v3 05/11] i18n: tag.c factorize i18n strings Jean-Noël Avila via GitGitGadget
2022-01-01 14:14 ` René Scharfe
2021-12-29 18:55 ` [PATCH v3 06/11] i18n: factorize "--foo requires --bar" and the like Jean-Noël Avila via GitGitGadget
2021-12-29 18:55 ` [PATCH v3 07/11] i18n: factorize "no directory given for --foo" Jean-Noël Avila via GitGitGadget
2021-12-30 22:36 ` Junio C Hamano
2021-12-29 18:55 ` [PATCH v3 08/11] i18n: refactor "unrecognized %(foo) argument" strings Jean-Noël Avila via GitGitGadget
2021-12-29 18:55 ` [PATCH v3 09/11] i18n: factorize "--foo outside a repository" Jean-Noël Avila via GitGitGadget
2021-12-29 18:55 ` [PATCH v3 10/11] i18n: ref-filter: factorize "%(foo) atom used without %(bar) atom" Jean-Noël Avila via GitGitGadget
2021-12-29 18:55 ` [PATCH v3 11/11] i18n: turn even more messages into "cannot be used together" ones Jean-Noël Avila via GitGitGadget
2021-12-30 22:36 ` Junio C Hamano
2021-12-31 17:16 ` Jean-Noël AVILA
2022-01-03 21:51 ` Junio C Hamano
2022-01-02 17:15 ` [PATCH v4 00/11] Factorization of messages with similar meaning Jean-Noël Avila via GitGitGadget
2022-01-02 17:15 ` [PATCH v4 01/11] i18n: refactor "foo and bar are mutually exclusive" Jean-Noël Avila via GitGitGadget
2022-01-02 17:15 ` [PATCH v4 02/11] i18n: refactor "%s, %s and %s " Jean-Noël Avila via GitGitGadget
2022-01-03 15:44 ` Johannes Sixt
2022-01-02 17:15 ` [PATCH v4 03/11] i18n: turn "options are incompatible" into "cannot be used together" Jean-Noël Avila via GitGitGadget
2022-01-02 17:15 ` [PATCH v4 04/11] i18n: standardize "cannot open" and "cannot read" Jean-Noël Avila via GitGitGadget
2022-01-02 17:15 ` [PATCH v4 05/11] i18n: tag.c factorize i18n strings Jean-Noël Avila via GitGitGadget
2022-01-02 17:37 ` René Scharfe
2022-01-02 20:29 ` Jean-Noël AVILA
2022-01-02 17:15 ` [PATCH v4 06/11] i18n: factorize "--foo requires --bar" and the like Jean-Noël Avila via GitGitGadget
2022-01-02 17:15 ` [PATCH v4 07/11] i18n: factorize "no directory given for --foo" Jean-Noël Avila via GitGitGadget
2022-01-02 17:15 ` [PATCH v4 08/11] i18n: refactor "unrecognized %(foo) argument" strings Jean-Noël Avila via GitGitGadget
2022-01-02 17:15 ` [PATCH v4 09/11] i18n: factorize "--foo outside a repository" Jean-Noël Avila via GitGitGadget
2022-01-02 17:15 ` [PATCH v4 10/11] i18n: ref-filter: factorize "%(foo) atom used without %(bar) atom" Jean-Noël Avila via GitGitGadget
2022-01-02 17:15 ` [PATCH v4 11/11] i18n: turn even more messages into "cannot be used together" ones Jean-Noël Avila via GitGitGadget
2022-01-05 20:02 ` [PATCH v5 00/11] Factorization of messages with similar meaning Jean-Noël Avila via GitGitGadget
2022-01-05 20:02 ` [PATCH v5 01/11] i18n: refactor "foo and bar are mutually exclusive" Jean-Noël Avila via GitGitGadget
2022-01-05 20:02 ` [PATCH v5 02/11] i18n: refactor "%s, %s and %s " Jean-Noël Avila via GitGitGadget
2022-01-05 20:02 ` [PATCH v5 03/11] i18n: turn "options are incompatible" into "cannot be used together" Jean-Noël Avila via GitGitGadget
2022-01-05 20:02 ` [PATCH v5 04/11] i18n: standardize "cannot open" and "cannot read" Jean-Noël Avila via GitGitGadget
2022-01-05 20:02 ` [PATCH v5 05/11] i18n: tag.c factorize i18n strings Jean-Noël Avila via GitGitGadget
2022-01-05 20:02 ` [PATCH v5 06/11] i18n: factorize "--foo requires --bar" and the like Jean-Noël Avila via GitGitGadget
2022-01-05 20:02 ` [PATCH v5 07/11] i18n: factorize "no directory given for --foo" Jean-Noël Avila via GitGitGadget
2022-01-05 20:02 ` [PATCH v5 08/11] i18n: refactor "unrecognized %(foo) argument" strings Jean-Noël Avila via GitGitGadget
2022-01-05 20:02 ` [PATCH v5 09/11] i18n: factorize "--foo outside a repository" Jean-Noël Avila via GitGitGadget
2022-01-05 20:02 ` [PATCH v5 10/11] i18n: ref-filter: factorize "%(foo) atom used without %(bar) atom" Jean-Noël Avila via GitGitGadget
2022-01-05 20:02 ` [PATCH v5 11/11] i18n: turn even more messages into "cannot be used together" ones Jean-Noël Avila via GitGitGadget
2022-01-05 20:58 ` [PATCH v5 00/11] Factorization of messages with similar meaning Johannes Sixt
2022-01-05 21:31 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3fdc2585-06e6-231c-621a-b719ec5d8f46@kdbg.org \
--to=j6t@kdbg.org \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=jn.avila@free.fr \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).