From: Kyle McKay <mackyle@gmail.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: git@vger.kernel.org, David Rothenberger <daveroth@acm.org>,
Petr Baudis <pasky@ucw.cz>, Daniel Shahaf <danielsh@apache.org>,
Eric Wong <normalperson@yhbt.net>
Subject: Re: [PATCH 2/2] git-svn: allow git-svn fetching to work using serf
Date: Sat, 6 Jul 2013 19:46:40 -0700 [thread overview]
Message-ID: <3871C226-16AE-4E25-8AD3-007EDAB0E25F@gmail.com> (raw)
In-Reply-To: <20130707022332.GD4193@google.com>
On Jul 6, 2013, at 19:23, Jonathan Nieder wrote:
> Kyle McKay wrote:
>
>> Unless bulk updates are disabled when using the serf access method
>> (the only one available with svn 1.8) for https?: urls,
>> apply_textdelta does indeed get called multiple times in a row
>> without an intervening temp_release.
>
> You mean "Unless bulk updates are enabled" and "without an intervening
> close_file", right?
The problem seems to be skelta mode although it may just be the fact
that ra_serf has multiple connections outstanding and since ra_neon
only ever has one it can't happen over ra_neon.
If the server disables bulk updates (SVNAllowBulkUpdates Off) all
clients are forced to use skelta mode, even ra_neon clients.
> This sounds like something that should be fixed in ra_serf.
Yes, but apparently it will not be.
> But if the number of overlapping open text nodes is bounded by a low
> number, the workaround of using multiple temp files sounds ok as a way
> of dealing with unfixed versions of Subversion.
I believe it will never exceed twice ('svn_delta...' and
'git_blob...') the maximum number of serf connections allowed. Four
by default (hard-coded prior to svn 1.8). Limited to between 1 and 8
on svn 1.8. Actually it looks like from my testing that it won't ever
exceed twice the (max number of serf connections - 1).
Kyle
next prev parent reply other threads:[~2013-07-07 2:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-06 3:44 [PATCH 2/2] git-svn: allow git-svn fetching to work using serf Kyle McKay
2013-07-07 0:24 ` Jonathan Nieder
2013-07-07 2:13 ` Kyle McKay
2013-07-07 2:23 ` Jonathan Nieder
2013-07-07 2:46 ` Kyle McKay [this message]
2013-07-07 13:39 ` Daniel Shahaf
2013-07-07 16:18 ` David Rothenberger
2013-07-07 18:27 ` Kyle McKay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3871C226-16AE-4E25-8AD3-007EDAB0E25F@gmail.com \
--to=mackyle@gmail.com \
--cc=danielsh@apache.org \
--cc=daveroth@acm.org \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=normalperson@yhbt.net \
--cc=pasky@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).