From: Kyle McKay <mackyle@gmail.com>
To: git@vger.kernel.org
Cc: Jonathan Nieder <jrnieder@gmail.com>,
David Rothenberger <daveroth@acm.org>, Petr Baudis <pasky@ucw.cz>,
Eric Wong <normalperson@yhbt.net>
Subject: Re: [PATCH 2/2] git-svn: allow git-svn fetching to work using serf
Date: Sun, 7 Jul 2013 11:27:20 -0700 [thread overview]
Message-ID: <053E9C47-31D9-4BD8-A417-4CEC371B1A07@gmail.com> (raw)
In-Reply-To: <20130707133957.GA3648@lp-shahaf.local>
I forwarded the "SVNAllowBulkUpdates Off" question to the users@subversion.apache.org
list and here's the reply:
On Jul 7, 2013, at 11:11, Lieven Govaerts wrote:
> On Sun, Jul 7, 2013 at 4:48 PM, Kyle McKay <mackyle@gmail.com> wrote:
>> On Jul 7, 2013, at 06:39, Daniel Shahaf wrote:
>>>
>>> Kyle McKay wrote on Sat, Jul 06, 2013 at 19:46:40 -0700:
>>>>
>>>> On Jul 6, 2013, at 19:23, Jonathan Nieder wrote:
>>>>>
>>>>> Kyle McKay wrote:
>>>>>
>>>>>> Unless bulk updates are disabled when using the serf access
>>>>>> method
>>>>>> (the only one available with svn 1.8) for https?: urls,
>>>>>> apply_textdelta does indeed get called multiple times in a row
>>>>>> without an intervening temp_release.
>>>>>
>>>>>
>>>>> You mean "Unless bulk updates are enabled" and "without an
>>>>> intervening
>>>>> close_file", right?
>>>>
>>>>
>>>> The problem seems to be skelta mode although it may just be the
>>>> fact
>>>> that ra_serf has multiple connections outstanding and since
>>>> ra_neon only
>>>> ever has one it can't happen over ra_neon.
>>>>
>>>> If the server disables bulk updates (SVNAllowBulkUpdates Off) all
>>>> clients are forced to use skelta mode, even ra_neon clients.
>>>
>>>
>>> As Brane and I have pointed out, git-svn can instruct libsvn_* to
>>> use
>>> bulk updates regardless of the server version, by setting
>>> SVN_CONFIG_OPTION_HTTP_BULK_UPDATES (new in 1.8).
>>>
>>> If you have questions about that, though, please address them to
>>> users@subversion.apache.org (the proper list for API usage
>>> questions),
>>> not to me personally.
>>
>>
>> According to the table at
>> <http://subversion.apache.org/docs/release-notes/1.8.html#serf-skelta-default
>> >,
>> if the server sets SVNAllowBulkUpdates Off, the client will be
>> forced to use
>> skelta no matter what the client setting is.
>
> Indeed, the server admin has the final say in which mode is actually
> used. SVNAllowBulkUpdates Off is only advised if the server admin
> wants a log line per accessed resource. I doubt it's used a lot, but
> the option is there.
>
>>
>> Is that table incorrect?
>
> No, that table is correct.
>
> Lieven
So the final say so on whether or not bulk updates are allowed is on
the server side which means git-svn really needs to handle skelta mode
on the client side properly when using ra-serf to guarantee
functionality with all subversion server configurations.
Kyle
prev parent reply other threads:[~2013-07-07 18:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-06 3:44 [PATCH 2/2] git-svn: allow git-svn fetching to work using serf Kyle McKay
2013-07-07 0:24 ` Jonathan Nieder
2013-07-07 2:13 ` Kyle McKay
2013-07-07 2:23 ` Jonathan Nieder
2013-07-07 2:46 ` Kyle McKay
2013-07-07 13:39 ` Daniel Shahaf
2013-07-07 16:18 ` David Rothenberger
2013-07-07 18:27 ` Kyle McKay [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=053E9C47-31D9-4BD8-A417-4CEC371B1A07@gmail.com \
--to=mackyle@gmail.com \
--cc=daveroth@acm.org \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=normalperson@yhbt.net \
--cc=pasky@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).