From: Thomas Rast <trast@student.ethz.ch>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Johannes Sixt <j6t@kdbg.org>,
Jeff King <peff@peff.net>,
Alexander Potashev <aspotashev@gmail.com>
Subject: [PATCH v2 1/3] Introduce die_errno() that appends strerror(errno) to die()
Date: Sat, 6 Jun 2009 16:44:51 +0200 [thread overview]
Message-ID: <3672f22723a4c14c4a6d67278e9865424c0c68dc.1244299302.git.trast@student.ethz.ch> (raw)
In-Reply-To: <cover.1244299302.git.trast@student.ethz.ch>
In-Reply-To: <cover.1244299302.git.trast@student.ethz.ch>
There are many calls to die() that do, or should, report
strerror(errno) to indicate how the syscall they guard failed.
Introduce a small helper function for this case.
Code by Jeff King and Alexander Potashev, name by Johannes Sixt.
Signed-off-by: Thomas Rast <trast@student.ethz.ch>
---
git-compat-util.h | 1 +
usage.c | 13 +++++++++++++
2 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/git-compat-util.h b/git-compat-util.h
index f25f7f1..0366cde 100644
--- a/git-compat-util.h
+++ b/git-compat-util.h
@@ -162,6 +162,7 @@
/* General helper functions */
extern void usage(const char *err) NORETURN;
extern void die(const char *err, ...) NORETURN __attribute__((format (printf, 1, 2)));
+extern void die_errno(const char *err, ...) NORETURN __attribute__((format (printf, 1, 2)));
extern int error(const char *err, ...) __attribute__((format (printf, 1, 2)));
extern void warning(const char *err, ...) __attribute__((format (printf, 1, 2)));
diff --git a/usage.c b/usage.c
index 820d09f..1819e0a 100644
--- a/usage.c
+++ b/usage.c
@@ -60,6 +60,19 @@ void die(const char *err, ...)
va_end(params);
}
+void die_errno(const char *err, ...)
+{
+ va_list params;
+ char msg[1024];
+
+ va_start(params, err);
+
+ vsnprintf(msg, sizeof(msg), err, params);
+ die("%s: %s", msg, strerror(errno));
+
+ va_end(params);
+}
+
int error(const char *err, ...)
{
va_list params;
--
1.6.3.2.288.g40844
next prev parent reply other threads:[~2009-06-06 14:45 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-02 21:34 [PATCH] add strerror(errno) to die() calls where applicable Thomas Rast
2009-06-03 1:55 ` Jeff King
[not found] ` <2325a7950906031855t1977448lbb1c8aa671c72f3d@mail.gmail.com>
2009-06-04 1:58 ` Alexander Potashev
2009-06-04 20:32 ` Jeff King
2009-06-04 2:05 ` [PATCH] diesys calls die and also reports strerror(errno) Alexander Potashev
2009-06-04 20:50 ` Jeff King
2009-06-04 21:13 ` Junio C Hamano
2009-06-05 6:25 ` Johannes Sixt
2009-06-05 7:12 ` Junio C Hamano
2009-06-06 22:09 ` Jeff King
2009-06-06 13:09 ` [PATCH] add strerror(errno) to die() calls where applicable Thomas Rast
2009-06-06 14:44 ` [PATCH v2 0/3] Thomas Rast <trast@student.ethz.ch> Thomas Rast
2009-06-08 21:02 ` [PATCH v3 0/3] die_errno() Thomas Rast
2009-06-27 15:58 ` [PATCH v4 0/4] die_errno() Thomas Rast
2009-06-27 15:58 ` [PATCH v4 1/4] Introduce die_errno() that appends strerror(errno) to die() Thomas Rast
2009-06-27 15:58 ` [PATCH v4 2/4] die_errno(): double % in strerror() output just in case Thomas Rast
2009-06-27 15:58 ` [PATCH v4 3/4] Convert existing die(..., strerror(errno)) to die_errno() Thomas Rast
2009-06-27 15:58 ` [PATCH v4 4/4] Use die_errno() instead of die() when checking syscalls Thomas Rast
2009-06-27 18:38 ` [PATCH v4 0/4] die_errno() Junio C Hamano
2009-06-08 21:02 ` [PATCH v3 1/3] Introduce die_errno() that appends strerror(errno) to die() Thomas Rast
2009-06-08 22:07 ` Jeff King
2009-06-09 8:22 ` Thomas Rast
2009-06-09 8:53 ` Jeff King
2009-06-09 9:29 ` Andreas Ericsson
2009-06-08 21:02 ` [PATCH v3 2/3] Convert existing die(..., strerror(errno)) to die_errno() Thomas Rast
2009-06-08 21:02 ` [PATCH v3 3/3] Use die_errno() instead of die() when checking syscalls Thomas Rast
2009-06-06 14:44 ` Thomas Rast [this message]
2009-06-06 20:36 ` [PATCH v2 1/3] Introduce die_errno() that appends strerror(errno) to die() Johannes Sixt
2009-06-06 20:56 ` Thomas Rast
2009-06-06 21:17 ` Johannes Sixt
2009-06-06 22:47 ` Jeff King
2009-06-06 22:13 ` Jeff King
2009-06-07 11:12 ` Alexander Potashev
2009-06-07 16:57 ` Junio C Hamano
2009-06-08 12:36 ` Jeff King
2009-06-08 15:35 ` Alexander Potashev
2009-06-08 22:04 ` Jeff King
2009-06-06 14:44 ` [PATCH v2 2/3] Convert existing die(..., strerror(errno)) to die_errno() Thomas Rast
2009-06-06 20:31 ` Johannes Sixt
2009-06-06 14:44 ` [PATCH v2 3/3] Use die_errno() instead of die() when checking syscalls Thomas Rast
2009-06-06 21:02 ` Johannes Sixt
2009-06-06 22:27 ` Thomas Rast
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3672f22723a4c14c4a6d67278e9865424c0c68dc.1244299302.git.trast@student.ethz.ch \
--to=trast@student.ethz.ch \
--cc=aspotashev@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).