From: Thomas Rast <trast@student.ethz.ch>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] add strerror(errno) to die() calls where applicable
Date: Sat, 6 Jun 2009 15:09:10 +0200 [thread overview]
Message-ID: <200906061509.15870.trast@student.ethz.ch> (raw)
In-Reply-To: <20090603015503.GA14166@coredump.intra.peff.net>
[-- Attachment #1: Type: text/plain, Size: 2854 bytes --]
Sorry for not getting around to this again all week. I'll try to
reroll later today...
Jeff King wrote:
> 1. How did you determine the set of callsites? Did you check that each
> non-syscall function always sets errno? Are there are functions
> which are setting errno which could also be included?
Basically by 'git grep die | grep -v errno' and then looking at the
code immediately before the die(). Rather tedious, but I couldn't see
an obvious way to automate the task.
As for the non-syscall functions, at first I had a longer list but I
eventually settled with the ones mentioned, but I decided it was too
risky and just stuck with those that are very clear:
> On Tue, Jun 02, 2009 at 11:34:33PM +0200, Thomas Rast wrote:
> > odb_pack_keep
Tries open() in two ways, but can only return <0 by passing the return
value of the second.
> > read_ancestry
Only returns -1 if fopen() returned NULL.
> > read_in_full
Only returns <=0 if xread() returned <=0, which in turn only happens
if read() returned <0.
> > strbuf_read
Returns -1 if xread() did so.
> > strbuf_read_file
Returns -1 if open() or strbuf_read() failed.
> > strbuf_readlink
Returns -1 if readlink() failed. (The other option, that the buffer
was still too small at STRBUF_MAXLINK, would imply that readlink()
wanted to return more than PATH_MAX chars.)
> > write_buffer
I'll drop this one, I missed that it actually does its own errno
reporting already. (Other than that it's just a thin wrapper around
write_in_full.)
> > write_in_full
Symmetric to read_in_full: only returns <=0 if xwrite() did, which in
turn only happens if write() returned <0.
There were lots of cases that aren't quite as clear-cut. For example,
there are many call sites where the index is written out that look
like
if (write_cache(fd, active_cache, active_nr) ||
close_lock_file(&index_lock))
die("unable to write new_index file");
Dealing with those will be somewhat more complicated, as the error
case is not all that clearly defined. But at least at a quick glance,
write_cache does not even indicate what file it failed to write.
> 2. Extra error conditions may leak information about the filesystem to
> people feeding bogus paths to upload-pack. I didn't see anything
> obvious in your patch that would cause this, but it is something to
> consider.
Good point.
> > - die("closing file %s: %s", path, strerror(errno));
> > + die("closing file '%s': %s", path, strerror(errno));
>
> This one is actually just a style change, though I think it is
> worthwhile (and there are a few others like it).
Yes, as I was already going through the calls I thought some
consistency would be nice.
--
Thomas Rast
trast@{inf,student}.ethz.ch
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2009-06-06 13:09 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-02 21:34 [PATCH] add strerror(errno) to die() calls where applicable Thomas Rast
2009-06-03 1:55 ` Jeff King
[not found] ` <2325a7950906031855t1977448lbb1c8aa671c72f3d@mail.gmail.com>
2009-06-04 1:58 ` Alexander Potashev
2009-06-04 20:32 ` Jeff King
2009-06-04 2:05 ` [PATCH] diesys calls die and also reports strerror(errno) Alexander Potashev
2009-06-04 20:50 ` Jeff King
2009-06-04 21:13 ` Junio C Hamano
2009-06-05 6:25 ` Johannes Sixt
2009-06-05 7:12 ` Junio C Hamano
2009-06-06 22:09 ` Jeff King
2009-06-06 13:09 ` Thomas Rast [this message]
2009-06-06 14:44 ` [PATCH v2 0/3] Thomas Rast <trast@student.ethz.ch> Thomas Rast
2009-06-08 21:02 ` [PATCH v3 0/3] die_errno() Thomas Rast
2009-06-27 15:58 ` [PATCH v4 0/4] die_errno() Thomas Rast
2009-06-27 15:58 ` [PATCH v4 1/4] Introduce die_errno() that appends strerror(errno) to die() Thomas Rast
2009-06-27 15:58 ` [PATCH v4 2/4] die_errno(): double % in strerror() output just in case Thomas Rast
2009-06-27 15:58 ` [PATCH v4 3/4] Convert existing die(..., strerror(errno)) to die_errno() Thomas Rast
2009-06-27 15:58 ` [PATCH v4 4/4] Use die_errno() instead of die() when checking syscalls Thomas Rast
2009-06-27 18:38 ` [PATCH v4 0/4] die_errno() Junio C Hamano
2009-06-08 21:02 ` [PATCH v3 1/3] Introduce die_errno() that appends strerror(errno) to die() Thomas Rast
2009-06-08 22:07 ` Jeff King
2009-06-09 8:22 ` Thomas Rast
2009-06-09 8:53 ` Jeff King
2009-06-09 9:29 ` Andreas Ericsson
2009-06-08 21:02 ` [PATCH v3 2/3] Convert existing die(..., strerror(errno)) to die_errno() Thomas Rast
2009-06-08 21:02 ` [PATCH v3 3/3] Use die_errno() instead of die() when checking syscalls Thomas Rast
2009-06-06 14:44 ` [PATCH v2 1/3] Introduce die_errno() that appends strerror(errno) to die() Thomas Rast
2009-06-06 20:36 ` Johannes Sixt
2009-06-06 20:56 ` Thomas Rast
2009-06-06 21:17 ` Johannes Sixt
2009-06-06 22:47 ` Jeff King
2009-06-06 22:13 ` Jeff King
2009-06-07 11:12 ` Alexander Potashev
2009-06-07 16:57 ` Junio C Hamano
2009-06-08 12:36 ` Jeff King
2009-06-08 15:35 ` Alexander Potashev
2009-06-08 22:04 ` Jeff King
2009-06-06 14:44 ` [PATCH v2 2/3] Convert existing die(..., strerror(errno)) to die_errno() Thomas Rast
2009-06-06 20:31 ` Johannes Sixt
2009-06-06 14:44 ` [PATCH v2 3/3] Use die_errno() instead of die() when checking syscalls Thomas Rast
2009-06-06 21:02 ` Johannes Sixt
2009-06-06 22:27 ` Thomas Rast
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906061509.15870.trast@student.ethz.ch \
--to=trast@student.ethz.ch \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).