From: Andrew Keller <andrew@kellerfarm.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Git List" <git@vger.kernel.org>
Subject: Re: Borrowing objects from nearby repositories
Date: Wed, 26 Mar 2014 09:36:09 -0400 [thread overview]
Message-ID: <3533946C-DE97-4214-9B55-F5B788DDD952@kellerfarm.com> (raw)
In-Reply-To: <xmqqvbv1kjoc.fsf@gitster.dls.corp.google.com>
On Mar 25, 2014, at 6:17 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Junio C Hamano <gitster@pobox.com> writes:
>
>> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>>
>>>> 1) Introduce '--borrow' to `git-fetch`. This would behave similarly
>>> to '--reference', except that it operates on a temporary basis, and
>>> does not assume that the reference repository will exist after the
>>> operation completes, so any used objects are copied into the local
>>> objects database. In theory, this mechanism would be distinct from
>>> --reference', so if both are used, some objects would be copied, and
>>> some objects would be accessible via a reference repository referenced
>>> by the alternates file.
>>>
>>> Isn't this the same as git clone --reference <path> --no-hardlinks
>>> <url> ?
>>>
>>> Also without --no-hardlinks we're not assuming that the other repo
>>> doesn't go away (you could rm-rf it), just that the files won't be
>>> *modified*, which Git won't do, but you could manually do with other
>>> tools, so the default is to hardlink.
>>
>> I think that the standard practice with the existing toolset is to
>> clone with reference and then repack. That is:
>>
>> $ git clone --reference <borrowee> git://over/there mine
>> $ cd mine
>> $ git repack -a -d
>>
>> And then you can try this:
>>
>> $ mv .git/objects/info/alternates .git/objects/info/alternates.disabled
>> $ git fsck
>>
>> to make sure that you are no longer borrowing anything from the
>> borrowee. Once you are satisfied, you can remove the saved-away
>> alternates.disabled file.
>
> Oh, I forgot to say that I am not opposed if somebody wants to teach
> "git clone" a new option to copy its objects from two places,
> (hopefully) the majority from near-by reference repository and the
> remainder over the network, without permanently relying on the
> former via the alternates mechanism. The implementation of such a
> feature could even literally be "clone with reference first and then
> repack" at least initially but even in the final version.
That was actually one of my first ideas - adding some sort of '--auto-repack' option to git-clone. It's a relatively small change, and would work. However, keeping in mind my end goal of automating the feature to the point where you could run simply 'git clone <url>', an '--auto-repack' option is more difficult to undo. You would need a new parameter to disable the automatic adding of reference repositories, and a new parameter to undo '--auto-repack', and you'd have to remember to actually undo both of those settings.
In contrast, if the new feature was '--borrow', and the evolution of the feature was a global configuration 'fetch.autoBorrow', then to turn it off temporarily, one only needs a single new parameter '--no-auto-borrow'. I think this is a cleaner approach than the former, although much more work.
Thanks,
- Andrew Keller
next prev parent reply other threads:[~2014-03-26 13:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-12 3:37 Borrowing objects from nearby repositories Andrew Keller
2014-03-23 18:04 ` Phil Hord
2014-03-24 21:21 ` Ævar Arnfjörð Bjarmason
2014-03-25 13:13 ` Andrew Keller
2014-03-25 17:02 ` Junio C Hamano
2014-03-25 22:17 ` Junio C Hamano
2014-03-26 13:36 ` Andrew Keller [this message]
2014-03-26 17:29 ` Junio C Hamano
2014-03-28 14:52 ` Andrew Keller
2014-03-28 17:02 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3533946C-DE97-4214-9B55-F5B788DDD952@kellerfarm.com \
--to=andrew@kellerfarm.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).