From: Johannes Sixt <j6t@kdbg.org>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Stefan Beller <sbeller@google.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH/RFC] git-post: the opposite of git-cherry-pick
Date: Sun, 15 Oct 2017 17:09:32 +0200 [thread overview]
Message-ID: <33f7d379-126d-e27e-7dbf-616f5dfbc98a@kdbg.org> (raw)
In-Reply-To: <87wp3zs4la.fsf@evledraar.booking.com>
Am 13.10.2017 um 12:51 schrieb Ævar Arnfjörð Bjarmason:
> On Thu, Oct 05 2017, Johannes Sixt jotted:
>> Am 05.10.2017 um 21:33 schrieb Stefan Beller:
>>> * Is it a good design choice to have a different command, just because the
>>> target branch is [not] checked out?
>>
>> I would not want to make it a sub-mode of cherry-pick, if that is what
>> you mean, because "cherry picking" is about getting something, not
>> giving something away.
>
> It occurs to me that a better long-term UI design might be to make
> git-{cherry-pick,pick) some sort of submodes for git-commit.
I don't quite agree. To commit an index state that is derived from a
worktree state is such a common and important operation that it deserves
to be its own command. Adding different modi operandi would make it
confusing.
> Right now git-commit picks the current index for committing, but "use a
> patch as the source instead" could be a submode.
>
> Right now it commits that change on top of your checked out commit, but
> "other non-checked-out target commit" could be a mode instead,
> i.e. exposing more of the power of the underlying git-commit-tree.
This is worth discussing, though not my preference. The picture to "pick
cherries" has become quite common, and now that we use it for the name
of the command, "cherry-pick", the direction of flow is quite obvious
and strongly implied: from somewhere else to me (and not to somebody else).
> [Not entirely serious]. Well if cherry-picking is taking a thing and
> eating it here, maybe git-cherry-puke takes an already digested thing
> and "throws" it elsewhere ?:)
>
> It's a silly name but it's somewhat symmetric :)
One of the decisions to be made is whether to begin the new command with
"git-cherry-" or not, because it introduces a new abiguity for command
line completion.
-- Hannes
next prev parent reply other threads:[~2017-10-15 15:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-05 19:13 [PATCH/RFC] git-post: the opposite of git-cherry-pick Johannes Sixt
2017-10-05 19:33 ` Stefan Beller
2017-10-05 21:22 ` Johannes Sixt
2017-10-13 10:51 ` Ævar Arnfjörð Bjarmason
2017-10-15 15:09 ` Johannes Sixt [this message]
2017-10-16 23:01 ` Rafael Ascensao
2017-10-17 17:30 ` Johannes Sixt
2017-10-17 21:15 ` Igor Djordjevic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33f7d379-126d-e27e-7dbf-616f5dfbc98a@kdbg.org \
--to=j6t@kdbg.org \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).