From: Thomas Braun <firstname.lastname@example.org> To: Jeff King <email@example.com>, firstname.lastname@example.org Subject: Re: [PATCH 0/5] handling 4GB .idx files Date: Sun, 15 Nov 2020 15:43:39 +0100 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <20201113050631.GA744608@coredump.intra.peff.net> On 13.11.2020 06:06, Jeff King wrote: > I recently ran into a case where Git could not read the pack it had > produced via running "git repack". The culprit turned out to be an .idx > file which crossed the 4GB barrier (in bytes, not number of objects). > This series fixes the problems I saw, along with similar ones I couldn't > trigger in practice, and protects the .idx loading code against integer > overflows that would fool the size checks. Would it be feasible to have a test case for this large index case? This should very certainly have an EXPENSIVE tag, or might even not yet work on windows. But hopefully someday I'll find some more time to push large object support on windows forward, and these kind of tests would really help then.
next prev parent reply other threads:[~2020-11-15 14:44 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-13 5:06 Jeff King 2020-11-13 5:06 ` [PATCH 1/5] compute pack .idx byte offsets using size_t Jeff King 2020-11-13 5:07 ` [PATCH 2/5] use size_t to store pack .idx byte offsets Jeff King 2020-11-13 5:07 ` [PATCH 3/5] fsck: correctly compute checksums on idx files larger than 4GB Jeff King 2020-11-13 5:07 ` [PATCH 4/5] block-sha1: take a size_t length parameter Jeff King 2020-11-13 5:07 ` [PATCH 5/5] packfile: detect overflow in .idx file size checks Jeff King 2020-11-13 11:02 ` Johannes Schindelin 2020-11-15 14:43 ` Thomas Braun [this message] 2020-11-16 4:10 ` [PATCH 0/5] handling 4GB .idx files Jeff King 2020-11-16 13:30 ` Derrick Stolee 2020-11-16 23:49 ` Jeff King 2020-11-30 22:57 ` Thomas Braun 2020-12-01 11:23 ` Jeff King 2020-12-01 11:39 ` t7900's new expensive test Jeff King 2020-12-01 20:55 ` Derrick Stolee 2020-12-02 2:47 ` [PATCH] t7900: speed up " Jeff King 2020-12-03 15:23 ` Derrick Stolee 2020-12-01 18:27 ` [PATCH 0/5] handling 4GB .idx files Taylor Blau 2020-12-02 13:12 ` Jeff King
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH 0/5] handling 4GB .idx files' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).