* [PATCH] t3008: find test-tool through path lookup
@ 2019-12-22 15:03 Johannes Sixt
2020-01-01 22:19 ` Johannes Schindelin
0 siblings, 1 reply; 2+ messages in thread
From: Johannes Sixt @ 2019-12-22 15:03 UTC (permalink / raw)
To: Git Mailing List
Do not use $GIT_BUILD_DIR without quotes; it may contain spaces and be
split into fields. But it is not necessary to access test-tool with an
absolute path in the first place as it can be found via path lookup.
Remove the explicit path.
Signed-off-by: Johannes Sixt <j6t@kdbg.org>
---
Found this today coincidentally when I happened to look at the terminal
with test output at the right time and saw a suspicous error message
that included just one half of the build directory path.
-- Hannes
t/t3008-ls-files-lazy-init-name-hash.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t3008-ls-files-lazy-init-name-hash.sh b/t/t3008-ls-files-lazy-init-name-hash.sh
index 64f047332b..85f3704958 100755
--- a/t/t3008-ls-files-lazy-init-name-hash.sh
+++ b/t/t3008-ls-files-lazy-init-name-hash.sh
@@ -4,7 +4,7 @@ test_description='Test the lazy init name hash with various folder structures'
. ./test-lib.sh
-if test 1 -eq $($GIT_BUILD_DIR/t/helper/test-tool online-cpus)
+if test 1 -eq $(test-tool online-cpus)
then
skip_all='skipping lazy-init tests, single cpu'
test_done
--
2.24.1.524.gae569673ff
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] t3008: find test-tool through path lookup
2019-12-22 15:03 [PATCH] t3008: find test-tool through path lookup Johannes Sixt
@ 2020-01-01 22:19 ` Johannes Schindelin
0 siblings, 0 replies; 2+ messages in thread
From: Johannes Schindelin @ 2020-01-01 22:19 UTC (permalink / raw)
To: Johannes Sixt; +Cc: Git Mailing List
Hi Hannes,
On Sun, 22 Dec 2019, Johannes Sixt wrote:
> Do not use $GIT_BUILD_DIR without quotes; it may contain spaces and be
> split into fields. But it is not necessary to access test-tool with an
> absolute path in the first place as it can be found via path lookup.
> Remove the explicit path.
>
> Signed-off-by: Johannes Sixt <j6t@kdbg.org>
> ---
> Found this today coincidentally when I happened to look at the terminal
> with test output at the right time and saw a suspicous error message
> that included just one half of the build directory path.
This patch looks good to me.
Thanks,
Dscho
>
> -- Hannes
>
> t/t3008-ls-files-lazy-init-name-hash.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/t3008-ls-files-lazy-init-name-hash.sh b/t/t3008-ls-files-lazy-init-name-hash.sh
> index 64f047332b..85f3704958 100755
> --- a/t/t3008-ls-files-lazy-init-name-hash.sh
> +++ b/t/t3008-ls-files-lazy-init-name-hash.sh
> @@ -4,7 +4,7 @@ test_description='Test the lazy init name hash with various folder structures'
>
> . ./test-lib.sh
>
> -if test 1 -eq $($GIT_BUILD_DIR/t/helper/test-tool online-cpus)
> +if test 1 -eq $(test-tool online-cpus)
> then
> skip_all='skipping lazy-init tests, single cpu'
> test_done
> --
> 2.24.1.524.gae569673ff
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-01 22:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-22 15:03 [PATCH] t3008: find test-tool through path lookup Johannes Sixt
2020-01-01 22:19 ` Johannes Schindelin
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).