From: Florian Achleitner <florian.achleitner2.6.31@gmail.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org,
Florian Achleitner <florian.achleitner.2.6.31@gmail.com>
Subject: Re: [PATCH 1/3] remote-testsvn: fix unitialized variable
Date: Sat, 15 Dec 2012 11:29:34 +0100 [thread overview]
Message-ID: <2763981.Tc7o2WorU3@flomedio> (raw)
In-Reply-To: <20121214221144.GA19677@sigill.intra.peff.net>
On Friday 14 December 2012 17:11:44 Jeff King wrote:
> [...]
> We can fix it by returning "-1" when no note is found (so on
> a zero return, we always found a valid value).
Good fix. Parsing of the note now always fails if the note doesn't contain the
expected string, as it should.
>
> Signed-off-by: Jeff King <peff@peff.net>
> ---
> I think this is the right fix, but I am not too familiar with this code,
> so I might be missing a case where a missing "Revision-number" should
> provide some sentinel value (like "0") instead of returning an error. In
> fact, of the two callsites, one already does such a zero-initialization.
>
> remote-testsvn.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/remote-testsvn.c b/remote-testsvn.c
> index 51fba05..5ddf11c 100644
> --- a/remote-testsvn.c
> +++ b/remote-testsvn.c
> @@ -90,10 +90,12 @@ static int parse_rev_note(const char *msg, struct
> rev_note *res) if (end == value || i < 0 || i > UINT32_MAX)
> return -1;
> res->rev_nr = i;
> + return 0;
> }
> msg += len + 1;
> }
> - return 0;
> + /* didn't find it */
> + return -1;
> }
>
> static int note2mark_cb(const unsigned char *object_sha1,
next prev parent reply other threads:[~2012-12-15 11:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-14 22:09 [PATCH/RFC 0/3] compiling git with gcc -O3 -Wuninitialized Jeff King
2012-12-14 22:11 ` [PATCH 1/3] remote-testsvn: fix unitialized variable Jeff King
2012-12-15 10:29 ` Florian Achleitner [this message]
2012-12-14 22:12 ` [PATCH/RFC 2/3] inline error functions with constant returns Jeff King
2012-12-14 22:13 ` [PATCH/RFC 3/3] silence some -Wuninitialized warnings around errors Jeff King
2012-12-15 3:07 ` [PATCH/RFC 0/3] compiling git with gcc -O3 -Wuninitialized Nguyen Thai Ngoc Duy
2012-12-15 10:09 ` Jeff King
2012-12-15 10:49 ` Johannes Sixt
2012-12-15 11:09 ` Jeff King
2012-12-15 17:36 ` [PATCH/RFCv2 0/2] " Jeff King
2012-12-15 17:37 ` [PATCH 1/2] make error()'s constant return value more visible Jeff King
2012-12-15 17:42 ` [PATCH 2/2] silence some -Wuninitialized false positives Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2763981.Tc7o2WorU3@flomedio \
--to=florian.achleitner2.6.31@gmail.com \
--cc=florian.achleitner.2.6.31@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).