From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Alex Henrie <alexhenrie24@gmail.com>,
git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH resend] graph: improve grammar of "invalid color" error message
Date: Sun, 13 Jun 2021 09:21:33 +0700 [thread overview]
Message-ID: <21c43663-9d2a-0173-bd5c-4e2c9f95bc05@gmail.com> (raw)
In-Reply-To: <20210612184144.6894-1-alexhenrie24@gmail.com>
Hi,
On 13/06/21 01.41, Alex Henrie wrote:
> Without the "d", it sounds like a command, not an error, and is liable
> to be translated incorrectly.
>
s/liable/prone/
> Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
> ---
> Resending to make sure that this patch isn't forgotten.
> ---
> graph.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/graph.c b/graph.c
> index c128ad0cce..e3828eb8f2 100644
> --- a/graph.c
> +++ b/graph.c
> @@ -95,7 +95,7 @@ static void parse_graph_colors_config(struct strvec *colors, const char *string)
> if (!color_parse_mem(start, comma - start, color))
> strvec_push(colors, color);
> else
> - warning(_("ignore invalid color '%.*s' in log.graphColors"),
> + warning(_("ignored invalid color '%.*s' in log.graphColors"),
> (int)(comma - start), start);
> start = comma + 1;
> }
>
Why did you resend the patch?
--
An old man doll... just what I always wanted! - Clara
next prev parent reply other threads:[~2021-06-13 2:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-12 18:41 [PATCH resend] graph: improve grammar of "invalid color" error message Alex Henrie
2021-06-13 2:21 ` Bagas Sanjaya [this message]
2021-06-15 3:55 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21c43663-9d2a-0173-bd5c-4e2c9f95bc05@gmail.com \
--to=bagasdotme@gmail.com \
--cc=alexhenrie24@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).