* [PATCH resend] graph: improve grammar of "invalid color" error message
@ 2021-06-12 18:41 Alex Henrie
2021-06-13 2:21 ` Bagas Sanjaya
2021-06-15 3:55 ` Junio C Hamano
0 siblings, 2 replies; 3+ messages in thread
From: Alex Henrie @ 2021-06-12 18:41 UTC (permalink / raw)
To: git, gitster; +Cc: Alex Henrie
Without the "d", it sounds like a command, not an error, and is liable
to be translated incorrectly.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
---
Resending to make sure that this patch isn't forgotten.
---
graph.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/graph.c b/graph.c
index c128ad0cce..e3828eb8f2 100644
--- a/graph.c
+++ b/graph.c
@@ -95,7 +95,7 @@ static void parse_graph_colors_config(struct strvec *colors, const char *string)
if (!color_parse_mem(start, comma - start, color))
strvec_push(colors, color);
else
- warning(_("ignore invalid color '%.*s' in log.graphColors"),
+ warning(_("ignored invalid color '%.*s' in log.graphColors"),
(int)(comma - start), start);
start = comma + 1;
}
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH resend] graph: improve grammar of "invalid color" error message
2021-06-12 18:41 [PATCH resend] graph: improve grammar of "invalid color" error message Alex Henrie
@ 2021-06-13 2:21 ` Bagas Sanjaya
2021-06-15 3:55 ` Junio C Hamano
1 sibling, 0 replies; 3+ messages in thread
From: Bagas Sanjaya @ 2021-06-13 2:21 UTC (permalink / raw)
To: Alex Henrie, git, gitster
Hi,
On 13/06/21 01.41, Alex Henrie wrote:
> Without the "d", it sounds like a command, not an error, and is liable
> to be translated incorrectly.
>
s/liable/prone/
> Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
> ---
> Resending to make sure that this patch isn't forgotten.
> ---
> graph.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/graph.c b/graph.c
> index c128ad0cce..e3828eb8f2 100644
> --- a/graph.c
> +++ b/graph.c
> @@ -95,7 +95,7 @@ static void parse_graph_colors_config(struct strvec *colors, const char *string)
> if (!color_parse_mem(start, comma - start, color))
> strvec_push(colors, color);
> else
> - warning(_("ignore invalid color '%.*s' in log.graphColors"),
> + warning(_("ignored invalid color '%.*s' in log.graphColors"),
> (int)(comma - start), start);
> start = comma + 1;
> }
>
Why did you resend the patch?
--
An old man doll... just what I always wanted! - Clara
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH resend] graph: improve grammar of "invalid color" error message
2021-06-12 18:41 [PATCH resend] graph: improve grammar of "invalid color" error message Alex Henrie
2021-06-13 2:21 ` Bagas Sanjaya
@ 2021-06-15 3:55 ` Junio C Hamano
1 sibling, 0 replies; 3+ messages in thread
From: Junio C Hamano @ 2021-06-15 3:55 UTC (permalink / raw)
To: Alex Henrie; +Cc: git
Alex Henrie <alexhenrie24@gmail.com> writes:
> Without the "d", it sounds like a command, not an error, and is liable
> to be translated incorrectly.
>
> Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
> ---
> Resending to make sure that this patch isn't forgotten.
Thanks, will queue.
> ---
> graph.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/graph.c b/graph.c
> index c128ad0cce..e3828eb8f2 100644
> --- a/graph.c
> +++ b/graph.c
> @@ -95,7 +95,7 @@ static void parse_graph_colors_config(struct strvec *colors, const char *string)
> if (!color_parse_mem(start, comma - start, color))
> strvec_push(colors, color);
> else
> - warning(_("ignore invalid color '%.*s' in log.graphColors"),
> + warning(_("ignored invalid color '%.*s' in log.graphColors"),
> (int)(comma - start), start);
> start = comma + 1;
> }
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-15 3:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-12 18:41 [PATCH resend] graph: improve grammar of "invalid color" error message Alex Henrie
2021-06-13 2:21 ` Bagas Sanjaya
2021-06-15 3:55 ` Junio C Hamano
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).