From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Taylor Blau <me@ttaylorr.com>
Subject: tb/plug-pack-bitmap-leaks (was: What's cooking in git.git (Oct 2021, #06; Mon, 25))
Date: Tue, 26 Oct 2021 14:13:44 +0200 [thread overview]
Message-ID: <211026.86tuh4yoa8.gmgdl@evledraar.gmail.com> (raw)
In-Reply-To: <xmqq5ytkzbt7.fsf@gitster.g>
On Mon, Oct 25 2021, Junio C Hamano wrote:
> * tb/plug-pack-bitmap-leaks (2021-10-21) 9 commits
> - pack-bitmap.c: more aggressively free in free_bitmap_index()
> - pack-bitmap.c: don't leak type-level bitmaps
> - pack-bitmap.c: avoid leaking via midx_bitmap_filename()
> - builtin/multi-pack-index.c: don't leak concatenated options
> - builtin/repack.c: avoid leaking child arguments
> - builtin/pack-objects.c: don't leak memory via arguments
> - t/helper/test-read-midx.c: free MIDX within read_midx_file()
> - midx.c: don't leak MIDX from verify_midx_file
> - midx.c: clean up chunkfile after reading the MIDX
>
> Leakfix.
>
> Will merge to 'next'?
These patches all look good to me.
I see you peeled off 10/11 and 11/11 from Taylor's submitted
patches. The 10/11 re-submitted a patch that's in my
ab/only-single-progress-at-once, and I really preferred 11/11 not going
in, and instead suggested [1].
But since you've peeled off those two (I wouldn't have 10/11 at all) I
think this is definitely ready for 'next'.
1. https://lore.kernel.org/git/patch-1.1-9190f3c128f-20211022T102725Z-avarab@gmail.com/
next prev parent reply other threads:[~2021-10-26 12:16 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-26 3:48 What's cooking in git.git (Oct 2021, #06; Mon, 25) Junio C Hamano
2021-10-26 5:25 ` Jeff King
2021-10-27 17:42 ` Junio C Hamano
2021-10-31 18:36 ` Kaartic Sivaraam
2021-11-01 4:04 ` Jeff King
2021-10-26 11:02 ` pre-v2.34.0-rc0 regressions: t7900-maintenance.sh broken due to 'systemd-analyze' (was: What's cooking in git.git (Oct 2021, #06; Mon, 25)) Ævar Arnfjörð Bjarmason
2021-10-26 15:34 ` Ævar Arnfjörð Bjarmason
2021-10-26 18:43 ` Eric Sunshine
2021-11-02 14:24 ` [PATCH] maintenance tests: fix systemd v2.34.0-rc* test regression Ævar Arnfjörð Bjarmason
2021-11-03 5:09 ` Eric Sunshine
2021-11-10 3:52 ` [PATCH v2] " Ævar Arnfjörð Bjarmason
2021-11-10 13:36 ` Johannes Schindelin
2021-11-10 16:22 ` Ævar Arnfjörð Bjarmason
2021-11-11 17:45 ` Junio C Hamano
2021-10-26 11:15 ` pre-v2.34.0-rc0 regressions: 'git log' has a noisy iconv() warning (was: What's cooking in git.git (Oct 2021, #06; Mon, 25)) Ævar Arnfjörð Bjarmason
2021-10-27 11:14 ` Jeff King
2021-10-27 18:04 ` pre-v2.34.0-rc0 regressions: 'git log' has a noisy iconv() warning Junio C Hamano
2021-10-28 17:30 ` Jeff King
2021-10-28 19:02 ` Junio C Hamano
2021-10-28 19:17 ` Jeff King
2021-10-26 12:13 ` Ævar Arnfjörð Bjarmason [this message]
2021-10-26 21:04 ` tb/plug-pack-bitmap-leaks (was: What's cooking in git.git (Oct 2021, #06; Mon, 25)) Taylor Blau
2021-10-26 12:17 ` jc/branch-copy-doc " Ævar Arnfjörð Bjarmason
2021-10-26 12:42 ` What's cooking in git.git (Oct 2021, #06; Mon, 25) Derrick Stolee
2021-10-26 14:55 ` Ævar Arnfjörð Bjarmason
2021-10-26 17:27 ` Victoria Dye
2021-10-26 21:29 ` Junio C Hamano
2021-10-26 21:28 ` Junio C Hamano
2021-10-26 21:54 ` Derrick Stolee
2021-10-26 22:21 ` regression in ns/tmp-objdir and ns/batched-fsync Neeraj Singh
2021-10-27 19:17 ` What's cooking in git.git (Oct 2021, #06; Mon, 25) Martin Ågren
2021-10-28 0:06 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=211026.86tuh4yoa8.gmgdl@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).