From: Neeraj Singh <nksingh85@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Johannes.Schindelin@gmx.de
Subject: regression in ns/tmp-objdir and ns/batched-fsync
Date: Tue, 26 Oct 2021 15:21:46 -0700 [thread overview]
Message-ID: <20211026222146.GA16928@neerajsi-x1.localdomain> (raw)
In-Reply-To: <xmqq5ytkzbt7.fsf@gitster.g>
On Mon, Oct 25, 2021 at 08:48:04PM -0700, Junio C Hamano wrote:
> * ns/tmp-objdir (2021-10-04) 2 commits
> (merged to 'next' on 2021-10-23 at 358d376f61)
> + tmp-objdir: disable ref updates when replacing the primary odb
> + tmp-objdir: new API for creating temporary writable databases
> (this branch is used by ns/batched-fsync and ns/remerge-diff.)
>
> New interface into the tmp-objdir API to help in-core use of the
> quarantine feature.
>
> Will merge to 'master'.
>
--snip--
> * ns/batched-fsync (2021-10-08) 8 commits
> (merged to 'next' on 2021-10-25 at e45c907d41)
> + core.fsyncobjectfiles: performance tests for add and stash
> + core.fsyncobjectfiles: tests for batch mode
> + unpack-objects: use the bulk-checkin infrastructure
> + update-index: use the bulk-checkin infrastructure
> + core.fsyncobjectfiles: add windows support for batch mode
> + core.fsyncobjectfiles: batched disk flushes
> + bulk-checkin: rename 'state' variable and separate 'plugged' boolean
> + Merge branch 'ns/tmp-objdir' into ns/batched-fsync
> (this branch uses ns/tmp-objdir.)
>
> The "core.fsyncobjectfiles" configuration variable can now be set
> to "batch" for improved performance.
>
> Will merge to 'master'.
>
Hi Junio,
When DScho enabled batch fsync by default (for all platforms) in the git-for-windows tree, CI caught a regression. It came up through the heavy refactoring to use the tmp-objdir code.
The problem is related to setup_work_tree erasing the tmp_objdir "primary" odb. Please expect a incremental patch from me shortly against ns/tmp-objdir. It will need to be merged into ns/batched-fsync.
Thanks,
Neeraj
next prev parent reply other threads:[~2021-10-26 22:21 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-26 3:48 What's cooking in git.git (Oct 2021, #06; Mon, 25) Junio C Hamano
2021-10-26 5:25 ` Jeff King
2021-10-27 17:42 ` Junio C Hamano
2021-10-31 18:36 ` Kaartic Sivaraam
2021-11-01 4:04 ` Jeff King
2021-10-26 11:02 ` pre-v2.34.0-rc0 regressions: t7900-maintenance.sh broken due to 'systemd-analyze' (was: What's cooking in git.git (Oct 2021, #06; Mon, 25)) Ævar Arnfjörð Bjarmason
2021-10-26 15:34 ` Ævar Arnfjörð Bjarmason
2021-10-26 18:43 ` Eric Sunshine
2021-11-02 14:24 ` [PATCH] maintenance tests: fix systemd v2.34.0-rc* test regression Ævar Arnfjörð Bjarmason
2021-11-03 5:09 ` Eric Sunshine
2021-11-10 3:52 ` [PATCH v2] " Ævar Arnfjörð Bjarmason
2021-11-10 13:36 ` Johannes Schindelin
2021-11-10 16:22 ` Ævar Arnfjörð Bjarmason
2021-11-11 17:45 ` Junio C Hamano
2021-10-26 11:15 ` pre-v2.34.0-rc0 regressions: 'git log' has a noisy iconv() warning (was: What's cooking in git.git (Oct 2021, #06; Mon, 25)) Ævar Arnfjörð Bjarmason
2021-10-27 11:14 ` Jeff King
2021-10-27 18:04 ` pre-v2.34.0-rc0 regressions: 'git log' has a noisy iconv() warning Junio C Hamano
2021-10-28 17:30 ` Jeff King
2021-10-28 19:02 ` Junio C Hamano
2021-10-28 19:17 ` Jeff King
2021-10-26 12:13 ` tb/plug-pack-bitmap-leaks (was: What's cooking in git.git (Oct 2021, #06; Mon, 25)) Ævar Arnfjörð Bjarmason
2021-10-26 21:04 ` Taylor Blau
2021-10-26 12:17 ` jc/branch-copy-doc " Ævar Arnfjörð Bjarmason
2021-10-26 12:42 ` What's cooking in git.git (Oct 2021, #06; Mon, 25) Derrick Stolee
2021-10-26 14:55 ` Ævar Arnfjörð Bjarmason
2021-10-26 17:27 ` Victoria Dye
2021-10-26 21:29 ` Junio C Hamano
2021-10-26 21:28 ` Junio C Hamano
2021-10-26 21:54 ` Derrick Stolee
2021-10-26 22:21 ` Neeraj Singh [this message]
2021-10-27 19:17 ` Martin Ågren
2021-10-28 0:06 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211026222146.GA16928@neerajsi-x1.localdomain \
--to=nksingh85@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).