From: Jeff King <peff@peff.net>
To: phillip.wood@dunelm.org.uk
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Thomas Bock" <bockthom@cs.uni-saarland.de>,
"Derrick Stolee" <derrickstolee@github.com>,
git@vger.kernel.org, "René Scharfe" <l.s.r@web.de>
Subject: Re: [PATCH v3 3/4] parse_commit(): handle broken whitespace-only timestamp
Date: Thu, 27 Apr 2023 12:46:11 -0400 [thread overview]
Message-ID: <20230427164611.GA1976451@coredump.intra.peff.net> (raw)
In-Reply-To: <ad4f927f-607a-5391-ce50-a342d09934d6@gmail.com>
On Thu, Apr 27, 2023 at 12:55:26PM +0100, Phillip Wood wrote:
> On 27/04/2023 11:11, Phillip Wood wrote:
>
> > > + test_commit 1234567890 &&
> > > + git cat-file commit HEAD >commit.orig &&
> > > + sed "s/>.*/> /" <commit.orig >commit.munge &&
> > > + ws_commit=$(git hash-object --literally -w -t commit
> > > commit.munge) &&
> > > + sed "s/>.*/> $(printf "\013")/" <commit.orig >commit.munge &&
> >
> > Does the shell eat the '\v' when it trims trailing whitespace from the
> > command substitution (I can't remember the rules off the top of my
> > head)?
>
> Having looked it up, the shell trims newlines but not other whitespace so
> this should be fine.
Yep. I also wondered if some sed versions might complain. But it's
really not that much more exotic than a tab, so it's probably OK.
-Peff
next prev parent reply other threads:[~2023-04-27 16:46 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-14 11:37 Weird behavior of 'git log --before' or 'git log --date-order': Commits from 2011 are treated to be before 1980 Thomas Bock
2023-04-15 8:52 ` Jeff King
2023-04-15 8:59 ` Jeff King
2023-04-15 14:10 ` Kristoffer Haugsbakk
2023-04-17 5:40 ` Jeff King
2023-04-17 6:20 ` Kristoffer Haugsbakk
2023-04-17 7:41 ` Jeff King
2023-04-27 22:32 ` Kristoffer Haugsbakk
2023-04-17 9:51 ` Junio C Hamano
2023-04-18 4:12 ` Jeff King
2023-04-18 14:02 ` Derrick Stolee
2023-04-21 14:51 ` Thomas Bock
2023-04-22 13:41 ` [PATCH 0/3] fixing some parse_commit() timestamp corner cases Jeff King
2023-04-22 13:42 ` [PATCH 1/3] t4212: avoid putting git on left-hand side of pipe Jeff King
2023-04-22 13:47 ` [PATCH 2/3] parse_commit(): parse timestamp from end of line Jeff King
2023-04-24 17:05 ` Junio C Hamano
2023-04-25 5:23 ` Jeff King
2023-04-24 16:39 ` [PATCH 0/3] fixing some parse_commit() timestamp corner cases Junio C Hamano
2023-04-25 5:52 ` [PATCH v2 " Jeff King
2023-04-25 5:54 ` Jeff King
2023-04-25 5:54 ` [PATCH v2 1/4] t4212: avoid putting git on left-hand side of pipe Jeff King
2023-04-25 5:54 ` [PATCH v2 2/4] parse_commit(): parse timestamp from end of line Jeff King
2023-04-25 5:54 ` [PATCH v2 3/4] parse_commit(): handle broken whitespace-only timestamp Jeff King
2023-04-25 10:11 ` Phillip Wood
2023-04-25 16:06 ` Junio C Hamano
2023-04-26 11:36 ` Jeff King
2023-04-26 15:32 ` Junio C Hamano
2023-04-27 8:13 ` [PATCH v3 0/4] fixing some parse_commit() timestamp corner cases Jeff King
2023-04-27 8:14 ` [PATCH v3 1/4] t4212: avoid putting git on left-hand side of pipe Jeff King
2023-04-27 8:14 ` [PATCH v3 2/4] parse_commit(): parse timestamp from end of line Jeff King
2023-04-27 8:17 ` [PATCH v3 3/4] parse_commit(): handle broken whitespace-only timestamp Jeff King
2023-04-27 10:11 ` Phillip Wood
2023-04-27 11:55 ` Phillip Wood
2023-04-27 16:46 ` Jeff King [this message]
2023-04-27 16:20 ` Junio C Hamano
2023-04-27 16:55 ` Jeff King
2023-04-27 16:25 ` Junio C Hamano
2023-04-27 16:57 ` Jeff King
2023-04-27 8:17 ` [PATCH v3 4/4] parse_commit(): describe more date-parsing failure modes Jeff King
2023-04-27 8:18 ` [PATCH v3 0/4] fixing some parse_commit() timestamp corner cases Jeff King
2023-04-27 16:32 ` Junio C Hamano
2023-04-26 14:06 ` [PATCH v2 3/4] parse_commit(): handle broken whitespace-only timestamp Phillip Wood
2023-04-26 14:31 ` Andreas Schwab
2023-04-26 14:44 ` Phillip Wood
2023-04-25 5:55 ` [PATCH v2 4/4] parse_commit(): describe more date-parsing failure modes Jeff King
2023-04-22 13:52 ` Weird behavior of 'git log --before' or 'git log --date-order': Commits from 2011 are treated to be before 1980 Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230427164611.GA1976451@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=bockthom@cs.uni-saarland.de \
--cc=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
--cc=phillip.wood@dunelm.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).