From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 2D1671F452 for ; Thu, 27 Apr 2023 16:46:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244303AbjD0QqV (ORCPT ); Thu, 27 Apr 2023 12:46:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244192AbjD0QqR (ORCPT ); Thu, 27 Apr 2023 12:46:17 -0400 Received: from cloud.peff.net (cloud.peff.net [104.130.231.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9B674C12 for ; Thu, 27 Apr 2023 09:46:12 -0700 (PDT) Received: (qmail 23934 invoked by uid 109); 27 Apr 2023 16:46:12 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Thu, 27 Apr 2023 16:46:12 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 20877 invoked by uid 111); 27 Apr 2023 16:46:11 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Thu, 27 Apr 2023 12:46:11 -0400 Authentication-Results: peff.net; auth=none Date: Thu, 27 Apr 2023 12:46:11 -0400 From: Jeff King To: phillip.wood@dunelm.org.uk Cc: Junio C Hamano , Thomas Bock , Derrick Stolee , git@vger.kernel.org, =?utf-8?B?UmVuw6k=?= Scharfe Subject: Re: [PATCH v3 3/4] parse_commit(): handle broken whitespace-only timestamp Message-ID: <20230427164611.GA1976451@coredump.intra.peff.net> References: <20230427081330.GA1461786@coredump.intra.peff.net> <20230427081715.GA1478467@coredump.intra.peff.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Thu, Apr 27, 2023 at 12:55:26PM +0100, Phillip Wood wrote: > On 27/04/2023 11:11, Phillip Wood wrote: > > > > +    test_commit 1234567890 && > > > +    git cat-file commit HEAD >commit.orig && > > > +    sed "s/>.*/>    /" commit.munge && > > > +    ws_commit=$(git hash-object --literally -w -t commit > > > commit.munge) && > > > +    sed "s/>.*/>   $(printf "\013")/" commit.munge && > > > > Does the shell eat the '\v' when it trims trailing whitespace from the > > command substitution (I can't remember the rules off the top of my > > head)? > > Having looked it up, the shell trims newlines but not other whitespace so > this should be fine. Yep. I also wondered if some sed versions might complain. But it's really not that much more exotic than a tab, so it's probably OK. -Peff