From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Felipe Contreras" <felipe.contreras@gmail.com>,
git@vger.kernel.org, "Martin Ågren" <martin.agren@gmail.com>
Subject: Re: [PATCH] doc: asciidoc: remove custom header macro
Date: Thu, 6 Apr 2023 03:19:58 -0400 [thread overview]
Message-ID: <20230406071958.GB2143526@coredump.intra.peff.net> (raw)
In-Reply-To: <xmqq8rf5r66s.fsf@gitster.g>
On Wed, Apr 05, 2023 at 09:22:03PM -0700, Junio C Hamano wrote:
> Sounds like the proposed log message can use a bit more polishing to
> help future readers of "git log", then. But I think it is not
> required to be explicit about us leaving the asciidoctor side
> untouched to keep it working (in other words, we do not talk about
> things that we are not doing in our log message, unless it is so
> unnatural not to do them at the same time to warrant such an
> explanation).
Yes, I think the "is it unnatural" is a debatable point here. I'm OK
with the commit message as-is.
> Will queue with your Reviewed-by: in the morning.
Sounds good, thanks.
-Peff
next prev parent reply other threads:[~2023-04-06 7:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 22:15 [PATCH] doc: asciidoc: remove custom header macro Felipe Contreras
2023-04-06 3:57 ` Jeff King
2023-04-06 4:22 ` Junio C Hamano
2023-04-06 7:19 ` Jeff King [this message]
2023-04-06 8:34 ` Felipe Contreras
2023-04-06 6:18 ` Felipe Contreras
2023-04-06 7:19 ` Jeff King
2023-04-07 14:30 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230406071958.GB2143526@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=martin.agren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).