From: Jeff King <peff@peff.net>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>,
"Martin Ågren" <martin.agren@gmail.com>
Subject: Re: [PATCH] doc: asciidoc: remove custom header macro
Date: Thu, 6 Apr 2023 03:19:14 -0400 [thread overview]
Message-ID: <20230406071914.GA2143526@coredump.intra.peff.net> (raw)
In-Reply-To: <CAMP44s2u4tj7hUZHZ9H4qsJGp1a=Y=YUTBAxmSzftdfHX_HqwQ@mail.gmail.com>
On Thu, Apr 06, 2023 at 01:18:36AM -0500, Felipe Contreras wrote:
> > and even today still does not seem to handle manversion.
>
> Why do we need `manversion`?
>
> All that it's used for is in the DocBook Stylesheets to join the
> source name and the version, even its own documentation explains what
> it looks like in practice [3]:
>
> In practice, there are many pages that simply have a version number
> in the "source" field. So, it looks like what we have is a two-part
> field, Name Version
>
> So if we have `source="Git"`, and `version="2.4.0"`, we can just have
> `source="Git 2.40.0"`.
>
> Why do we have to split that information only for the DocBook
> Stylesheets to join it in?
I don't know of any particular reason why we couldn't put both in the
source field.
I had forgotten we discussed this 2 years ago.
> > Aside: If we think asciidoctor 1.5.7 is recent enough to rely on, then
> > we might want to simplify our hack to just output manversion.
>
> There is no need for any hack: we can just set the "mansource"
> attribute to "Git $(GIT_VERSION)", and everything will work correctly
> for both asciidoc and asciidoctor in all backends.
>
> Why do we insist on hacks for asciidoc.py/2007 and asciidoc|docbook5/2017?
>
> Especially when I sent the fix for *everything* in 2021 [4].
You say "insist" like somebody is arguing for it. It looks like the
series you linked got some review comments, and you followed-up. I
didn't carefully read the re-rolls (then or now), but the original
patches seem like a good direction to me.
Looking at the timing in the archive, I suspect that inter-personal
drama in other threads caused people not to read those re-rolls.
At any rate, I don't think any of that needs to hold up this patch,
which is not touching the asciidoctor side at all (I only wondered while
reviewing it what the implications might be).
-Peff
next prev parent reply other threads:[~2023-04-06 7:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 22:15 [PATCH] doc: asciidoc: remove custom header macro Felipe Contreras
2023-04-06 3:57 ` Jeff King
2023-04-06 4:22 ` Junio C Hamano
2023-04-06 7:19 ` Jeff King
2023-04-06 8:34 ` Felipe Contreras
2023-04-06 6:18 ` Felipe Contreras
2023-04-06 7:19 ` Jeff King [this message]
2023-04-07 14:30 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230406071914.GA2143526@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=martin.agren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).