From: "Torsten Bögershausen" <tboegi@web.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] MyFirstContribution: refrain from self-iterating too much
Date: Sun, 22 Jan 2023 08:11:57 +0100 [thread overview]
Message-ID: <20230122071156.367jwwt3d5txvkl4@tb-raspi4> (raw)
In-Reply-To: <xmqq3583uyk0.fsf@gitster.g>
On Sat, Jan 21, 2023 at 05:51:11PM -0800, Junio C Hamano wrote:
> Finding mistakes in and improving your own patches is a good idea,
> but doing so too quickly is being inconsiderate to reviewers who
> have just seen the initial iteration and taking their time to review
> it. Encourage new developers to perform such a self review before
> they send out their patches, not after.
>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---
> Documentation/MyFirstContribution.txt | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git c/Documentation/MyFirstContribution.txt w/Documentation/MyFirstContribution.txt
> index 7c9a037cc2..81dcaedf0c 100644
> --- c/Documentation/MyFirstContribution.txt
> +++ w/Documentation/MyFirstContribution.txt
> @@ -1136,6 +1136,26 @@ index 88f126184c..38da593a60 100644
> [[now-what]]
> == My Patch Got Emailed - Now What?
>
> +You should wait for your patch to be reviewed by other people in the
> +development community. While you are waiting, you may want to
> +re-read what you wrote in the patch you already have sent, as if you
> +are a reviewer who is helping you to improve your patch. But resist
> +the temptation to update the patch and send a new one, until other
> +people had enough time to digest your original patch and give you
> +their reviews. They may be taking time to give you a carefully
> +written review responses and haven't finished it yet. Bombarding
> +them with new versions before they have a chance to react to the
> +first iteration is being rude to them.
> +
> +Of course, you still may spot mistakes and rooms for improvements
> +after you sent your initial patch.
I can't resist the question: After outlining what not to do and why,
could there be a hint what to do ?
It may be, that the author justs spots a simple typo, or there may
be more heavier changes to be done.
Should the author just respond to her/his patch as a reviewer does ?
Like:
Ops, there is a "typax", I should have written "typo".
Or:
Re-reading my own stuff, I think that things could have been done
in a way like this....
Lets wait for more comments before I send out a new version.
>+ Learn from that experience to
> +make sure that you will do such a self-review _before_ sending your
> +patches next time. You do not have to send your patches immediately
> +once you finished writing them. It is not a race. Take your time
> +to self-review them, sleep on them, improve them before sending them
> +out, and do not allow you to send them before you are reasonably
> +sure that you won't find more mistakes in them yourself.
> +
> [[reviewing]]
> === Responding to Reviews
>
next prev parent reply other threads:[~2023-01-22 7:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-22 1:51 [PATCH] MyFirstContribution: refrain from self-iterating too much Junio C Hamano
2023-01-22 7:11 ` Torsten Bögershausen [this message]
2023-01-22 16:01 ` Junio C Hamano
2023-01-22 17:14 ` Junio C Hamano
2023-01-23 4:18 ` [PATCH v2] " Junio C Hamano
2023-01-23 17:58 ` Torsten Bögershausen
2023-07-19 17:04 ` [PATCH v3] " Junio C Hamano
2023-07-27 23:14 ` Linus Arver
2023-07-28 0:25 ` Junio C Hamano
2023-07-28 0:43 ` [PATCH v4] " Junio C Hamano
2023-07-28 2:07 ` Jacob Abel
2023-07-28 5:10 ` Junio C Hamano
2023-07-28 15:42 ` Re* " Junio C Hamano
2023-07-29 2:12 ` Jacob Abel
2023-07-31 15:25 ` Junio C Hamano
2023-07-28 2:08 ` Linus Arver
2023-07-28 5:10 ` Junio C Hamano
2023-07-28 21:21 ` Torsten Bögershausen
2023-07-28 23:00 ` Junio C Hamano
2023-01-23 1:47 ` [PATCH] " Sean Allred
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230122071156.367jwwt3d5txvkl4@tb-raspi4 \
--to=tboegi@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).