mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <>
Cc: "Torsten Bögershausen" <>
Subject: [PATCH v3] MyFirstContribution: refrain from self-iterating too much
Date: Wed, 19 Jul 2023 10:04:09 -0700	[thread overview]
Message-ID: <xmqq8rbbbzp2.fsf_-_@gitster.g> (raw)
In-Reply-To: <20230123175804.2bkcr7yawyz5fhkb@tb-raspi4> ("Torsten Bögershausen"'s message of "Mon, 23 Jan 2023 18:58:04 +0100")

Finding mistakes in and improving your own patches is a good idea,
but doing so too quickly is being inconsiderate to reviewers who
have just seen the initial iteration and taking their time to review
it.  Encourage new developers to perform such a self review before
they send out their patches, not after.  After sending a patch that
they immediately found mistakes in, they are welcome to comment on
them, mentioning what and how they plan to improve them in an
updated version, before sending out their updates.

Helped-by: Torsten Bögershausen <>
Signed-off-by: Junio C Hamano <>
 * Sorry for a slow update.  Even though the topic is about not
   updating too quickly, this update was long overdue.  Not a whole
   lot changed.  Primary change is the later part of the proposed
   log message, which was helped by Torsten's comments, to which
   this message is a response to.

 Documentation/MyFirstContribution.txt | 31 +++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/Documentation/MyFirstContribution.txt b/Documentation/MyFirstContribution.txt
index ccfd0cb5f3..1ede3f8e37 100644
--- a/Documentation/MyFirstContribution.txt
+++ b/Documentation/MyFirstContribution.txt
@@ -1256,6 +1256,37 @@ index 88f126184c..38da593a60 100644
 == My Patch Got Emailed - Now What?
+After you sent out your first patch, you may find mistakes in it, or
+a different and better way to achieve the goal of the patch.  But
+please resist the temptation to send a new version immediately.
+ - If the mistakes you found are minor, send a reply to your patch as
+   if you were a reviewer and mention that you will fix them in an
+   updated version.
+ - On the other hand, if you think you want to change the course so
+   drastically that reviews on the initial patch would become
+   useless, send a reply to your patch to say so immediately to
+   avoid wasting others' time (e.g. "I am working on a better
+   approach, so please ignore this patch, and wait for the updated
+   version.")
+Then give reviewers enough time to process your initial patch before
+sending an updated version (unless you retracted the initial patch,
+that is).
+Now, the above is a good practice if you sent your initial patch
+prematurely without polish.  But a better approach of course is to
+avoid sending your patch prematurely in the first place.
+Keep in mind that people in the development community do not have to
+see your patch immediately after you wrote it.  Instead of seeing
+the initial version right now, that will be followed by several
+updated "oops, I like this version better than the previous one"
+versions over 2 days, reviewers would more appreciate if a single
+polished version came 2 days late and that version with fewer
+mistakes were the only one they need to review.
 === Responding to Reviews

  reply	other threads:[~2023-07-19 17:04 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-22  1:51 [PATCH] MyFirstContribution: refrain from self-iterating too much Junio C Hamano
2023-01-22  7:11 ` Torsten Bögershausen
2023-01-22 16:01   ` Junio C Hamano
2023-01-22 17:14     ` Junio C Hamano
2023-01-23  4:18     ` [PATCH v2] " Junio C Hamano
2023-01-23 17:58       ` Torsten Bögershausen
2023-07-19 17:04         ` Junio C Hamano [this message]
2023-07-27 23:14           ` [PATCH v3] " Linus Arver
2023-07-28  0:25             ` Junio C Hamano
2023-07-28  0:43               ` [PATCH v4] " Junio C Hamano
2023-07-28  2:07                 ` Jacob Abel
2023-07-28  5:10                   ` Junio C Hamano
2023-07-28 15:42                     ` Re* " Junio C Hamano
2023-07-29  2:12                       ` Jacob Abel
2023-07-31 15:25                         ` Junio C Hamano
2023-07-28  2:08                 ` Linus Arver
2023-07-28  5:10                   ` Junio C Hamano
2023-07-28 21:21                 ` Torsten Bögershausen
2023-07-28 23:00                   ` Junio C Hamano
2023-01-23  1:47 ` [PATCH] " Sean Allred

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq8rbbbzp2.fsf_-_@gitster.g \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).