From: David Caro <dcaro@wikimedia.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Taylor Blau <me@ttaylorr.com>, git@vger.kernel.org
Subject: Re: Skipping adding Signed-off-by even if it's not the last on git commit
Date: Wed, 7 Dec 2022 09:40:27 +0100 [thread overview]
Message-ID: <20221207084027.7dhyaatkzaawrg4g@vulcanus> (raw)
In-Reply-To: <xmqqlenj7t0b.fsf@gitster.g>
[-- Attachment #1: Type: text/plain, Size: 984 bytes --]
On 12/07 13:11, Junio C Hamano wrote:
> Taylor Blau <me@ttaylorr.com> writes:
>
> >> I propose enabling it for commit, merge and am.
> >
> > So I think that there are some legitimate uses outside of 'format-patch'
> > that we may want to keep the existing behavior. So I don't think we
> > should necessarily change the default to have other commands outside of
> > 'format-patch' start passing APPEND_SIGNOFF_DEDUP.
> >
> > But I could see a future where we add a new option that controls whether
> > or not we pass that flag, perhaps:
> >
> > $ git commit --signoff[=[no-]dedup]
>
> That sounds sensible.
Agree, I will implement this then for commit for now, thanks!
--
David Caro
SRE - Cloud Services
Wikimedia Foundation <https://wikimediafoundation.org/>
PGP Signature: 7180 83A2 AC8B 314F B4CE 1171 4071 C7E1 D262 69C3
"Imagine a world in which every single human being can freely share in the
sum of all knowledge. That's our commitment."
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-12-07 8:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-06 17:06 Skipping adding Signed-off-by even if it's not the last on git commit David Caro
2022-12-07 1:50 ` Taylor Blau
2022-12-07 4:11 ` Junio C Hamano
2022-12-07 8:40 ` David Caro [this message]
2022-12-07 22:13 ` Taylor Blau
2022-12-07 23:04 ` Junio C Hamano
2022-12-08 7:27 ` Jeff King
2022-12-09 1:23 ` Junio C Hamano
2022-12-09 1:42 ` Jeff King
2022-12-09 4:03 ` Junio C Hamano
2022-12-09 20:39 ` Jeff King
2022-12-07 4:31 ` Ævar Arnfjörð Bjarmason
2022-12-07 4:57 ` Junio C Hamano
2022-12-07 15:00 ` Konstantin Ryabitsev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221207084027.7dhyaatkzaawrg4g@vulcanus \
--to=dcaro@wikimedia.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).